D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Nathaniel Graham]

ngraham added a comment.


  Never mind, @zzag discovered that I didn't have the `xorg-x11-server-sdk` 
package installed, so nothing to see here, and sorry for the noise!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: cblack, ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Nathaniel Graham]

ngraham added a comment.


  In D29514#665916 , @cblack wrote:
  
  > That's the source package location, not where you'd expect to find the 
headers for usage by other packages. You'd probably be looking for 
`/usr/include/xorg/xserver-properties.h`.
  
  
  It isn't in there on openSUSE TW.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: cblack, ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Carson Black]

cblack added a comment.


  In D29514#665869 , @ngraham wrote:
  
  > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  >
  >   -- The following features have been disabled:
  >  
  >* XorgServer, XServer header needed for touchpad KCM (X11 backend)
  >  
  >   -- The following OPTIONAL packages have not been found:
  >  
  >* XorgServer, XServer header needed for touchpad KCM (X11 backend)
  >
  
  
  That's the source package location, not where you'd expect to find the 
headers for usage by other packages. You'd probably be looking for 
`/usr/include/xorg/xserver-properties.h`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: cblack, ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Vlad Zahorodnii]

zzag added a comment.


  In D29514#665869 , @ngraham wrote:
  
  > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  
  
  What distro are you running?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D29514#665912 , @ngraham wrote:
  
  > In D29514#665911 , 
@asturmlechner wrote:
  >
  > > In D29514#665869 , @ngraham 
wrote:
  > >
  > > > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  > >
  > >
  > > Where is synaptics-properties.h located on your system, if you even have 
been building touchpad kcm so far?
  >
  >
  > It's in `/usr/include/xorg`.
  >
  > I must confess I've never actually been able to build it, so I appreciate 
your efforts here to fix that.
  
  
  In that case yes it must have failed so far during build, now cmake will warn 
you already. It is now the same as with Evdev, Libinput and Synaptics, if you 
don't have them in system paths you would have to somehow feed the alternative 
paths to cmake.
  
  In D29514#665912 , @ngraham wrote:
  
  > What I'd really like is the ability to build just the libinput one if I 
don't have the synaptics dev stuff installed.
  
  
  Me too, unfortunately that will take a bit more work untangling the bits. In 
our source package I use this patch which enables me to bundle only the four 
headers and get rid of them as build dependencies, then point cmake to the 
bundle dir: 
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-plasma/plasma-desktop/files/plasma-desktop-5.18.5-override-include-dirs.patch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Nathaniel Graham]

ngraham added a comment.


  In D29514#665911 , @asturmlechner 
wrote:
  
  > In D29514#665869 , @ngraham 
wrote:
  >
  > > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  >
  >
  > Where is synaptics-properties.h located on your system, if you even have 
been building touchpad kcm so far?
  
  
  It's in `/usr/include/xorg`.
  
  I must confess I've never actually been able to build it, so I appreciate 
your efforts here to fix that.
  
  What I'd really like is the ability to build just the libinput one if I don't 
have the synaptics dev stuff installed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D29514#665869 , @ngraham wrote:
  
  > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  
  
  Where is synaptics-properties.h located on your system, if you even have been 
building touchpad kcm so far?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Nathaniel Graham]

ngraham added a comment.


  Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  
-- The following features have been disabled:

 * XorgServer, XServer header needed for touchpad KCM (X11 backend)

-- The following OPTIONAL packages have not been found:

 * XorgServer, XServer header needed for touchpad KCM (X11 backend)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  x11 backend of the touchpad KCM uses xserver-properties.h that is part of
  xorg-server package. As XORG_INCLUDE_DIRS seems to be empty, so far, it was
  relying on Synaptics_INCLUDE_DIRS implicitly and worked only if the header
  happened to be in the same directory as Synaptics' which is the case most of
  the time.
  
  FindXorgServer.cmake is just a copy of FindXorgLibinput, adapted accordingly.

TEST PLAN
  Pointed Synaptics_INCLUDE_DIRS somewhere else than /usr/include/xorg and build
  succeeded.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29514

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXorgServer.cmake
  kcms/CMakeLists.txt
  kcms/touchpad/backends/x11.cmake

To: asturmlechner, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart