D29544: [applets/systemtray] Show base icon when AttentionIcon not set

2020-05-11 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R120:00e64bdb3fa9: [applets/systemtray] Show base icon when AttentionIcon not set (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

2020-05-11 Thread Konrad Materka
kmaterka added a comment. Can we have it reviewed before 5.19 release? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29544 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

2020-05-11 Thread Konrad Materka
kmaterka added a comment. Firstly, AttentionIcon support was introduced in D24865 . It had a bug, fixed for 5.18 in D29386 . When I merged branch 5.18 (with D29386 ) into master, by

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

2020-05-08 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY If status is set to NeedsAttention it