D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-11 Thread Mariusz Libera
mlibera abandoned this revision. mlibera added a comment. > In terms of actions this means: > > - exposing KStandardAction::rotateUp/rotateDown somewhere generic > - porting from KeyEvent to Shortcuts inside the QML Thanks for the explanation. This sounds like a time-consuming

D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-10 Thread David Edmundson
davidedmundson added a comment. > Does the mechanism of standard shortcuts really apply here? It's not implementing it yet, but that's the entire point. The bigger problem is someone added some vim shortcuts to krunner a year ago: (plasma-workspace

D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-09 Thread Mariusz Libera
mlibera added a comment. Does the mechanism of standard shortcuts really apply here? Just below the code I added is the code explicitly handling keys like Qt.Key_Up, Qt.Key_Down, Qt.Key_Tab, etc. Seems like it's all hardcoded. Adding those keybinding to standard shortcuts has no effect.

D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-09 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. KDE has a concept of "standard shortcuts". Instead of duplicating this same code everywhere with various combinations for people doing all sorts of crazy

D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-09 Thread Mariusz Libera
mlibera created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlibera requested review of this revision. REVISION SUMMARY Users used to emacs/bash style of navigation and editing might appreciate a basic support for it in Kickoff, especially Ctrl+n/p