D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-14 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7a4ea26a6561: Automatically close Clipboard applet after clearing history or deleting theā€¦ (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-14 Thread Eugene Popov
epopov updated this revision to Diff 82816. epopov added a comment. You're right. Fixed. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29652?vs=82565=82816 REVISION DETAIL https://phabricator.kde.org/D29652 AFFECTED FILES

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-13 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > clipboard.qml:33 > Plasmoid.switchHeight: units.gridUnit * 5 > -Plasmoid.status: clipboardSource.data["clipboard"]["empty"] ? > PlasmaCore.Types.PassiveStatus : PlasmaCore.Types.ActiveStatus > Plasmoid.toolTipMainText:

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-11 Thread Eugene Popov
epopov added a comment. Currently, the Notifications applet closes itself when the last element (notification) is removed (or all elements are removed by pressing "Clear History" button in the top-right corner). But also it closes itself, even if the applet is pinned, and I guess that this

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-11 Thread Nathaniel Graham
ngraham added a comment. > (similar to how the Notification applet closes after the last notification is removed). But you're changing that in D29651 ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29652 To:

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-11 Thread Eugene Popov
epopov added a comment. I believe that there is a better solution, but I did not come up with it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29652 To: epopov, ngraham, plasma-devel Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-11 Thread Eugene Popov
epopov created this revision. epopov added reviewers: ngraham, plasma-devel. Herald added a project: Plasma. epopov requested review of this revision. REVISION SUMMARY It would be correct to close the Clipboard applet after clearing the history or deleting the last element, since there is