davidedmundson closed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4830
To: davidedmundson, #plasma, broulik
Cc: obnosim, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
davidedmundson added a comment.
Urgh thanks :/
Also, in future can you comment on the commit on phabricator not the review
so it starts a new thread. It's very hard to find otherwise.
I only noticed this just now by accident.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https:/
obnosim reopened this revision.
obnosim added a comment.
This revision is now accepted and ready to land.
There is an issue in file desktoppackage/contents/views/Panel.qml line 57:
Instead of
prefix = [prefix, ""];
it should be
prefix = [pre, ""];
otherwise (as is c
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a521ac8f8882: Adjust plasma-desktop to the new fallback
prefixes (authored by davidedmundson).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4830?vs=11967&i
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
When I move my panel around I get warnings
The image "widgets/tasks" doesn't contain any of the prefixes ("south-", "")
but I think that is a false-positive.
REPOSITORY
R119
davidedmundson updated this revision to Diff 11967.
davidedmundson added a comment.
Proper handling of TaskProgressOverlay
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4830?vs=11958&id=11967
BRANCH
master
REVISION DETAIL
https://phabricator.k
broulik added inline comments.
INLINE COMMENTS
> TaskProgressOverlay.qml:46
> imagePath: "widgets/tasks"
> -prefix: calculatePrefix()
> -onRepaintNeeded: prefix = calculatePrefix()
> -
> -function calculatePrefix() {
> -var prefix =
davidedmundson marked an inline comment as done.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4830
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, al
davidedmundson updated this revision to Diff 11958.
davidedmundson added a comment.
Fixed a stupid mistake
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4830?vs=11911&id=11958
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4830
AF
broulik added inline comments.
INLINE COMMENTS
> TaskProgressOverlay.qml:46
> imagePath: "widgets/tasks"
> -prefix: calculatePrefix()
> -onRepaintNeeded: prefix = calculatePrefix()
> -
> -function calculatePrefix() {
> -var prefix =
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Grepped code for repaintNeeded on prefixes and adjusted as appropriately to
match
https://phabricator.kde.org/D4827
TEST PLAN
Boot
11 matches
Mail list logo
