D5510: Improve how we set up the flatpak backend

2017-04-20 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:32cbc50cb819: Improve how we set up the flatpak backend (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5510?vs=13600=13627#toc REPOSITORY R134 Discover Software Store

D5510: Improve how we set up the flatpak backend

2017-04-20 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. If we cannot realy on id or display name for flatpak installation then we can stick with installation path :) REPOSITORY R134 Discover Software Store BRANCH flatpak-installations

D5510: Improve how we set up the flatpak backend

2017-04-20 Thread Jan Grulich
jgrulich added a comment. Overall looks good to me, I also now understand why you don't use appScope as part of the unique id, hovewer I've been suggested by Alex to use flatpak_installation_get_display_name() or flatpak_installation_get_id(), which would result into a more readable unique

D5510: Improve how we set up the flatpak backend

2017-04-19 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove the scope semantic and make the installation part of each resource. REPOSITORY R134 Discover Software Store BRANCH