D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi updated this revision to Diff 26493. gregormi added a comment. - Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does not work (I will remove it if that's not easily fixable) REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi updated this revision to Diff 26491. gregormi added a comment. - fix cleanup old code from previous revision REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=26490&id=26491 BRANCH arcpatch-D7087 REVISION DETAIL https://phabricator.k

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi updated this revision to Diff 26490. gregormi added a comment. - cleanup old code from previous revision REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=26489&id=26490 BRANCH arcpatch-D7087 REVISION DETAIL https://phabricator.kde.o

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi updated this revision to Diff 26489. gregormi added a comment. - remove menu and update button position REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=17613&id=26489 BRANCH arcpatch-D7087 REVISION DETAIL https://phabricator.kde.or

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi added a comment. Screenshot of new button location: F5691627: grafik.png Updated code follows. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas, elvisangelaccio, cfec

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi edited the summary of this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

ltoscano added a comment. There is already the "Plasma" tag and the plasma-devel is in the list of subscribers; I don't see the reason to add explicit reviewers, as the changes of the bug are notified in the proper place. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.k

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

ngraham added a comment. Thanks. Would the "Plasma" review group be appropriate? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

ltoscano removed a reviewer: KDE Applications. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

ltoscano added a comment. Removed the "KDE Applications" group: KInfoCenter is part of Plasma, not KDE Applications. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, pr

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

ngraham added a reviewer: KDE Applications. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, #kde_applications Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensre

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

ngraham added a comment. Also, please add "BUG: 366266" to the Summary so that https://bugs.kde.org/show_bug.cgi?id=366266 gets closed automatically when this goes in. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: sebas, elvisan

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

ngraham added a comment. I agree with @elvisangelaccio that we should just have a simple "Copy to clipboard" button--probably down at the bottom, aligned with the other buttons (on the left side seems right to me). It seems a bit silly to have a menu button with only two menu items in it, es

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi added a reviewer: ngraham. gregormi added a comment. Hi Nate, do you have any suggestions to add to this RR? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi added a comment. Any suggestions how to proceed with this? I personally find the position of the menu not out of place because it is centered like the main dialog's content. The reason I put the "About KDE" item into the menu is because it is the "Info" dialog and there an

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi added a comment. > 2. In KInfoCenter the "Module Help" button seems to be broken. E.g. "Help" on the Memory KCM starts the Help Center at the correct location but the corresponding "Module Help" button in KInfoCenter opens a Help Center page titled with "Documentation not Found".

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi added a comment. In https://phabricator.kde.org/D7087#131728, @elvisangelaccio wrote: > In https://phabricator.kde.org/D7087#131719, @gregormi wrote: > > > > I see that you are adding also the "About KDE" action in the menu, but that action is already in the Help menu from th

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi added a comment. In https://phabricator.kde.org/D7087#131726, @sebas wrote: > In https://phabricator.kde.org/D7087#131719, @gregormi wrote: > > > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote: > > > > > Why not just a "Copy to clipboard" button (witho

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

elvisangelaccio added a comment. In https://phabricator.kde.org/D7087#131719, @gregormi wrote: > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote: > > > Why not just a "Copy to clipboard" button (without a menu)? > > > I thought that might look too obstrusive f

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

sebas added a comment. In https://phabricator.kde.org/D7087#131719, @gregormi wrote: > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote: > > > Why not just a "Copy to clipboard" button (without a menu)? > The current button / menu looks out of place to me,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi updated this revision to Diff 17613. gregormi added a comment. - remove obsolete KCOREADDONS_VERSION check REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=17611&id=17613 BRANCH master REVISION DETAIL https://phabricator.kde.org/D70

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi added a comment. In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote: > Why not just a "Copy to clipboard" button (without a menu)? I thought that might look too obstrusive for those who just what to see the version without a copy intent. > I see that

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi edited the summary of this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi Cc: elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

elvisangelaccio added a comment. Why not just a "Copy to clipboard" button (without a menu)? I see that you are adding also the "About KDE" action in the menu, but that action is already in the Help menu from the toolbar. What's the point of adding it twice? REPOSITORY R102 KInfoCenter RE

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

cfeck added a comment. BUG: 366266 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi retitled this revision from "WIP: Add menu with "Copy to Clipboard" to the About System module ui change" to "WIP: Add menu with "Copy to Clipboard" to the About System module". gregormi edited the summary of this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabr