D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi updated this revision to Diff 26493.
gregormi added a comment.


  - Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does not 
work (I will remove it if that's not easily fixable)

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=26491&id=26493

BRANCH
  arcpatch-D7087

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi updated this revision to Diff 26491.
gregormi added a comment.


  - fix cleanup old code from previous revision

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=26490&id=26491

BRANCH
  arcpatch-D7087

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi updated this revision to Diff 26490.
gregormi added a comment.


  - cleanup old code from previous revision

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=26489&id=26490

BRANCH
  arcpatch-D7087

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  CMakeLists.txt
  Modules/about-distro/src/CMakeLists.txt
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi updated this revision to Diff 26489.
gregormi added a comment.


  - remove menu and update button position

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=17613&id=26489

BRANCH
  arcpatch-D7087

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/CMakeLists.txt
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi added a comment.


  Screenshot of new button location: F5691627: grafik.png 

  Updated code follows.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi edited the summary of this revision.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Luigi Toscano]

ltoscano added a comment.


  There is already the "Plasma" tag and the plasma-devel is in the list of 
subscribers; I don't see the reason to add explicit reviewers, as the changes 
of the bug are notified in the proper place.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Nathaniel Graham]

ngraham added a comment.


  Thanks. Would the "Plasma" review group be appropriate?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Luigi Toscano]

ltoscano removed a reviewer: KDE Applications.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Luigi Toscano]

ltoscano added a comment.


  Removed the "KDE Applications" group: KInfoCenter is part of Plasma, not KDE 
Applications.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Nathaniel Graham]

ngraham added a reviewer: KDE Applications.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, #kde_applications
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Nathaniel Graham]

ngraham requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Nathaniel Graham]

ngraham added a comment.


  Also, please add "BUG: 366266" to the Summary so that 
https://bugs.kde.org/show_bug.cgi?id=366266 gets closed automatically when this 
goes in.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Nathaniel Graham]

ngraham added a comment.


  I agree with @elvisangelaccio that we should just have a simple "Copy to 
clipboard" button--probably down at the bottom, aligned with the other buttons 
(on the left side seems right to me). It seems a bit silly to have a menu 
button with only two menu items in it, especially when one of them is just 
there to take up space and prevent the awkwardness of having a menu with only a 
single button. :)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi added a reviewer: ngraham.
gregormi added a comment.


  Hi Nate, do you have any suggestions to add to this RR?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi added a comment.


  Any suggestions how to proceed with this?
  
  I personally find the position of the menu not out of place because it is 
centered like the main dialog's content.
  
  The reason I put the "About KDE" item into the menu is because it is the 
"Info" dialog and there an emphasized presence of the software's origin (KDE) 
seemed justified to me.
  
  I thought the string "Copy to clipboard" is visually too long to have it 
directly on the dialog.
  
  That said, the easiest way to proceed - if the current state is not 
acceptable - was to change it as @elvisangelaccio wrote:
  
  >   Why not just a "Copy to clipboard" button (without a menu)?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi added a comment.


  > 2. In KInfoCenter the "Module Help" button seems to be broken. E.g. "Help" 
on the Memory KCM starts the Help Center at the correct location but the 
corresponding "Module Help" button in KInfoCenter opens a Help Center page 
titled with "Documentation not Found".
  
  I reported the bug here: https://bugs.kde.org/show_bug.cgi?id=383116

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi added a comment.


  In https://phabricator.kde.org/D7087#131728, @elvisangelaccio wrote:
  
  > In https://phabricator.kde.org/D7087#131719, @gregormi wrote:
  >
  > > > I see that you are adding also the "About KDE" action in the menu, but 
that action is already in the Help menu from the toolbar. What's the point of 
adding it twice?
  > >
  > > Yes, the "About KDE" is already in the help menu of KInfoCenter. I 
thought about the situation when the "About System" module is started 
stand-alone (e.g. when you enter "About" in KRunner then "About System" is 
proposed).
  > >
  > > In general, I would find it helpful if there was a menu item that opens 
KInfoCenter; but only if "About System" is shown stand-alone. I don't know how 
to determine if a system setting module is started stand-alone.
  >
  >
  > Oh I didn't even know that kinfocenter was a collection of kcm modules. I 
wonder if that should be implemented for all KCMs: currently the Help button in 
a stand-alone KCM just opens the kcm dockbook, maybe it could open the 
full-fledged Help menu?
  
  
  
  
  1. In Spectacle the Help button on the left bottom corner is implemented as 
you described: as a menu button. +1 for having that in the KCMs, too.
  2. In KInfoCenter the "Module Help" button seems to be broken. E.g. "Help" on 
the Memory KCM starts the Help Center at the correct location but the 
corresponding "Module Help" button in KInfoCenter opens a Help Center page 
titled with "Documentation not Found".

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi added a comment.


  In https://phabricator.kde.org/D7087#131726, @sebas wrote:
  
  > In https://phabricator.kde.org/D7087#131719, @gregormi wrote:
  >
  > > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote:
  > >
  > > > Why not just a "Copy to clipboard" button (without a menu)?
  > >
  >
  >
  > The current button / menu looks out of place to me, like it was just 
randomly put there. I am not sure what would look better, perhaps there's a HIG 
for this, otherwise, I think this needs input from a UI designer. Just 
"dumping" a button in there makes it look too random and unpolished.
  
  
  Yes, input is appreciated.
  
  > How about making the text selectable so it can be copied and being done 
with it?
  
  I thought so, too. Three thoughts:
  
  1. If one uses a simple readonly text box, then the current formatting could 
not be kept.
  2. One could do it like in the dolphin address bar. If the user clicks 
somewhere on the text, the view changes and the text becomes copyable. This 
option seems overly complex to implement to me but maybe the most intuitive 
option.
  3. Use a HTML view where selecting text should be possible?
  
  >> I thought that might look too obstrusive for those who just what to see 
the version without a copy intent.
  >> 
  >>> I see that you are adding also the "About KDE" action in the menu, but 
that action is already in the Help menu from the toolbar. What's the point of 
adding it twice?
  >> 
  >> Yes, the "About KDE" is already in the help menu of KInfoCenter. I thought 
about the situation when the "About System" module is started stand-alone (e.g. 
when you enter "About" in KRunner then "About System" is proposed).
  > 
  > That would in principle mean to copy every bit of information in 
kinfocenter to its individual modules. Let's not do that.
  
  Only the important parts :)
  
  >> In general, I would find it helpful if there was a menu item that opens 
KInfoCenter; but only if "About System" is shown stand-alone. I don't know how 
to determine if a system setting module is started stand-alone.
  
  Many users (including me and - reading his last comment - apparently Elivis, 
too :-)) are not aware of the KCM module structure. I would like to find a way 
to show the user that if a stand-alone module is open that it can be part of 
something bigger with more options and features to discover. (A similar example 
is the "System Activity" which can also be part of KSysGuard; see 
https://git.reviewboard.kde.org/r/128854/).

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D7087#131719, @gregormi wrote:
  
  > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote:
  >
  > > Why not just a "Copy to clipboard" button (without a menu)?
  >
  >
  > I thought that might look too obstrusive for those who just what to see the 
version without a copy intent.
  
  
  Well imho a menu is just as obstrusive, and it requires one more click to 
actually perform the copy operation.
  
  > 
  > 
  >> I see that you are adding also the "About KDE" action in the menu, but 
that action is already in the Help menu from the toolbar. What's the point of 
adding it twice?
  > 
  > Yes, the "About KDE" is already in the help menu of KInfoCenter. I thought 
about the situation when the "About System" module is started stand-alone (e.g. 
when you enter "About" in KRunner then "About System" is proposed).
  > 
  > In general, I would find it helpful if there was a menu item that opens 
KInfoCenter; but only if "About System" is shown stand-alone. I don't know how 
to determine if a system setting module is started stand-alone.
  
  Oh I didn't even know that kinfocenter was a collection of kcm modules. I 
wonder if that should be implemented for all KCMs: currently the Help button in 
a stand-alone KCM just opens the kcm dockbook, maybe it could open the 
full-fledged Help menu?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Sebastian Kügler]

sebas added a comment.


  In https://phabricator.kde.org/D7087#131719, @gregormi wrote:
  
  > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote:
  >
  > > Why not just a "Copy to clipboard" button (without a menu)?
  >
  
  
  The current button / menu looks out of place to me, like it was just randomly 
put there. I am not sure what would look better, perhaps there's a HIG for 
this, otherwise, I think this needs input from a UI designer. Just "dumping" a 
button in there makes it look too random and unpolished.
  
  How about making the text selectable so it can be copied and being done with 
it?
  
  > I thought that might look too obstrusive for those who just what to see the 
version without a copy intent.
  > 
  >> I see that you are adding also the "About KDE" action in the menu, but 
that action is already in the Help menu from the toolbar. What's the point of 
adding it twice?
  > 
  > Yes, the "About KDE" is already in the help menu of KInfoCenter. I thought 
about the situation when the "About System" module is started stand-alone (e.g. 
when you enter "About" in KRunner then "About System" is proposed).
  
  That would in principle mean to copy every bit of information in kinfocenter 
to its individual modules. Let's not do that.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi updated this revision to Diff 17613.
gregormi added a comment.


  - remove obsolete KCOREADDONS_VERSION check

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=17611&id=17613

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/CMakeLists.txt
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi
Cc: elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi added a comment.


  In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote:
  
  > Why not just a "Copy to clipboard" button (without a menu)?
  
  
  I thought that might look too obstrusive for those who just what to see the 
version without a copy intent.
  
  > I see that you are adding also the "About KDE" action in the menu, but that 
action is already in the Help menu from the toolbar. What's the point of adding 
it twice?
  
  Yes, the "About KDE" is already in the help menu of KInfoCenter. I thought 
about the situation when the "About System" module is started stand-alone (e.g. 
when you enter "About" in KRunner then "About System" is proposed).
  
  In general, I would find it helpful if there was a menu item that opens 
KInfoCenter; but only if "About System" is shown stand-alone. I don't know how 
to determine if a system setting module is started stand-alone.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi edited the summary of this revision.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Why not just a "Copy to clipboard" button (without a menu)? I see that you 
are adding also the "About KDE" action in the menu, but that action is already 
in the Help menu from the toolbar. What's the point of adding it twice?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[Christoph Feck]

cfeck added a comment.


  BUG: 366266

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

[gregormi]

gregormi retitled this revision from "WIP: Add menu with "Copy to Clipboard" to 
the About System module

ui change" to "WIP: Add menu with "Copy to Clipboard" to the About System 
module".
gregormi edited the summary of this revision.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas