D7181: [Task Manager] Elide context menu entries

2018-04-24 Thread Kai Uwe Broulik 
This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2bf23482a1bf: [Task Manager] Elide context menu entries 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7181?vs=17822=33019#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7181?vs=17822=33019

REVISION DETAIL
  https://phabricator.kde.org/D7181

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/code/layout.js

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7181: [Task Manager] Elide context menu entries

2017-10-24 Thread Eike Hein 
hein added a comment.


  Kai, ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7181

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7181: [Task Manager] Elide context menu entries

2017-08-08 Thread Eike Hein 
hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ContextMenu.qml:126
> +if (elided) {
> +item.action.text += "...";
> +}

We can't hard-code "...". Different locales use different characters for text 
elision (e.g. an actual ellipsis, not three dots).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7181

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7181: [Task Manager] Elide context menu entries

2017-08-07 Thread Kai Uwe Broulik 
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QMenu doesn't really support maximumWidth. The window's size would be limited 
but its content just cut off rather than nicely elided.
  Instead, we manually elide in a crude way using TextMetrics.

TEST PLAN
  Superseds https://phabricator.kde.org/D4281
  
  Opened a file with a super long file name in kwrite, no longer caused the 
menu to become huge

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7181

AFFECTED FILES
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas