D7214: Add virtual Scene::scenePainter method
This revision was automatically updated to reflect the committed changes. Closed by commit R108:ad4a3107d548: Add virtual Scene::scenePainter method (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7214?vs=17914=17930 REVISION DETAIL https://phabricator.kde.org/D7214 AFFECTED FILES effects.cpp scene.cpp scene.h scene_qpainter.cpp scene_qpainter.h To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7214: Add virtual Scene::scenePainter method
davidedmundson accepted this revision. This revision is now accepted and ready to land. BRANCH scene-qpainter REVISION DETAIL https://phabricator.kde.org/D7214 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7214: Add virtual Scene::scenePainter method
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So far EffectsHandlerImpl directly accessed SceneQPainter::painter through a dynamic cast. If in future the QPainter based compositor should be moved into a plugin we cannot access it through a dynamic cast. To solve this problem the painter method is moved into Scene as a virtual method returning a sane default value. BRANCH scene-qpainter REVISION DETAIL https://phabricator.kde.org/D7214 AFFECTED FILES effects.cpp scene.cpp scene.h scene_qpainter.cpp scene_qpainter.h To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
