D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-12-03 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:fe9664fd8469: Use the new ECMQMLModules to specify all of KWins runtime dependencies (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. CHANGED PRIOR TO

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-09-06 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7273#143252, @apol wrote: > > I think we first need to get https://phabricator.kde.org/D7543 in, to be able to depend from the ECM version. > > I don't see how it's related ECMFindQMLModule is only available in ECM

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-09-05 Thread Aleix Pol Gonzalez
apol added a comment. > I think we first need to get https://phabricator.kde.org/D7543 in, to be able to depend from the ECM version. I don't see how it's related REPOSITORY R108 KWin BRANCH ecmqmlmodules REVISION DETAIL https://phabricator.kde.org/D7273 To: graesslin, #kwin,

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-09-05 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7273#142926, @apol wrote: > In https://phabricator.kde.org/D7273#138099, @graesslin wrote: > > > ping, anything speaking against pushing it? > > > Push? :) I think we first need to get

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-09-04 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D7273#138099, @graesslin wrote: > ping, anything speaking against pushing it? Push? :) REPOSITORY R108 KWin BRANCH ecmqmlmodules REVISION DETAIL https://phabricator.kde.org/D7273 To: graesslin, #kwin, #plasma, bshah

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-08-21 Thread Bhushan Shah
bshah accepted this revision as: Plasma, bshah. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH ecmqmlmodules REVISION DETAIL https://phabricator.kde.org/D7273 To: graesslin, #kwin, #plasma, bshah Cc: bshah, apol, plasma-devel, kwin, ZrenBot, progwolff,

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-08-21 Thread Martin Flöser
graesslin added a comment. ping, anything speaking against pushing it? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7273 To: graesslin, #kwin, #plasma Cc: bshah, apol, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg,

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-08-13 Thread Aleix Pol Gonzalez
apol added a comment. I tested the patch, for me it worked for all but VirtualKeyboard (which might be indeed missing). I'd suggest to look into why your qmlplugindump isn't returning what it should REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7273 To:

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-08-12 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7273#134905, @bshah wrote: > In https://phabricator.kde.org/D7273#134903, @graesslin wrote: > > > @apol any idea why several of the packages are reported not found? > > > Please try to run `qmlplguindump QtQuick.Controls

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-08-12 Thread Bhushan Shah
bshah added a comment. In https://phabricator.kde.org/D7273#134903, @graesslin wrote: > @apol any idea why several of the packages are reported not found? Please try to run `qmlplguindump QtQuick.Controls 1.2` for instance and paste it's output here. REPOSITORY R108 KWin

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-08-12 Thread Martin Flöser
graesslin added a subscriber: apol. graesslin added a comment. @apol any idea why several of the packages are reported not found? -- The following RUNTIME packages have not been found: * QtQuick.Controls-QMLModule , QML module 'QtQuick.Controls' is a runtime dependency.

D7273: Use the new ECMQMLModules to specify all of KWin's runtime dependencies

2017-08-12 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REPOSITORY R108 KWin BRANCH ecmqmlmodules REVISION DETAIL https://phabricator.kde.org/D7273 AFFECTED FILES CMakeLists.txt To: graesslin, #kwin,