D7436: kimpanel: change highlight color

2017-08-23 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5377b6b03b8d: kimpanel: change highlight color (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7436?vs=18624=18628 REVISION

D7436: kimpanel: change highlight color

2017-08-23 Thread Xuetian Weng
xuetianweng added a comment. That's a bug in breeze. Should be fixed with https://phabricator.kde.org/D7491 REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D7436 REVISION DETAIL https://phabricator.kde.org/D7436 To: xuetianweng, #plasma, guoyunhe Cc: xuetianweng, plasma-devel,

D7436: kimpanel: change highlight color

2017-08-23 Thread Yunhe Guo
guoyunhe accepted this revision. guoyunhe added a comment. This revision is now accepted and ready to land. F3874133: Screenshot_20170823_225448.png It looks good. Only one small problem: when hovering mouse on selected candidate, its height will

D7436: kimpanel: change highlight color

2017-08-23 Thread Xuetian Weng
xuetianweng edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: xuetianweng, #plasma, guoyunhe Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

2017-08-23 Thread Xuetian Weng
xuetianweng updated this revision to Diff 18624. xuetianweng added a comment. Use plasma svg as highlight REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7436?vs=18451=18624 BRANCH arcpatch-D7436 REVISION DETAIL

D7436: kimpanel: change highlight color

2017-08-23 Thread Xuetian Weng
xuetianweng commandeered this revision. xuetianweng added a reviewer: guoyunhe. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: xuetianweng, #plasma, guoyunhe Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7436: kimpanel: change highlight color

2017-08-21 Thread Yunhe Guo
guoyunhe added a comment. In https://phabricator.kde.org/D7436#138011, @xuetianweng wrote: > Can you try to make use of PlasmaComponents.Highlight instead of custom highlight like this? Tried and failed... So I have to leave it like this... REPOSITORY R119 Plasma Desktop

D7436: kimpanel: change highlight color

2017-08-20 Thread Xuetian Weng
xuetianweng added a comment. Can you try to make use of PlasmaComponents.Highlight instead of custom highlight like this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: guoyunhe, #plasma Cc: xuetianweng, plasma-devel, ZrenBot, progwolff,

D7436: kimpanel: change highlight color

2017-08-20 Thread Yunhe Guo
guoyunhe edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: guoyunhe, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

2017-08-20 Thread Yunhe Guo
guoyunhe added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: guoyunhe, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

2017-08-20 Thread Yunhe Guo
guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Before: Highlighted candidate uses theme.highlightColor for text, but this color should only be used in background color, not text