D7724: [ListItemBase] Open options menu on right click

[Kai Uwe Broulik]

broulik added a comment.


  https://invent.kde.org/plasma/plasma-pa/-/merge_requests/1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D7724: [ListItemBase] Open options menu on right click

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Will revisit on GitLab. Code has changed too much

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D7724: [ListItemBase] Open options menu on right click

[Nathaniel Graham]

ngraham added a comment.


  I'd also prefer for the menu to open under the mouse, if it's not 
ridiculously difficult to implement.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

[David Rosca]

drosca added a comment.


  In D7724#253041 , @broulik wrote:
  
  > Should we go for it or abandon this?
  
  
  If it gets +1 from VDG.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

[Kai Uwe Broulik]

broulik added a comment.


  Should we go for it or abandon this?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

[Kai Uwe Broulik]

broulik added a comment.


  We have *both* now. The visual menu button and the "non-discoverable" context 
menu accessible through right-clicking the entire area

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

[David Rosca]

drosca added a comment.


  We're back to the context menu discussion. But to me, this feels weird, the 
context menu should be opened under cursor.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

[Kai Uwe Broulik]

broulik updated this revision to Diff 19275.
broulik added a comment.


  - Also highlight menu button while context menu is open

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7724?vs=19274=19275

REVISION DETAIL
  https://phabricator.kde.org/D7724

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  The menu is still attached to the menu button regardless of where I click but 
I don't neccessarily need to aim for that tiny button anymore.
  
  Middle click to mute still works.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart