D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:101b5f749aa9: Add KCM for adjusting QtQuick Rendering in 
Plasma (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7934?vs=32811&id=32879

REVISION DETAIL
  https://phabricator.kde.org/D7934

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/qtquicksettings/CMakeLists.txt
  kcms/qtquicksettings/Messages.sh
  kcms/qtquicksettings/kcmqtquicksettings.cpp
  kcms/qtquicksettings/kcmqtquicksettings.h
  kcms/qtquicksettings/kcmqtquicksettingswidget.ui
  kcms/qtquicksettings/qtquicksettings.desktop
  kcms/qtquicksettings/renderer.kcfg
  kcms/qtquicksettings/renderersettings.kcfgc

To: davidedmundson, #plasma, mart
Cc: abetts, mart, graesslin, alexeymin, sebas, broulik, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, apol

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[Andres Betts]

abetts added a comment.


  In D7934#251775 , @davidedmundson 
wrote:
  
  > You can, but given it's intended audience and how hidden it now is, it 
really isn't worth putting a lot of time into.
  >
  > If you don't know what a render loop is, you most definitely don't want to 
change it
  
  
  Love your logic! :D Will do!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: abetts, mart, graesslin, alexeymin, sebas, broulik, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, apol

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[David Edmundson]

davidedmundson added a comment.


  You can, but given it's intended audience and how hidden it now is, it really 
isn't worth putting a lot of time into.
  
  If you don't know what a render loop is, you most definitely don't want to 
change it

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: abetts, mart, graesslin, alexeymin, sebas, broulik, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, apol

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[Andres Betts]

abetts added a comment.


  In D7934#147843 , @davidedmundson 
wrote:
  
  > F3921193: Spectacle.n23639.png 
  
  
  Maybe I can help with this? Also, following the idea of simple, can we add 
explanatory text to these settings?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: abetts, mart, graesslin, alexeymin, sebas, broulik, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, apol

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[David Edmundson]

davidedmundson updated this revision to Diff 32811.
davidedmundson added a comment.


  Hide in systemsettings whilst keeping in krunner

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7934?vs=19780&id=32811

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7934

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/qtquicksettings/CMakeLists.txt
  kcms/qtquicksettings/Messages.sh
  kcms/qtquicksettings/kcmqtquicksettings.cpp
  kcms/qtquicksettings/kcmqtquicksettings.h
  kcms/qtquicksettings/kcmqtquicksettingswidget.ui
  kcms/qtquicksettings/qtquicksettings.desktop
  kcms/qtquicksettings/renderer.kcfg
  kcms/qtquicksettings/renderersettings.kcfgc

To: davidedmundson, #plasma
Cc: mart, graesslin, alexeymin, sebas, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[Kai Uwe Broulik]

broulik added a comment.


  Ping

INLINE COMMENTS

> kcmqtquicksettingswidget.ui:21
> +   
> +
> + 

Not fond of abusing `KMessageWidget` for something that isn't action-feedback 
but this KCM doesn't need to be pretty anyway.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: mart, graesslin, alexeymin, sebas, broulik, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[David Edmundson]

davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  > expert settings that you shouldn't use like, ever
  
  I do want some people to use them, if I didn't, I wouldn't have written a KCM 
in the first place.
  
  and just make it a KCM you can launch from KRunner.
  
  > @mart  any idea how I can do that?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: mart, graesslin, alexeymin, sebas, broulik, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[Marco Martin]

mart added a comment.


  could them even be merged in the same hidden kcm called "expert settings that 
you shouldn't use like, ever"? and maybe giving a nice colr palette of red on 
red :p

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: mart, graesslin, alexeymin, sebas, broulik, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[Martin Flöser]

graesslin added a comment.


  Out from experience with the KWin Compositing kcm: hide it well, add more 
warnings and hide it even more. No matter how much you warn against the 
settings users will change them. Even if it tells them it's the wrong setting 
for their system and it's going to break there system: we got bug reports for 
that.
  
  Given that I'd suggest to not include it in systemsettings and just make it a 
KCM you can launch from KRunner.
  
  Unrelated: I will piggyback on that for KWin ;-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: graesslin, alexeymin, sebas, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[Sebastian Kügler]

sebas added a comment.


  Thinking of it, wouldn't it make total sense to have this as a QtQuick-only 
KCM, i.e. using KQuickAddons::ConfigModule?

INLINE COMMENTS

> qtquicksettings.desktop:13
> +X-KDE-Weight=60
> +
> +Name=Plasma Renderer

License key would be nice.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[Sebastian Kügler]

sebas added a comment.


  Maybe not put it in systemsettings, but tell users to run kcmshell to open 
it? That really hides it well though, also defeating the purpose...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[David Edmundson]

davidedmundson updated this revision to Diff 19780.
davidedmundson added a comment.


  Apparently I'm not good at spelliing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7934?vs=19778&id=19780

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7934

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/qtquicksettings/CMakeLists.txt
  kcms/qtquicksettings/Messages.sh
  kcms/qtquicksettings/kcmqtquicksettings.cpp
  kcms/qtquicksettings/kcmqtquicksettings.h
  kcms/qtquicksettings/kcmqtquicksettingswidget.ui
  kcms/qtquicksettings/qtquicksettings.desktop
  kcms/qtquicksettings/renderer.kcfg
  kcms/qtquicksettings/renderersettings.kcfgc

To: davidedmundson, #plasma
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[David Edmundson]

davidedmundson added a comment.


  In https://phabricator.kde.org/D7934#147847, @sebas wrote:
  
  > Can we hide this even more, given that it's an utter expert setting?
  
  
  Any idea where though?
  
  One of my next goals was to make Plasmashell set to use the software 
renderering if it detects that the context failed to create,
  so I do need a somewhat user-visible way for people to reset things once they 
have things sorted.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[Sebastian Kügler]

sebas added a comment.


  Can we hide this even more, given that it's an utter expert setting?

INLINE COMMENTS

> qtquicksettings.desktop:14
> +
> +Name=Plasma Rendererer
> +

I think you forgot a few "er", it should be Plasma Renderererererererer, no? ;-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[David Edmundson]

davidedmundson added a comment.


  F3921193: Spectacle.n23639.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kcmqtquicksettings.cpp:53
> +
> +connect(m_ui->backendCombo, static_cast (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, static_cast (KCMQtQuickSettingsModule::*)()>(&KCMQtQuickSettingsModule::changed));
> +connect(m_ui->renderLoopCombo, static_cast (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, static_cast (KCMQtQuickSettingsModule::*)()>(&KCMQtQuickSettingsModule::changed));

use `activated`

> kcmqtquicksettingswidget.ui:63
> + 
> +  
> +   

Typo

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7934

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Does what you imagine it would.
  It's akin to KWin's compositor settings, designed to be hidden away and
  not used by 99%.

TEST PLAN
  Set some values
  Looked at config.
  Unset set values

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7934

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/qtquicksettings/CMakeLists.txt
  kcms/qtquicksettings/Messages.sh
  kcms/qtquicksettings/kcmqtquicksettings.cpp
  kcms/qtquicksettings/kcmqtquicksettings.h
  kcms/qtquicksettings/kcmqtquicksettingswidget.ui
  kcms/qtquicksettings/qtquicksettings.desktop
  kcms/qtquicksettings/renderer.kcfg
  kcms/qtquicksettings/renderersettings.kcfgc

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart