D8827: experimental support for auto mnemonics

ratijas added inline comments. INLINE COMMENTS > broulik wrote in Button.qml:43 > How does it behave if text contains an `&&` ie. user explicitly wants an > ampersand but not a mnemonic? So, it has landed, and it is still broken with respect to `&&`. I filed a bug report about it:

D8827: experimental support for auto mnemonics

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:cdaa40c64413: experimental support for auto mnemonics (authored by mart). REPOSITORY R858 Qt Quick Controls 2:

D8827: experimental support for auto mnemonics

apol added a comment. Big +1, missed it earlier. Won't upstream QQC2 come up with something in this regard? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8827 To: mart, #plasma Cc: apol, hein, broulik, plasma-devel, ZrenBot,

D8827: experimental support for auto mnemonics

mart updated this revision to Diff 28954. mart added a comment. - kirigami 2.3 needed REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8827?vs=28926=28954 BRANCH arcpatch-D8827 REVISION DETAIL

D8827: experimental support for auto mnemonics

mart updated this revision to Diff 28926. mart added a comment. - Merge branch 'master' into arcpatch-D8827 - better shortcut management for MenuItem REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8827?vs=22409=28926 BRANCH

D8827: experimental support for auto mnemonics

broulik added a comment. A shortcut is registered by the `Shortcut` item by doing QGuiApplicationPrivate::instance()->shortcutMap.addShortcut(this, shortcut.keySequence, context, *ctxMatcher()); `QShortcut` is in widgets and also another QObject. I don't see a way to do that

D8827: experimental support for auto mnemonics

hein added a comment. > yeah, it's many qobjects, but there aren't other ways to do shortcuts without it (the way to directly do shortcuts even in c++ it's completely private api) Not even event filtering or something? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION

D8827: experimental support for auto mnemonics

mart added a comment. In https://phabricator.kde.org/D8827#172520, @hein wrote: > How heavy will be all these Shortcut instances? Is that a lot of QObjects? > > Otherwise it looks pretty good. yeah, it's many qobjects, but there aren't other ways to do shortcuts without it

D8827: experimental support for auto mnemonics

hein added a comment. How heavy will be all these Shortcut instances? Is that a lot of QObjects? Otherwise it looks pretty good. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8827 To: mart, #plasma Cc: hein, broulik, plasma-devel,

D8827: experimental support for auto mnemonics

mart updated this revision to Diff 22409. mart added a comment. - && means we want & and not a mnemonic REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8827?vs=22402=22409 BRANCH mart/mnemonics REVISION DETAIL

D8827: experimental support for auto mnemonics

mart added inline comments. INLINE COMMENTS > mart wrote in Button.qml:43 > eww, even worse, in Qt 5.10 the mnemonics are removed in setText so is > impossible to know what the original text was /o\ which, they noticed it was terrible and reverted in Qt 5.11, but 5.10 is still meh, so the

D8827: experimental support for auto mnemonics

mart added inline comments. INLINE COMMENTS > mart wrote in Button.qml:43 > hm, yeah, will be terrible :/ eww, even worse, in Qt 5.10 the mnemonics are removed in setText so is impossible to know what the original text was /o\ REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION

D8827: experimental support for auto mnemonics

mart added inline comments. INLINE COMMENTS > broulik wrote in Button.qml:43 > How does it behave if text contains an `&&` ie. user explicitly wants an > ampersand but not a mnemonic? hm, yeah, will be terrible :/ REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D8827: experimental support for auto mnemonics

broulik added inline comments. INLINE COMMENTS > ToolButton.qml:36 > > hoverEnabled: true //Qt.styleHints.useHoverEffects TODO: how to make > this work in 5.7? > Btw probably Qt.styleHints.hasOwnProperty("useHoverEffects") ? Qt.styleHints.useHoverEffects : true REPOSITORY R858

D8827: experimental support for auto mnemonics

broulik added inline comments. INLINE COMMENTS > Button.qml:43 > +//in case of explicit & the button manages it by itself > +enabled: controlRoot.text.indexOf("&") == -1 > +sequence: controlRoot.Kirigami.MnemonicData.sequence How does it behave if text contains an `&&`

D8827: experimental support for auto mnemonics

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY use auto mnemonics for common widgets as buttons, checkboxes and tabs A feature similar to KXMLGui apps TEST