D9773: Use 1px padding on titlebuttons
ngraham added a comment. Looks like this fixed everything but the maximize button: https://bugs.kde.org/show_bug.cgi?id=391232 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D9773 To: tomanderson, #breeze, abetts Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9773: Use 1px padding on titlebuttons
This revision was automatically updated to reflect the committed changes. Closed by commit R98:bf6178561150: Use 1px padding on titlebuttons (authored by jackg). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9773?vs=25042&id=28267 REVISION DETAIL https://phabricator.kde.org/D9773 AFFECTED FILES Breeze-dark-gtk/gtk-3.18/gtk.css Breeze-dark-gtk/gtk-3.20/gtk.css Breeze-gtk/gtk-3.18/gtk.css Breeze-gtk/gtk-3.20/gtk.css To: tomanderson, #breeze, abetts Cc: plasma-devel, ZrenBot, ngraham, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9773: Use 1px padding on titlebuttons
abetts added a comment. In https://phabricator.kde.org/D9773#188482, @tomanderson wrote: > Thanks Andres. Could you also merge this CL for me? I don't have write permissions for the repo. Hey Tom, Thanks for the comment. I will leave this to the dev team. My vote was as support for this visual change as I am part of the Visual Design Group. The dev team will also review and push the revision upstream if they determine that it is a sensible change. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D9773 To: tomanderson, #breeze, abetts Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9773: Use 1px padding on titlebuttons
tomanderson added a comment. Thanks Andres. Could you also merge this CL for me? I don't have write permissions for the repo. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D9773 To: tomanderson, #breeze, abetts Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9773: Use 1px padding on titlebuttons
abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D9773 To: tomanderson, #breeze, abetts Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9773: Use 1px padding on titlebuttons
tomanderson added a comment. Here's an image delta: https://github.com/KDE/breeze-gtk/pull/3#issuecomment-355097594 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D9773 To: tomanderson, #breeze Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9773: Use 1px padding on titlebuttons
tomanderson created this revision. tomanderson added a reviewer: Breeze. tomanderson added a project: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. tomanderson requested review of this revision. REVISION SUMMARY This patch fixes titlebutton rendering in Chromium. The headerbar used by Breeze is the same size when a window is maximized, but Chromium uses a smaller headerbar for its tabstrip background when the browser is maximized. When buttons won't fit, Chromium downsizes buttons. This was happening with Breeze titlebuttons since it used 6px of padding on the top and bottom of the buttons, so the buttons appeared taller than they actually were. This patch changes the top and bottom padding to 1px. In native GTK apps, there's no change in appearance. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D9773 AFFECTED FILES Breeze-dark-gtk/gtk-3.18/gtk.css Breeze-dark-gtk/gtk-3.20/gtk.css Breeze-gtk/gtk-3.18/gtk.css Breeze-gtk/gtk-3.20/gtk.css To: tomanderson, #breeze Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
