D9825: [Task Manager] Show badge count also in tooltip

2018-01-15 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9b8029fdfb38: [Task Manager] Show badge count also in 
tooltip (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9825?vs=25174&id=25371#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9825?vs=25174&id=25371

REVISION DETAIL
  https://phabricator.kde.org/D9825

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: broulik, #plasma, #vdg, romangg, hein
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9825: [Task Manager] Show badge count also in tooltip

2018-01-12 Thread Nathaniel Graham 
ngraham accepted this revision as: VDG.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9825

To: broulik, #plasma, #vdg, romangg, hein
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9825: [Task Manager] Show badge count also in tooltip

2018-01-11 Thread Eike Hein 
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9825

To: broulik, #plasma, #vdg, romangg, hein
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9825: [Task Manager] Show badge count also in tooltip

2018-01-11 Thread Nathaniel Graham 
ngraham added a comment.


  Nice, I love it!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9825

To: broulik, #plasma, #vdg, romangg, hein
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9825: [Task Manager] Show badge count also in tooltip

2018-01-11 Thread Kai Uwe Broulik 
broulik requested review of this revision.
broulik added a comment.


  tooltip glitch not caused by this patch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9825

To: broulik, #plasma, #vdg, romangg, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9825: [Task Manager] Show badge count also in tooltip

2018-01-11 Thread Kai Uwe Broulik 
broulik planned changes to this revision.
broulik added a comment.


  Initial size for launcher tooltip is borked, yay QtQuick Layouts

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9825

To: broulik, #plasma, #vdg, romangg, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9825: [Task Manager] Show badge count also in tooltip

2018-01-11 Thread Kai Uwe Broulik 
broulik edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9825

To: broulik, #plasma, #vdg, romangg, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9825: [Task Manager] Show badge count also in tooltip

2018-01-11 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, VDG, romangg, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When you panel is too badge icon cannot be shown, so show it in the tooltip 
as well.

TEST PLAN
  Single window
  F5638828: Screenshot_20180111_175729.png 

  This shows the same problem we have everywhere that the badge is per 
application, not per window, hence I only show it on the first item, where 
there is also the app name
  F5638829: Screenshot_20180111_175829.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9825

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: broulik, #plasma, #vdg, romangg, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart