D9930: Require libinput version 1.9
tcberner added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In https://phabricator.kde.org/D9930#194036, @graesslin wrote:
> In https://phabricator.kde.org/D9930#193993, @tcberner wrote:
>
> > Hi there
> >
> > This breaks the CI on FreeBSD, where we only have libinput 1.6
> >
> > 10:17:48 -- Could NOT find Libinput: Found unsuitable version "1.6.0",
but required is at least "1.9" (found /usr/local/lib/libinput.so)
> > [...]
> > 10:21:50 [ 71%] Building CXX object
CMakeFiles/kwin_wayland.dir/main_wayland.cpp.o
> > 10:21:50 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/tabletmodemanager.cpp:54:25: error: member access into incomplete
type 'LibInput::Device'
> > 10:21:50 if (!event->device()->isTabletModeSwitch()) {
> > 10:21:50 ^
> > 10:21:50 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/input_event.h:29:7: note: forward declaration of
'KWin::LibInput::Device'
> > 10:21:50 class Device;
> > 10:21:50 ^
> > 10:21:51 1 error generated.
> > 10:21:51 gmake[2]: *** [CMakeFiles/kwin_wayland.dir/build.make:63:
CMakeFiles/kwin_wayland.dir/tabletmodemanager.cpp.o] Error 1
> > 10:21:51 gmake[2]: *** Waiting for unfinished jobs
> > 10:21:51 [ 71%] Building CXX object
plugins/platforms/virtual/CMakeFiles/KWinWaylandVirtualBackend.dir/virtual_backend.cpp.o
> > 10:21:51 [ 71%] Linking CXX shared module
../../bin/org.kde.kglobalaccel5.platforms/KF5GlobalAccelPrivateKWin.so
> > 10:21:51 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/plugins/platforms/virtual/egl_gbm_backend.cpp:239:19: warning:
cast from 'uchar *' (aka 'unsigned char *') to 'uint *' (aka 'unsigned int *')
increases required alignment from 1 to 4 [-Wcast-align]
> > 10:21:51 uint *p = (uint*)img.bits();
> > 10:21:51 ^
> > 10:21:51 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/plugins/platforms/virtual/egl_gbm_backend.cpp:249:23: warning:
cast from 'uchar *' (aka 'unsigned char *') to 'uint *' (aka 'unsigned int *')
increases required alignment from 1 to 4 [-Wcast-align]
> > 10:21:51 uint *q = (uint*)img.scanLine(y);
> > 10:21:51 ^~
> > [...]
> >
> >
> > So there seems to be some guarding missing as to what gets compiled
without libinput.
>
>
> sorry about that . I was under the impression that libinput is incompatible
with bsd.
>
> Any chance to get 1.9? If yes I would like to make libinput a hard
dependency as it was broken without anybody noticing for quite some time .
I updated the FreeBSD CI image to have libinput-1.9.4 (based on a WIP update
from FreeBSD's bugzilla).
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9930
To: graesslin, #kwin, #plasma, davidedmundson
Cc: tcberner, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff,
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D9930: Require libinput version 1.9
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9930#193993, @tcberner wrote:
> Hi there
>
> This breaks the CI on FreeBSD, where we only have libinput 1.6
>
> 10:17:48 -- Could NOT find Libinput: Found unsuitable version "1.6.0",
but required is at least "1.9" (found /usr/local/lib/libinput.so)
> [...]
> 10:21:50 [ 71%] Building CXX object
CMakeFiles/kwin_wayland.dir/main_wayland.cpp.o
> 10:21:50 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/tabletmodemanager.cpp:54:25: error: member access into incomplete
type 'LibInput::Device'
> 10:21:50 if (!event->device()->isTabletModeSwitch()) {
> 10:21:50 ^
> 10:21:50 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/input_event.h:29:7: note: forward declaration of
'KWin::LibInput::Device'
> 10:21:50 class Device;
> 10:21:50 ^
> 10:21:51 1 error generated.
> 10:21:51 gmake[2]: *** [CMakeFiles/kwin_wayland.dir/build.make:63:
CMakeFiles/kwin_wayland.dir/tabletmodemanager.cpp.o] Error 1
> 10:21:51 gmake[2]: *** Waiting for unfinished jobs
> 10:21:51 [ 71%] Building CXX object
plugins/platforms/virtual/CMakeFiles/KWinWaylandVirtualBackend.dir/virtual_backend.cpp.o
> 10:21:51 [ 71%] Linking CXX shared module
../../bin/org.kde.kglobalaccel5.platforms/KF5GlobalAccelPrivateKWin.so
> 10:21:51 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/plugins/platforms/virtual/egl_gbm_backend.cpp:239:19: warning:
cast from 'uchar *' (aka 'unsigned char *') to 'uint *' (aka 'unsigned int *')
increases required alignment from 1 to 4 [-Wcast-align]
> 10:21:51 uint *p = (uint*)img.bits();
> 10:21:51 ^
> 10:21:51 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/plugins/platforms/virtual/egl_gbm_backend.cpp:249:23: warning:
cast from 'uchar *' (aka 'unsigned char *') to 'uint *' (aka 'unsigned int *')
increases required alignment from 1 to 4 [-Wcast-align]
> 10:21:51 uint *q = (uint*)img.scanLine(y);
> 10:21:51 ^~
> [...]
>
>
> So there seems to be some guarding missing as to what gets compiled without
libinput.
sorry about that . I was under the impression that libinput is incompatible
with bsd.
Any chance to get 1.9? If yes I would like to make libinput a hard dependency
as it was broken without anybody noticing for quite some time .
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9930
To: graesslin, #kwin, #plasma, davidedmundson
Cc: tcberner, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D9930: Require libinput version 1.9
tcberner added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Hi there
This breaks the CI on FreeBSD, where we only have libinput 1.6
10:17:48 -- Could NOT find Libinput: Found unsuitable version "1.6.0", but
required is at least "1.9" (found /usr/local/lib/libinput.so)
[...]
10:21:50 [ 71%] Building CXX object
CMakeFiles/kwin_wayland.dir/main_wayland.cpp.o
10:21:50 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/tabletmodemanager.cpp:54:25: error: member access into incomplete
type 'LibInput::Device'
10:21:50 if (!event->device()->isTabletModeSwitch()) {
10:21:50 ^
10:21:50 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/input_event.h:29:7: note: forward declaration of
'KWin::LibInput::Device'
10:21:50 class Device;
10:21:50 ^
10:21:51 1 error generated.
10:21:51 gmake[2]: *** [CMakeFiles/kwin_wayland.dir/build.make:63:
CMakeFiles/kwin_wayland.dir/tabletmodemanager.cpp.o] Error 1
10:21:51 gmake[2]: *** Waiting for unfinished jobs
10:21:51 [ 71%] Building CXX object
plugins/platforms/virtual/CMakeFiles/KWinWaylandVirtualBackend.dir/virtual_backend.cpp.o
10:21:51 [ 71%] Linking CXX shared module
../../bin/org.kde.kglobalaccel5.platforms/KF5GlobalAccelPrivateKWin.so
10:21:51 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/plugins/platforms/virtual/egl_gbm_backend.cpp:239:19: warning:
cast from 'uchar *' (aka 'unsigned char *') to 'uint *' (aka 'unsigned int *')
increases required alignment from 1 to 4 [-Wcast-align]
10:21:51 uint *p = (uint*)img.bits();
10:21:51 ^
10:21:51 /usr/home/jenkins/workspace/Plasma kwin kf5-qt5
FreeBSDQt5.9/plugins/platforms/virtual/egl_gbm_backend.cpp:249:23: warning:
cast from 'uchar *' (aka 'unsigned char *') to 'uint *' (aka 'unsigned int *')
increases required alignment from 1 to 4 [-Wcast-align]
10:21:51 uint *q = (uint*)img.scanLine(y);
10:21:51 ^~
[...]
So there seems to be some guarding missing as to what gets compiled without
libinput.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9930
To: graesslin, #kwin, #plasma, davidedmundson
Cc: tcberner, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff,
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D9930: Require libinput version 1.9
This revision was automatically updated to reflect the committed changes. Closed by commit R108:4cc1d7a24546: Require libinput version 1.9 (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9930?vs=25503&id=25708 REVISION DETAIL https://phabricator.kde.org/D9930 AFFECTED FILES CMakeLists.txt autotests/libinput/CMakeLists.txt autotests/libinput/device_test.cpp autotests/libinput/mock_libinput.cpp config-kwin.h.cmake libinput/connection.cpp libinput/device.cpp libinput/events.cpp libinput/events.h To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9930: Require libinput version 1.9
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9930#192197, @davidedmundson wrote: > Edit: please make sure the CI has this before pushing. CI has it. I checked before starting the work on the feature which requires 1.9. REPOSITORY R108 KWin BRANCH require-libinput-1-9 REVISION DETAIL https://phabricator.kde.org/D9930 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D9930: Require libinput version 1.9
davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Edit: please make sure the CI has this before pushing. REPOSITORY R108 KWin BRANCH require-libinput-1-9 REVISION DETAIL https://phabricator.kde.org/D9930 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9930: Require libinput version 1.9
davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH require-libinput-1-9 REVISION DETAIL https://phabricator.kde.org/D9930 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D9930: Require libinput version 1.9
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH require-libinput-1-9 REVISION DETAIL https://phabricator.kde.org/D9930 AFFECTED FILES CMakeLists.txt autotests/libinput/CMakeLists.txt autotests/libinput/device_test.cpp autotests/libinput/mock_libinput.cpp config-kwin.h.cmake libinput/connection.cpp libinput/device.cpp libinput/events.cpp libinput/events.h To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
