Re: Discover requires Qt 5.7?

[Marco Martin]

On Thursday 22 September 2016 15:40:22 Aleix Pol wrote:
> > wait, isn't looking for it at build time? O.o
> > of course it should do that
> > 
> > --
> > Marco Martin
> 
> It is now.

 awesome :)
-- 
Marco Martin

Re: Discover requires Qt 5.7?

[Aleix Pol]

On Thu, Sep 22, 2016 at 2:59 PM, Marco Martin  wrote:
> On Thursday 22 September 2016 14:42:04 Matthias Klumpp wrote:
>> One addition: If Kirigami is missing on the system, Discover will
>> build but simply crash on startup - so, we should make the application
>> handle this case better (= not crash) or simply depend on Kirigami at
>> build-time, so people don't forget to make it available.
>> Especially for distributors this is kind of important, so they get the
>> dependencies set correctly.
>
> wait, isn't looking for it at build time? O.o
> of course it should do that
>
> --
> Marco Martin

It is now.

Aleix

Re: Discover requires Qt 5.7?

[Marco Martin]

On Thursday 22 September 2016 14:42:04 Matthias Klumpp wrote:
> One addition: If Kirigami is missing on the system, Discover will
> build but simply crash on startup - so, we should make the application
> handle this case better (= not crash) or simply depend on Kirigami at
> build-time, so people don't forget to make it available.
> Especially for distributors this is kind of important, so they get the
> dependencies set correctly.

wait, isn't looking for it at build time? O.o
of course it should do that

-- 
Marco Martin

Re: Discover requires Qt 5.7?

[Matthias Klumpp]

2016-09-22 14:36 GMT+02:00 Matthias Klumpp :
> 2016-09-22 13:15 GMT+02:00 Jonathan Riddell :
>> On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote:
>>> On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil  wrote:
>>> > Hi,
>>> >
>>> > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although
>>> > CMakeLists.txt claims Qt 5.2 is required (which seems to be too low 
>>> > anyway).
>>> >
>>> > Can you please either replace qAsConst() with const_cast or bump the Qt
>>> > dependency?
>>> >
>>> > Thanks,
>>> > Dan
>>> >
>>> > [0] https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-5.7.95/
>>> > fedora-24-x86_64/00455948-plasma-discover/build.log.gz
>>>
>>> This and other problems have been fixed lately, when I was pointed
>>> this could be a problem. The next beta will work with Qt 5.6.
>>
>> There's no more betas, only a final release next week, so verification 
>> before then would be good.
>
> I requested that change, tested it and it works ~okay - there are some
> UI / font rendering issues, but all of those problems are apparently
> caused by Qt itself, so nothing we can solve. Also, they don't make
> using Discover impossible or harder, it just doesn't look as nice.
>
> So, for me it's working with Debian's version of Qt 5.6.

One addition: If Kirigami is missing on the system, Discover will
build but simply crash on startup - so, we should make the application
handle this case better (= not crash) or simply depend on Kirigami at
build-time, so people don't forget to make it available.
Especially for distributors this is kind of important, so they get the
dependencies set correctly.

Cheers,
Matthias

-- 
Debian Developer | Freedesktop-Developer
I welcome VSRE emails. See http://vsre.info/

Re: Discover requires Qt 5.7?

[Matthias Klumpp]

2016-09-22 13:15 GMT+02:00 Jonathan Riddell :
> On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote:
>> On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil  wrote:
>> > Hi,
>> >
>> > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although
>> > CMakeLists.txt claims Qt 5.2 is required (which seems to be too low 
>> > anyway).
>> >
>> > Can you please either replace qAsConst() with const_cast or bump the Qt
>> > dependency?
>> >
>> > Thanks,
>> > Dan
>> >
>> > [0] https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-5.7.95/
>> > fedora-24-x86_64/00455948-plasma-discover/build.log.gz
>>
>> This and other problems have been fixed lately, when I was pointed
>> this could be a problem. The next beta will work with Qt 5.6.
>
> There's no more betas, only a final release next week, so verification before 
> then would be good.

I requested that change, tested it and it works ~okay - there are some
UI / font rendering issues, but all of those problems are apparently
caused by Qt itself, so nothing we can solve. Also, they don't make
using Discover impossible or harder, it just doesn't look as nice.

So, for me it's working with Debian's version of Qt 5.6.

Cheers,
Matthias

-- 
Debian Developer | Freedesktop-Developer
I welcome VSRE emails. See http://vsre.info/

Re: Discover requires Qt 5.7?

[Jonathan Riddell]

On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote:
> On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil  wrote:
> > Hi,
> >
> > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although
> > CMakeLists.txt claims Qt 5.2 is required (which seems to be too low anyway).
> >
> > Can you please either replace qAsConst() with const_cast or bump the Qt
> > dependency?
> >
> > Thanks,
> > Dan
> >
> > [0] https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-5.7.95/
> > fedora-24-x86_64/00455948-plasma-discover/build.log.gz
> 
> This and other problems have been fixed lately, when I was pointed
> this could be a problem. The next beta will work with Qt 5.6.

There's no more betas, only a final release next week, so verification before 
then would be good.

Jonathan

Re: Discover requires Qt 5.7?

[Aleix Pol]

On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil  wrote:
> Hi,
>
> Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although
> CMakeLists.txt claims Qt 5.2 is required (which seems to be too low anyway).
>
> Can you please either replace qAsConst() with const_cast or bump the Qt
> dependency?
>
> Thanks,
> Dan
>
> [0] https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-5.7.95/
> fedora-24-x86_64/00455948-plasma-discover/build.log.gz

This and other problems have been fixed lately, when I was pointed
this could be a problem. The next beta will work with Qt 5.6.

Aleix

Re: Discover requires Qt 5.7?

[Marco Martin]

On Thursday 22 September 2016 10:58:42 Harald Sitter wrote:
> Dropping qasconst won't help. Discover wants kirigami master which
> uses qtquickcontrols2 templates which IIRC was only introduced in Qt
> 5.7, so discover needs 5.7 through kirigami I think.

no, kirigami master doesn't use qtquickcontrols2 templates, depends from 5.6 
and is supposed to keep doing so.

-- 
Marco Martin

Re: Discover requires Qt 5.7?

[Harald Sitter]

Dropping qasconst won't help. Discover wants kirigami master which
uses qtquickcontrols2 templates which IIRC was only introduced in Qt
5.7, so discover needs 5.7 through kirigami I think.

On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil  wrote:
> Hi,
>
> Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although
> CMakeLists.txt claims Qt 5.2 is required (which seems to be too low anyway).
>
> Can you please either replace qAsConst() with const_cast or bump the Qt
> dependency?
>
> Thanks,
> Dan
>
> [0] https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-5.7.95/
> fedora-24-x86_64/00455948-plasma-discover/build.log.gz
>
> --
> Daniel Vrátil
> www.dvratil.cz | dvra...@kde.org
> IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)
>
> GPG Key: 0x4D69557AECB13683
> Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

Discover requires Qt 5.7?

[Daniel Vrátil]

Hi,

Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although 
CMakeLists.txt claims Qt 5.2 is required (which seems to be too low anyway).

Can you please either replace qAsConst() with const_cast or bump the Qt 
dependency?

Thanks,
Dan

[0] https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-5.7.95/
fedora-24-x86_64/00455948-plasma-discover/build.log.gz

-- 
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

signature.asc
Description: This is a digitally signed message part.