Re: Require passing unit tests
Scripted and pushed. Lets take discussion about individual repos to the relevant MRs.
Re: Require passing unit tests
>let's go for it at least p-w and plasma-integration and slowly aim for >everywhere plasma-integration is an example where the tests have failed since November **2020**! without anyone following up. Fixed that one now: https://invent.kde.org/plasma/plasma-integration/-/merge_requests/43 Though one still remains
Re: Require passing unit tests
let's go for it at least p-w andplasma-integration and slowly aim for everywhere On Mon, Apr 11, 2022 at 11:10 AM David Edmundson wrote: > > There's a new flag we can set on CI to fail a job if unit tests fail. > https://www.volkerkrause.eu/2022/04/09/kde-ci-required-unit-tests.html > > Catching things as early as possible will unquestionably be a good thing. > > Realistically right now this is going to cause some merge failures as > we know some tests are flakey. It might act as good motivation to fix > them, it might just be annoying. > > https://build.kde.org/job/Plasma/view/Everything%20-%20kf5-qt5/ is a > good enough overview things either yellow or blue with a cloud will > probably be issues. > > Should we: > - apply everywhere? > - apply in a few safe places? -- Marco Martin
Re: Require passing unit tests
On 4/11/22 05:01, Aleix Pol wrote: It could make sense to start with the one projects where we don't have flaky tests. Either way, I think our mid-term plan should be to apply this everywhere. This is pretty much my viewpoint too. Nate
Re: Require passing unit tests
On Mon, Apr 11, 2022 at 11:10 AM David Edmundson wrote: > > There's a new flag we can set on CI to fail a job if unit tests fail. > https://www.volkerkrause.eu/2022/04/09/kde-ci-required-unit-tests.html > > Catching things as early as possible will unquestionably be a good thing. > > Realistically right now this is going to cause some merge failures as > we know some tests are flakey. It might act as good motivation to fix > them, it might just be annoying. > > https://build.kde.org/job/Plasma/view/Everything%20-%20kf5-qt5/ is a > good enough overview things either yellow or blue with a cloud will > probably be issues. > > Should we: > - apply everywhere? > - apply in a few safe places? It could make sense to start with the one projects where we don't have flaky tests. Either way, I think our mid-term plan should be to apply this everywhere. Aleix
