Re: Review Request: use window role to detect the dashboard
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15436 --- This review has been submitted with commit ee14781eefc60a2584636742a6bb843a3a8625d8 by Thomas Lübking to branch KDE/4.9. - Commit Hook On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use window role to detect the dashboard
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15359 --- Ship it! Ship It! - Andreas Demmer On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use window role to detect the dashboard
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15360 --- Ship it! from my side ok, maybe wait a day whether a plasma dev wants to comment :-) - Martin Gräßlin On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use window role to detect the dashboard
On July 4, 2012, 7:57 a.m., Andreas Demmer wrote: Ship It! I missed that windowRole would be a much better distinction than windowClass is when I initially implemented this effect. Your patch definitely makes sense, so ship it! - Andreas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15359 --- On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use window role to detect the dashboard
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15330 --- Ship it! I really would like to have a proper solution by using a window type. But as kdelibs is frozen we probably have to delay that for 5.x. Given that I think this solution is more stable than the previous one. plasma/desktop/shell/dashboardview.cpp http://git.reviewboard.kde.org/r/105382/#comment11941 maybe plasma-dashboard? - Martin Gräßlin On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use window role to detect the dashboard
On July 3, 2012, 8:30 a.m., Martin Gräßlin wrote: plasma/desktop/shell/dashboardview.cpp, line 99 http://git.reviewboard.kde.org/r/105382/diff/1/?file=70604#file70604line99 maybe plasma-dashboard? I thought to stress that this is the kind of dashboard that carries plasmoids, but i do so much not care ;-) - changed. - Thomas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15330 --- On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use window role to detect the dashboard
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15245 --- Nice catch! I do not have a printer that supports reporting ink levels, so I cannot test whether it causes unexpected behavior, but I don’t think so. Daniel should look over this anyway. Thanks for the patch! :) - Kai Uwe Broulik On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use window role to detect the dashboard
On June 28, 2012, 8:21 p.m., Kai Uwe Broulik wrote: Nice catch! I do not have a printer that supports reporting ink levels, so I cannot test whether it causes unexpected behavior, but I don’t think so. Daniel should look over this anyway. Thanks for the patch! :) Sorry, Wrong Review! :D - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15245 --- On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
