Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2016-09-22 Thread Jekyll Wu

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107868/
---

(Updated Sept. 22, 2016, 8:33 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Bugs: 188494
http://bugs.kde.org/show_bug.cgi?id=188494


Repository: kdeplasma-addons


Description
---

What the current konquerorsessions plugin does is eventually calling "konqueror 
--profile xyz", so it is really for the profile feature of konqueror, not the 
session feature of konqueoror.

The patch just contains various moving and renaming opeations to make its code, 
name and behavior being consistent. I actually have made a real 
konquerosessions plugin based upon this unreal plugin. Will post it in another 
review.


Diffs
-

  runners/CMakeLists.txt bb4b491 
  runners/konquerorprofiles/CMakeLists.txt PRE-CREATION 
  runners/konquerorprofiles/Messages.sh PRE-CREATION 
  runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION 
  runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION 
  runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION 
  runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd 
PRE-CREATION 
  runners/konquerorsessions/CMakeLists.txt be2ea9d 
  runners/konquerorsessions/Messages.sh 0720e1e 
  runners/konquerorsessions/konquerorsessions.cpp f2e437a 
  runners/konquerorsessions/konquerorsessions.desktop df81780 
  runners/konquerorsessions/konquerorsessions.h 957f976 

Diff: https://git.reviewboard.kde.org/r/107868/diff/


Testing
---


Thanks,

Jekyll Wu



Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2016-09-22 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107868/#review99448
---



Closing as this review request is more than 2 years old.

If it still applies to current Plasma please reopen this review request. Thanks

- David Edmundson


On Dec. 31, 2012, 7:12 p.m., Jekyll Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/107868/
> ---
> 
> (Updated Dec. 31, 2012, 7:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 188494
> http://bugs.kde.org/show_bug.cgi?id=188494
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> What the current konquerorsessions plugin does is eventually calling 
> "konqueror --profile xyz", so it is really for the profile feature of 
> konqueror, not the session feature of konqueoror.
> 
> The patch just contains various moving and renaming opeations to make its 
> code, name and behavior being consistent. I actually have made a real 
> konquerosessions plugin based upon this unreal plugin. Will post it in 
> another review.
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt bb4b491 
>   runners/konquerorprofiles/CMakeLists.txt PRE-CREATION 
>   runners/konquerorprofiles/Messages.sh PRE-CREATION 
>   runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION 
>   runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION 
>   runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION 
>   
> runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd 
> PRE-CREATION 
>   runners/konquerorsessions/CMakeLists.txt be2ea9d 
>   runners/konquerorsessions/Messages.sh 0720e1e 
>   runners/konquerorsessions/konquerorsessions.cpp f2e437a 
>   runners/konquerorsessions/konquerorsessions.desktop df81780 
>   runners/konquerorsessions/konquerorsessions.h 957f976 
> 
> Diff: https://git.reviewboard.kde.org/r/107868/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>



Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2014-07-29 Thread Vishesh Handa

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107868/#review63408
---


Jekyll, ping?

- Vishesh Handa


On Dec. 31, 2012, 7:12 p.m., Jekyll Wu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/107868/
 ---
 
 (Updated Dec. 31, 2012, 7:12 p.m.)
 
 
 Review request for Plasma.
 
 
 Bugs: 188494
 http://bugs.kde.org/show_bug.cgi?id=188494
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 What the current konquerorsessions plugin does is eventually calling 
 konqueror --profile xyz, so it is really for the profile feature of 
 konqueror, not the session feature of konqueoror.
 
 The patch just contains various moving and renaming opeations to make its 
 code, name and behavior being consistent. I actually have made a real 
 konquerosessions plugin based upon this unreal plugin. Will post it in 
 another review.
 
 
 Diffs
 -
 
   runners/CMakeLists.txt bb4b491 
   runners/konquerorprofiles/CMakeLists.txt PRE-CREATION 
   runners/konquerorprofiles/Messages.sh PRE-CREATION 
   runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION 
   runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION 
   runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION 
   
 runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd 
 PRE-CREATION 
   runners/konquerorsessions/CMakeLists.txt be2ea9d 
   runners/konquerorsessions/Messages.sh 0720e1e 
   runners/konquerorsessions/konquerorsessions.cpp f2e437a 
   runners/konquerorsessions/konquerorsessions.desktop df81780 
   runners/konquerorsessions/konquerorsessions.h 957f976 
 
 Diff: https://git.reviewboard.kde.org/r/107868/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jekyll Wu
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel