Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/#review26828 --- Ship it! Ship It! - Marco Martin On Feb. 7, 2013, 1:22

Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-07 Thread Marco Martin
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable - Marco --- This is an

Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-07 Thread Aleix Pol Gonzalez
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! Marco Martin wrote: ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable Uh ok... Can't we just merge commits? - Aleix

Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-07 Thread Marco Martin
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! Marco Martin wrote: ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable Aleix Pol Gonzalez wrote: Uh ok...

Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-07 Thread Aleix Pol Gonzalez
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! Marco Martin wrote: ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable Aleix Pol Gonzalez wrote: Uh ok...

Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

2013-02-07 Thread Marco Martin
On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: Ship It! Marco Martin wrote: ah, another thing. from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable Aleix Pol Gonzalez wrote: Uh ok...