---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117444/#review99464
---
Closing as this review request is more than 2 years old.
If it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On April 9, 2014, 4:52 a.m., Jeffrey Enns wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117444/
> ---
>
> (Updated April 9, 2014, 4:52 a.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 313734
> http://bugs.kde.org/show_bug.cgi?id=313734
>
>
> Repository: kdeplasma-addons
>
>
> Description
> ---
>
> Set the highlight to visible inside the Keys::onPressed handler.
>
> With this fix, after the highlight is set to invisible due to the user's
> mouse exiting the widget area, it will be made visible again if the user
> interacts with the widget via key press.
>
>
> Diffs
> -
>
> applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml
> bea8bfabcb65dcbee586becd6c4b4fc3dc0d9b16
>
> Diff: https://git.reviewboard.kde.org/r/117444/diff/
>
>
> Testing
> ---
>
> The following test steps were performed and passed:
> 1. Add Konsole Profiles Widget to the panel and give it a keyboard shortcut.
> 2. Invoke the Konsole Profiles widget via keyboard shortcut.
> 3. Attempt to navigate the profile list via arrow keys and make sure that the
> highlight appears.
> 4. Have the mouse enter and then leave the widget's mouse area so that the
> highlight disappears.
> 5. Interact with the widget with the arrow keys and make sure that the
> highlight appears again.
>
>
> Thanks,
>
> Jeffrey Enns
>
>