Re: Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme

2016-09-22 Thread Daniel Vrátil

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119990/
---

(Updated Sept. 22, 2016, 8:31 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: libksysguard


Description
---

Since libksysguard probably aims to be a framework, the libraries should have 
respective names and includes should be installed to KF5_INCLUE_INSTALL_DIR. 
Solves conflicts with KDE 4.


Diffs
-

  ksgrd/CMakeLists.txt 64ad24a 
  lsofui/CMakeLists.txt 2b0c8ac 
  processcore/CMakeLists.txt 31eee10 
  processui/CMakeLists.txt 150e198 
  signalplotter/CMakeLists.txt 67aa8bb 

Diff: https://git.reviewboard.kde.org/r/119990/diff/


Testing
---

Builds, installs, libraries are called libKF5*.so, includes in 
/usr/include/KF5/KSysGuard/


Thanks,

Daniel Vrátil



Re: Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme

2016-09-22 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119990/#review99441
---



Closing as this review request is more than 2 years old.

If it still applies to current Plasma. Please reopen.

- David Edmundson


On Aug. 29, 2014, 1 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119990/
> ---
> 
> (Updated Aug. 29, 2014, 1 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> ---
> 
> Since libksysguard probably aims to be a framework, the libraries should have 
> respective names and includes should be installed to KF5_INCLUE_INSTALL_DIR. 
> Solves conflicts with KDE 4.
> 
> 
> Diffs
> -
> 
>   ksgrd/CMakeLists.txt 64ad24a 
>   lsofui/CMakeLists.txt 2b0c8ac 
>   processcore/CMakeLists.txt 31eee10 
>   processui/CMakeLists.txt 150e198 
>   signalplotter/CMakeLists.txt 67aa8bb 
> 
> Diff: https://git.reviewboard.kde.org/r/119990/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, libraries are called libKF5*.so, includes in 
> /usr/include/KF5/KSysGuard/
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>