Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 24, 2014, 11:43 a.m.) Review request for Plasma.

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67357 --- Ship it! Please put the city as the 2nd column, otherwise a

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67360 --- Doesn't always keeping Local enabled create an awkward

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Lukáš Tinkl
On Zář. 24, 2014, 4:33 odp., Lukáš Tinkl wrote: Please put the city as the 2nd column, otherwise a ship it from me definitely, great work! For the record, the tooltip can be wrong for certain TZs (yesterday/tomorrow with the correct day name should be shown instead) - Lukáš

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 24, 2014, 10:40 p.m.) Review request for Plasma.

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Kai Uwe Broulik
On Sept. 24, 2014, 2:42 nachm., Eike Hein wrote: Doesn't always keeping Local enabled create an awkward situation if you want to default a clock to a non-Local timezone but want wheel scrolling disabled for accident-safety a la sebas? Then you need to: 1. Enable additional

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Kai Uwe Broulik
On Sept. 24, 2014, 2:42 nachm., Eike Hein wrote: Doesn't always keeping Local enabled create an awkward situation if you want to default a clock to a non-Local timezone but want wheel scrolling disabled for accident-safety a la sebas? Then you need to: 1. Enable additional

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67393 --- Ship it! Summing up from IRC: a) The new message widget

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 24, 2014, 9:02 p.m.) Status -- This change has been

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Martin Klapetek
On Sept. 23, 2014, 12:22 a.m., Eike Hein wrote: I can no longer reproduce my problem from earlier, but note it's possible to deselect all timezones in the config and then you get: plasmashell(28432)/default unknown:

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Martin Klapetek
On Sept. 23, 2014, 12:24 a.m., Eike Hein wrote: Place names with multiple names use _ as word separator, and don't get scaled down enough nor elided to fit a narrow vertical panel: ![Long place name](http://wstaw.org/m/2014/09/23/crop.png) Right, there's that translations issue. So

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 23, 2014, 10:55 a.m.) Review request for Plasma.

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Sebastian Kügler
On Sept. 22, 2014, 10:24 p.m., Eike Hein wrote: Place names with multiple names use _ as word separator, and don't get scaled down enough nor elided to fit a narrow vertical panel: ![Long place name](http://wstaw.org/m/2014/09/23/crop.png) Martin Klapetek wrote: Right, there's

Re: Review Request 120314: Add timezones support into clock applet

2014-09-23 Thread Martin Klapetek
On Sept. 23, 2014, 12:24 a.m., Eike Hein wrote: Place names with multiple names use _ as word separator, and don't get scaled down enough nor elided to fit a narrow vertical panel: ![Long place name](http://wstaw.org/m/2014/09/23/crop.png) Martin Klapetek wrote: Right, there's

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 12:56 p.m.) Review request for Plasma.

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 1:05 p.m.) Review request for Plasma. Changes

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67181 --- Thanks for your work! :)

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 2:55 p.m.) Review request for Plasma. Changes

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 4:33 p.m.) Review request for Plasma. Changes

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67205 --- The following steps lead to unexpected behavior for me: a)

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67225 --- I think scaling could use a little more love:

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein
On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: I think scaling could use a little more love: ![http://wstaw.org/m/2014/09/22/scaling.png](Text scaling) Specifically, notice how the time part isn't of uniform size. I guess it gets scaled to fit in with the city text size, which is

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek
On Sept. 22, 2014, 9:03 p.m., Eike Hein wrote: I think scaling could use a little more love: ![http://wstaw.org/m/2014/09/22/scaling.png](Text scaling) Specifically, notice how the time part isn't of uniform size. I guess it gets scaled to fit in with the city text size, which is

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein
On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: I think scaling could use a little more love: ![http://wstaw.org/m/2014/09/22/scaling.png](Text scaling) Specifically, notice how the time part isn't of uniform size. I guess it gets scaled to fit in with the city text size, which is

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 11:59 p.m.) Review request for Plasma.

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67238 --- Patch doesn't apply cleanly to master: The next patch would

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein
On Sept. 22, 2014, 10:18 p.m., Eike Hein wrote: Patch doesn't apply cleanly to master: The next patch would delete the file a/applets/digital-clock/plugin/processrunnerplugin.h, which does not exist! Assume -R? [n] Uh never mind - fat-fingered the patch level. It's late ... -

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67240 --- I can no longer reproduce my problem from earlier, but note

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67241 --- Place names with multiple names use _ as word separator, and

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Eike Hein
On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: I think scaling could use a little more love: ![http://wstaw.org/m/2014/09/22/scaling.png](Text scaling) Specifically, notice how the time part isn't of uniform size. I guess it gets scaled to fit in with the city text size, which is