Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/ --- (Updated Nov. 18, 2015, 10:03 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit daa54f5f9ec969edca3943fd7efe662c6e25bb38 by David Rosca to branch master. Bugs: 346336 https://bugs.kde.org/show_bug.cgi?id=346336 Repository: plasma-desktop Description --- xcb-xinput is not available on some distributions (eg. Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). This patch adds udev device discovery to reapply settings when adding new keyboard / mouse. Diffs - CMakeLists.txt 193238a cmake/modules/FindUDev.cmake PRE-CREATION kcms/keyboard/CMakeLists.txt 99f4bb3 kcms/keyboard/config-keyboard.h.cmake PRE-CREATION kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5 kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9 kcms/keyboard/kcm_keyboard_widget.h 5994ea4 kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 kcms/keyboard/udev_helper.h PRE-CREATION kcms/keyboard/udev_helper.cpp PRE-CREATION kcms/keyboard/xinput_helper.h af70365 kcms/keyboard/xinput_helper.cpp 0ad7e9c kcms/keyboard/xkb_rules.h ecebd6d Diff: https://git.reviewboard.kde.org/r/125465/diff/ Testing --- Plugging in keyboard is now correctly recognized. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/#review88464 --- If there are no objections, I will push this before beta freeze. - David Rosca On Oct. 1, 2015, 8:05 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125465/ > --- > > (Updated Oct. 1, 2015, 8:05 a.m.) > > > Review request for Plasma. > > > Bugs: 346336 > https://bugs.kde.org/show_bug.cgi?id=346336 > > > Repository: plasma-desktop > > > Description > --- > > xcb-xinput is not available on some distributions (eg. Debian > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). > This patch adds udev device discovery to reapply settings when adding new > keyboard / mouse. > > > Diffs > - > > CMakeLists.txt 193238a > cmake/modules/FindUDev.cmake PRE-CREATION > kcms/keyboard/CMakeLists.txt 99f4bb3 > kcms/keyboard/config-keyboard.h.cmake PRE-CREATION > kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5 > kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9 > kcms/keyboard/kcm_keyboard_widget.h 5994ea4 > kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 > kcms/keyboard/udev_helper.h PRE-CREATION > kcms/keyboard/udev_helper.cpp PRE-CREATION > kcms/keyboard/xinput_helper.h af70365 > kcms/keyboard/xinput_helper.cpp 0ad7e9c > kcms/keyboard/xkb_rules.h ecebd6d > > Diff: https://git.reviewboard.kde.org/r/125465/diff/ > > > Testing > --- > > Plugging in keyboard is now correctly recognized. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available
> On Oct. 1, 2015, 6:01 a.m., Martin Gräßlin wrote: > > Did you check KWin's udev helper classes? Instead of re-inventing the wheel > > it might be better to share the code in case it would be useful. It's in > > kwin.git/udev.h and udev.cpp > > David Rosca wrote: > I did now, it doesn't seem to support device added/removed notifications. > > David Rosca wrote: > Well, it does export UdevMonitor. Ok, I will rewrite it to use kwin's > udev classes. But kwin does not install the header and also has udev only as optional dependency. So I'm not sure that would really help, instead I think it would be better if this functionality was offered by solid (which already internally use udevqt). In any case, I'd like to get it into 5.5 as it fixes quite annoying bug (losing keyboard and mouse settings), so maybe we can fix this later? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/#review86182 --- On Oct. 1, 2015, 8:05 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125465/ > --- > > (Updated Oct. 1, 2015, 8:05 a.m.) > > > Review request for Plasma. > > > Bugs: 346336 > https://bugs.kde.org/show_bug.cgi?id=346336 > > > Repository: plasma-desktop > > > Description > --- > > xcb-xinput is not available on some distributions (eg. Debian > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). > This patch adds udev device discovery to reapply settings when adding new > keyboard / mouse. > > > Diffs > - > > CMakeLists.txt 193238a > cmake/modules/FindUDev.cmake PRE-CREATION > kcms/keyboard/CMakeLists.txt 99f4bb3 > kcms/keyboard/config-keyboard.h.cmake PRE-CREATION > kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5 > kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9 > kcms/keyboard/kcm_keyboard_widget.h 5994ea4 > kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 > kcms/keyboard/udev_helper.h PRE-CREATION > kcms/keyboard/udev_helper.cpp PRE-CREATION > kcms/keyboard/xinput_helper.h af70365 > kcms/keyboard/xinput_helper.cpp 0ad7e9c > kcms/keyboard/xkb_rules.h ecebd6d > > Diff: https://git.reviewboard.kde.org/r/125465/diff/ > > > Testing > --- > > Plugging in keyboard is now correctly recognized. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available
> On Oct. 1, 2015, 8:01 a.m., Martin Gräßlin wrote: > > Did you check KWin's udev helper classes? Instead of re-inventing the wheel > > it might be better to share the code in case it would be useful. It's in > > kwin.git/udev.h and udev.cpp > > David Rosca wrote: > I did now, it doesn't seem to support device added/removed notifications. > > David Rosca wrote: > Well, it does export UdevMonitor. Ok, I will rewrite it to use kwin's > udev classes. > > David Rosca wrote: > But kwin does not install the header and also has udev only as optional > dependency. So I'm not sure that would really help, instead I think it would > be better if this functionality was offered by solid (which already > internally use udevqt). > > In any case, I'd like to get it into 5.5 as it fixes quite annoying bug > (losing keyboard and mouse settings), so maybe we can fix this later? > so maybe we can fix this later? all right. And I'm happy to migrate my kwin code to use udevqt if it can serve us. Btw. it's only optional in KWin to enable building on BSDs. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/#review86182 --- On Oct. 1, 2015, 10:05 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125465/ > --- > > (Updated Oct. 1, 2015, 10:05 a.m.) > > > Review request for Plasma. > > > Bugs: 346336 > https://bugs.kde.org/show_bug.cgi?id=346336 > > > Repository: plasma-desktop > > > Description > --- > > xcb-xinput is not available on some distributions (eg. Debian > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). > This patch adds udev device discovery to reapply settings when adding new > keyboard / mouse. > > > Diffs > - > > CMakeLists.txt 193238a > cmake/modules/FindUDev.cmake PRE-CREATION > kcms/keyboard/CMakeLists.txt 99f4bb3 > kcms/keyboard/config-keyboard.h.cmake PRE-CREATION > kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5 > kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9 > kcms/keyboard/kcm_keyboard_widget.h 5994ea4 > kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 > kcms/keyboard/udev_helper.h PRE-CREATION > kcms/keyboard/udev_helper.cpp PRE-CREATION > kcms/keyboard/xinput_helper.h af70365 > kcms/keyboard/xinput_helper.cpp 0ad7e9c > kcms/keyboard/xkb_rules.h ecebd6d > > Diff: https://git.reviewboard.kde.org/r/125465/diff/ > > > Testing > --- > > Plugging in keyboard is now correctly recognized. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available
> On Oct. 1, 2015, 6:01 a.m., Martin Gräßlin wrote: > > Did you check KWin's udev helper classes? Instead of re-inventing the wheel > > it might be better to share the code in case it would be useful. It's in > > kwin.git/udev.h and udev.cpp > > David Rosca wrote: > I did now, it doesn't seem to support device added/removed notifications. Well, it does export UdevMonitor. Ok, I will rewrite it to use kwin's udev classes. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/#review86182 --- On Oct. 1, 2015, 8:05 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125465/ > --- > > (Updated Oct. 1, 2015, 8:05 a.m.) > > > Review request for Plasma. > > > Bugs: 346336 > https://bugs.kde.org/show_bug.cgi?id=346336 > > > Repository: plasma-desktop > > > Description > --- > > xcb-xinput is not available on some distributions (eg. Debian > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). > This patch adds udev device discovery to reapply settings when adding new > keyboard / mouse. > > > Diffs > - > > CMakeLists.txt 193238a > cmake/modules/FindUDev.cmake PRE-CREATION > kcms/keyboard/CMakeLists.txt 99f4bb3 > kcms/keyboard/config-keyboard.h.cmake PRE-CREATION > kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5 > kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9 > kcms/keyboard/kcm_keyboard_widget.h 5994ea4 > kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 > kcms/keyboard/udev_helper.h PRE-CREATION > kcms/keyboard/udev_helper.cpp PRE-CREATION > kcms/keyboard/xinput_helper.h af70365 > kcms/keyboard/xinput_helper.cpp 0ad7e9c > kcms/keyboard/xkb_rules.h ecebd6d > > Diff: https://git.reviewboard.kde.org/r/125465/diff/ > > > Testing > --- > > Plugging in keyboard is now correctly recognized. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/ --- (Updated Oct. 1, 2015, 8:05 a.m.) Review request for Plasma. Changes --- Use configure file for defines + cleanup - not need to find \_XiGetDevicePresenceNotifyEvent because it is not used - we need both XCB and X11 XInput, so merge them to single define Bugs: 346336 https://bugs.kde.org/show_bug.cgi?id=346336 Repository: plasma-desktop Description --- xcb-xinput is not available on some distributions (eg. Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). This patch adds udev device discovery to reapply settings when adding new keyboard / mouse. Diffs (updated) - CMakeLists.txt 193238a cmake/modules/FindUDev.cmake PRE-CREATION kcms/keyboard/CMakeLists.txt 99f4bb3 kcms/keyboard/config-keyboard.h.cmake PRE-CREATION kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5 kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9 kcms/keyboard/kcm_keyboard_widget.h 5994ea4 kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 kcms/keyboard/udev_helper.h PRE-CREATION kcms/keyboard/udev_helper.cpp PRE-CREATION kcms/keyboard/xinput_helper.h af70365 kcms/keyboard/xinput_helper.cpp 0ad7e9c kcms/keyboard/xkb_rules.h ecebd6d Diff: https://git.reviewboard.kde.org/r/125465/diff/ Testing --- Plugging in keyboard is now correctly recognized. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available
> On Oct. 1, 2015, 6:01 a.m., Martin Gräßlin wrote: > > Did you check KWin's udev helper classes? Instead of re-inventing the wheel > > it might be better to share the code in case it would be useful. It's in > > kwin.git/udev.h and udev.cpp I did now, it doesn't seem to support device added/removed notifications. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/#review86182 --- On Oct. 1, 2015, 8:05 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125465/ > --- > > (Updated Oct. 1, 2015, 8:05 a.m.) > > > Review request for Plasma. > > > Bugs: 346336 > https://bugs.kde.org/show_bug.cgi?id=346336 > > > Repository: plasma-desktop > > > Description > --- > > xcb-xinput is not available on some distributions (eg. Debian > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227). > This patch adds udev device discovery to reapply settings when adding new > keyboard / mouse. > > > Diffs > - > > CMakeLists.txt 193238a > cmake/modules/FindUDev.cmake PRE-CREATION > kcms/keyboard/CMakeLists.txt 99f4bb3 > kcms/keyboard/config-keyboard.h.cmake PRE-CREATION > kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5 > kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9 > kcms/keyboard/kcm_keyboard_widget.h 5994ea4 > kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 > kcms/keyboard/udev_helper.h PRE-CREATION > kcms/keyboard/udev_helper.cpp PRE-CREATION > kcms/keyboard/xinput_helper.h af70365 > kcms/keyboard/xinput_helper.cpp 0ad7e9c > kcms/keyboard/xkb_rules.h ecebd6d > > Diff: https://git.reviewboard.kde.org/r/125465/diff/ > > > Testing > --- > > Plugging in keyboard is now correctly recognized. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
