Re: Review Request 128973: Update icon lcm docbook

2016-09-22 Thread Burkhard Lück

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/
---

(Updated Sept. 22, 2016, 1:58 nachm.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

kde -> plasma
konqueror -> dolphin
remove kdeartwork
remove obsolete para already commented since 4.5
update old screenshots


Diffs
-

  doc/kcontrol/icons/delete-theme.png 8421b7e 
  doc/kcontrol/icons/effects.png b992dff 
  doc/kcontrol/icons/index.docbook 27a6c9e 
  doc/kcontrol/icons/size.png 599c162 

Diff: https://git.reviewboard.kde.org/r/128973/diff/


Testing
---

passes checkXML5


File Attachments


size.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
effects.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
delete-theme.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png


Thanks,

Burkhard Lück



Re: Review Request 128973: Update icon lcm docbook

2016-09-21 Thread Marco Martin


> On Sept. 21, 2016, 2:58 p.m., Marco Martin wrote:
> > doc/kcontrol/icons/index.docbook, line 33
> > 
> >
> > uppercase Plasma, Dolphin etc?
> 
> Burkhard Lück wrote:
> frameworks/kdoctools
> 
> general.entities:400:Plasma">
> 
> general.entities:136: "Dolphin">
> 
> these entities expang in the html to uppercase

ah, ok, thanks!


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/#review99368
---


On Sept. 21, 2016, 12:32 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128973/
> ---
> 
> (Updated Sept. 21, 2016, 12:32 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> kde -> plasma
> konqueror -> dolphin
> remove kdeartwork
> remove obsolete para already commented since 4.5
> update old screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/icons/delete-theme.png 8421b7e 
>   doc/kcontrol/icons/effects.png b992dff 
>   doc/kcontrol/icons/index.docbook 27a6c9e 
>   doc/kcontrol/icons/size.png 599c162 
> 
> Diff: https://git.reviewboard.kde.org/r/128973/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> size.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
> effects.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
> delete-theme.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>



Re: Review Request 128973: Update icon lcm docbook

2016-09-21 Thread Burkhard Lück


> On Sept. 21, 2016, 2:58 nachm., Marco Martin wrote:
> > doc/kcontrol/icons/index.docbook, line 33
> > 
> >
> > uppercase Plasma, Dolphin etc?

frameworks/kdoctools

general.entities:400:Plasma">

general.entities:136:Dolphin">

these entities expang in the html to uppercase


> On Sept. 21, 2016, 2:58 nachm., Marco Martin wrote:
> > doc/kcontrol/icons/index.docbook, line 65
> > 
> >
> > uppercase (and subsequent ones too)

see obove


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/#review99368
---


On Sept. 21, 2016, 12:32 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128973/
> ---
> 
> (Updated Sept. 21, 2016, 12:32 nachm.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> kde -> plasma
> konqueror -> dolphin
> remove kdeartwork
> remove obsolete para already commented since 4.5
> update old screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/icons/delete-theme.png 8421b7e 
>   doc/kcontrol/icons/effects.png b992dff 
>   doc/kcontrol/icons/index.docbook 27a6c9e 
>   doc/kcontrol/icons/size.png 599c162 
> 
> Diff: https://git.reviewboard.kde.org/r/128973/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> size.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
> effects.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
> delete-theme.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>



Re: Review Request 128973: Update icon lcm docbook

2016-09-21 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/#review99368
---


Fix it, then Ship it!





doc/kcontrol/icons/index.docbook (line 33)


uppercase Plasma, Dolphin etc?



doc/kcontrol/icons/index.docbook (line 65)


uppercase (and subsequent ones too)


- Marco Martin


On Sept. 21, 2016, 12:32 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128973/
> ---
> 
> (Updated Sept. 21, 2016, 12:32 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> kde -> plasma
> konqueror -> dolphin
> remove kdeartwork
> remove obsolete para already commented since 4.5
> update old screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/icons/delete-theme.png 8421b7e 
>   doc/kcontrol/icons/effects.png b992dff 
>   doc/kcontrol/icons/index.docbook 27a6c9e 
>   doc/kcontrol/icons/size.png 599c162 
> 
> Diff: https://git.reviewboard.kde.org/r/128973/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> size.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
> effects.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
> delete-theme.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>