Re: Review Request 127356: [Comic] Improvements

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/
---

(Updated March 15, 2016, 5:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.


Changes
---

Submitted with commit a79c2be9b4db0755ad6ff6b26a513d71a94ef790 by Anthony 
Fieroni to branch Plasma/5.6.


Repository: kdeplasma-addons


Description
---

1. Correct highlighted tabs visablity
2. Scale content on update comic
3. Open/close fullview widget
4. Added icon
5. Resize content


Diffs
-

  applets/comic/comic.h 302f7b8 
  applets/comic/comic.cpp 97ec6a1 
  applets/comic/package/contents/ui/ComicCentralView.qml 59989b2 
  applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
  applets/comic/package/contents/ui/main.qml 4cf1cae 

Diff: https://git.reviewboard.kde.org/r/127356/diff/


Testing
---

Resize cannot get to work as i want :)
Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
60% of current image, i don't understaind how this must be written to start 
working :P


File Attachments


Screenshot_20160312_214006.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127356: [Comic] Improvements

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/#review93537
---


Ship it!




Ship It!

- Marco Martin


On March 15, 2016, 6:23 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127356/
> ---
> 
> (Updated March 15, 2016, 6:23 a.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> 1. Correct highlighted tabs visablity
> 2. Scale content on update comic
> 3. Open/close fullview widget
> 4. Added icon
> 5. Resize content
> 
> 
> Diffs
> -
> 
>   applets/comic/comic.h 302f7b8 
>   applets/comic/comic.cpp 97ec6a1 
>   applets/comic/package/contents/ui/ComicCentralView.qml 59989b2 
>   applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
>   applets/comic/package/contents/ui/main.qml 4cf1cae 
> 
> Diff: https://git.reviewboard.kde.org/r/127356/diff/
> 
> 
> Testing
> ---
> 
> Resize cannot get to work as i want :)
> Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
> Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
> 60% of current image, i don't understaind how this must be written to start 
> working :P
> 
> 
> File Attachments
> 
> 
> Screenshot_20160312_214006.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127356: [Comic] Improvements

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/
---

(Updated Март 15, 2016, 8:23 преди обяд)


Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.


Repository: kdeplasma-addons


Description
---

1. Correct highlighted tabs visablity
2. Scale content on update comic
3. Open/close fullview widget
4. Added icon
5. Resize content


Diffs (updated)
-

  applets/comic/comic.h 302f7b8 
  applets/comic/comic.cpp 97ec6a1 
  applets/comic/package/contents/ui/ComicCentralView.qml 59989b2 
  applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
  applets/comic/package/contents/ui/main.qml 4cf1cae 

Diff: https://git.reviewboard.kde.org/r/127356/diff/


Testing
---

Resize cannot get to work as i want :)
Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
60% of current image, i don't understaind how this must be written to start 
working :P


File Attachments


Screenshot_20160312_214006.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127356: [Comic] Improvements

[Marco Martin]

> On March 14, 2016, 8:29 p.m., Marco Martin wrote:
> > applets/comic/package/contents/ui/main.qml, line 31
> > 
> >
> > you don't know how big can be the native size of the image, can be 
> > either way too small to be usable or too big.
> 
> Anthony Fieroni wrote:
> What is your advice? I think the size must be resonable to be seen.

perhaps as width Math.max(units.gridUnit*25, Math.min( 
centerLayout.comicData.image.nativeWidth * 0.6, units.gridUnit * 5))

and the height the same ratio to that as the native size ratio


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/#review93515
---


On March 14, 2016, 8 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127356/
> ---
> 
> (Updated March 14, 2016, 8 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> 1. Correct highlighted tabs visablity
> 2. Scale content on update comic
> 3. Open/close fullview widget
> 4. Added icon
> 5. Resize content
> 
> 
> Diffs
> -
> 
>   applets/comic/comic.h 302f7b8 
>   applets/comic/comic.cpp 97ec6a1 
>   applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
>   applets/comic/package/contents/ui/main.qml 4cf1cae 
> 
> Diff: https://git.reviewboard.kde.org/r/127356/diff/
> 
> 
> Testing
> ---
> 
> Resize cannot get to work as i want :)
> Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
> Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
> 60% of current image, i don't understaind how this must be written to start 
> working :P
> 
> 
> File Attachments
> 
> 
> Screenshot_20160312_214006.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127356: [Comic] Improvements

[Anthony Fieroni]

> On Март 14, 2016, 10:29 след обяд, Marco Martin wrote:
> > applets/comic/package/contents/ui/main.qml, line 31
> > 
> >
> > you don't know how big can be the native size of the image, can be 
> > either way too small to be usable or too big.

What is your advice? I think the size must be resonable to be seen.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/#review93515
---


On Март 14, 2016, 10 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127356/
> ---
> 
> (Updated Март 14, 2016, 10 след обяд)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> 1. Correct highlighted tabs visablity
> 2. Scale content on update comic
> 3. Open/close fullview widget
> 4. Added icon
> 5. Resize content
> 
> 
> Diffs
> -
> 
>   applets/comic/comic.h 302f7b8 
>   applets/comic/comic.cpp 97ec6a1 
>   applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
>   applets/comic/package/contents/ui/main.qml 4cf1cae 
> 
> Diff: https://git.reviewboard.kde.org/r/127356/diff/
> 
> 
> Testing
> ---
> 
> Resize cannot get to work as i want :)
> Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
> Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
> 60% of current image, i don't understaind how this must be written to start 
> working :P
> 
> 
> File Attachments
> 
> 
> Screenshot_20160312_214006.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127356: [Comic] Improvements

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/#review93515
---


Fix it, then Ship it!




good improvement, i still think the switch should be done on a "fixed" size 
rather than the native size of the image, since you don't have an assurance 
wether will be a size that makes sense (perhaps this value could be used if 
bound betweed two fixed gridunit based bounds)


applets/comic/package/contents/ui/FullViewWidget.qml (line 36)


a function called open() shouldn't close.
would be better adding another function called toggleVisibility()



applets/comic/package/contents/ui/FullViewWidget.qml (line 39)


tabs?



applets/comic/package/contents/ui/main.qml (line 31)


you don't know how big can be the native size of the image, can be either 
way too small to be usable or too big.


- Marco Martin


On March 14, 2016, 8 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127356/
> ---
> 
> (Updated March 14, 2016, 8 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> 1. Correct highlighted tabs visablity
> 2. Scale content on update comic
> 3. Open/close fullview widget
> 4. Added icon
> 5. Resize content
> 
> 
> Diffs
> -
> 
>   applets/comic/comic.h 302f7b8 
>   applets/comic/comic.cpp 97ec6a1 
>   applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
>   applets/comic/package/contents/ui/main.qml 4cf1cae 
> 
> Diff: https://git.reviewboard.kde.org/r/127356/diff/
> 
> 
> Testing
> ---
> 
> Resize cannot get to work as i want :)
> Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
> Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
> 60% of current image, i don't understaind how this must be written to start 
> working :P
> 
> 
> File Attachments
> 
> 
> Screenshot_20160312_214006.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127356: [Comic] Improvements

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/
---

(Updated Март 14, 2016, 10 след обяд)


Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.


Changes
---

Update comic to last strip when it is available
Stop busy indicator in any case, to stop infinate loop
Date changes timer started
Fix empty widget after login


Repository: kdeplasma-addons


Description
---

1. Correct highlighted tabs visablity
2. Scale content on update comic
3. Open/close fullview widget
4. Added icon
5. Resize content


Diffs (updated)
-

  applets/comic/comic.h 302f7b8 
  applets/comic/comic.cpp 97ec6a1 
  applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
  applets/comic/package/contents/ui/main.qml 4cf1cae 

Diff: https://git.reviewboard.kde.org/r/127356/diff/


Testing
---

Resize cannot get to work as i want :)
Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
60% of current image, i don't understaind how this must be written to start 
working :P


File Attachments


Screenshot_20160312_214006.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127356: [Comic] Improvements

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/
---

Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.


Repository: kdeplasma-addons


Description
---

1. Correct highlighted tabs visablity
2. Scale content on update comic
3. Open/close fullview widget
4. Added icon
5. Resize content


Diffs
-

  applets/comic/comic.h 302f7b8 
  applets/comic/comic.cpp 97ec6a1 
  applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
  applets/comic/package/contents/ui/main.qml 4cf1cae 

Diff: https://git.reviewboard.kde.org/r/127356/diff/


Testing
---

Resize cannot get to work as i want :)
Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
60% of current image, i don't understaind how this must be written to start 
working :P


File Attachments


Screenshot_20160312_214006.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel