Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

2016-09-26 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128999/
---

(Updated Sept. 26, 2016, 3:56 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 1369bca36f6ced7d7c64899d1664469d32699f96 by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

^^


Diffs
-

  src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 
  src/declarativeimports/plasmacomponents/qmenu.cpp b7037da 

Diff: https://git.reviewboard.kde.org/r/128999/diff/


Testing
---


Thanks,

David Rosca

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

2016-09-26 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128999/#review99540
---


Ship it!




Ship It!

- Kai Uwe Broulik


On Sept. 23, 2016, 11:20 vorm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128999/
> ---
> 
> (Updated Sept. 23, 2016, 11:20 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 
>   src/declarativeimports/plasmacomponents/qmenu.cpp b7037da 
> 
> Diff: https://git.reviewboard.kde.org/r/128999/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

2016-09-23 Thread David Rosca 


> On Sept. 22, 2016, 12:31 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/plasmacomponents/qmenu.cpp, line 231
> > 
> >
> > if (!item) return;

Should be done also in other places.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128999/#review99412
---


On Sept. 23, 2016, 11:20 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128999/
> ---
> 
> (Updated Sept. 23, 2016, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 
>   src/declarativeimports/plasmacomponents/qmenu.cpp b7037da 
> 
> Diff: https://git.reviewboard.kde.org/r/128999/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

2016-09-23 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128999/
---

(Updated Sept. 23, 2016, 11:20 a.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

^^


Diffs (updated)
-

  src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 
  src/declarativeimports/plasmacomponents/qmenu.cpp b7037da 

Diff: https://git.reviewboard.kde.org/r/128999/diff/


Testing
---


Thanks,

David Rosca

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

2016-09-22 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128999/#review99412
---




src/declarativeimports/plasmacomponents/qmenu.cpp (line 231)


if (!item) return;


- Kai Uwe Broulik


On Sept. 22, 2016, 10:55 vorm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128999/
> ---
> 
> (Updated Sept. 22, 2016, 10:55 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 
>   src/declarativeimports/plasmacomponents/qmenu.cpp b7037da 
> 
> Diff: https://git.reviewboard.kde.org/r/128999/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

2016-09-22 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128999/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

^^


Diffs
-

  src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 
  src/declarativeimports/plasmacomponents/qmenu.cpp b7037da 

Diff: https://git.reviewboard.kde.org/r/128999/diff/


Testing
---


Thanks,

David Rosca