Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

2017-06-19 Thread Eric Koegel

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130163/
---

(Updated June 20, 2017, 5:58 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: kwin


Description
---

ConsoleKit2 as of version 1.1.1 implements the Session Controller dbus calls 
required by Kwin to run under Wayland. This patch first looks for the login1 
service before attempting the ConsoleKit service.


Diffs
-

  logind.h 8bb0206 
  logind.cpp fee0f2f 

Diff: https://git.reviewboard.kde.org/r/130163/diff/


Testing
---

On a system running ConsoleKit2, logging into a text console and running:
```
export $(dbus-launch); export QT_QPA_PLATFORM=wayland; startplasmacompositor
```
Most of this patch is just shuffling code around to support both logind and CK2.


Thanks,

Eric Koegel



Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

2017-06-19 Thread Martin Flöser

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130163/#review103347
---



We are currently in the process of fading out reviewboard. Could you please 
reopen the request on phabricator.kde.org in order to reach all developers. Not 
everyone is looking at reviewboard any more.

Thank you!

- Martin Flöser


On June 19, 2017, 9:42 a.m., Eric Koegel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130163/
> ---
> 
> (Updated June 19, 2017, 9:42 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> ConsoleKit2 as of version 1.1.1 implements the Session Controller dbus calls 
> required by Kwin to run under Wayland. This patch first looks for the login1 
> service before attempting the ConsoleKit service.
> 
> 
> Diffs
> -
> 
>   logind.h 8bb0206 
>   logind.cpp fee0f2f 
> 
> Diff: https://git.reviewboard.kde.org/r/130163/diff/
> 
> 
> Testing
> ---
> 
> On a system running ConsoleKit2, logging into a text console and running:
> ```
> export $(dbus-launch); export QT_QPA_PLATFORM=wayland; startplasmacompositor
> ```
> Most of this patch is just shuffling code around to support both logind and 
> CK2.
> 
> 
> Thanks,
> 
> Eric Koegel
> 
>



Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

2017-06-19 Thread Eric Koegel

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130163/
---

Review request for Plasma.


Repository: kwin


Description
---

ConsoleKit2 as of version 1.1.1 implements the Session Controller dbus calls 
required by Kwin to run under Wayland. This patch first looks for the login1 
service before attempting the ConsoleKit service.


Diffs
-

  logind.h 8bb0206 
  logind.cpp fee0f2f 

Diff: https://git.reviewboard.kde.org/r/130163/diff/


Testing
---

On a system running ConsoleKit2, logging into a text console and running:
```
export $(dbus-launch); export QT_QPA_PLATFORM=wayland; startplasmacompositor
```
Most of this patch is just shuffling code around to support both logind and CK2.


Thanks,

Eric Koegel