Re: [platform-dev] Generic Text Editor for pure E4

2019-07-04 Thread Mickael Istria
On Thu, Jul 4, 2019 at 3:52 PM Alexander Fedorov < alexander.fedo...@arsysop.ru> wrote: > So, let's say we are evaluating switching to E4 for the editors. We > already realized that it will be a long path. > I suggest to establish an incubation project in the E4 space for these > who are

Re: [platform-dev] Generic Text Editor for pure E4

2019-07-04 Thread Alexander Fedorov
Hi, I need to be more specific: "we" means a bit wider part of community who is working with Eclipse-based products that may include text editing. Good part of them are using OSGi components and E4 Workbench and do not want to degrade to E3 (or E2) architecture. Sorry, Mickael, for not

Re: [platform-dev] Generic Text Editor for pure E4

2019-07-04 Thread Tom Schindl
Hi, All I can throw into this discussion is https://github.com/BestSolution-at/code-swt - It was a PoC which i did not worked on afterwards. In the end all main building blocks for editors are in eclipse.text/jface.text who does not depend on any compat-layer APIs. Tom On 04.07.19 10:04,

Re: [platform-dev] Generic Text Editor for pure E4

2019-07-04 Thread Mickael Istria
Hi, See below a few question, and then some ideas. > the core of the Generic Text Editor is not dependent on E3. Can you please elaborate what you specifically mean by this? I'm not a e4 user myself (not really interested in it for my IDE-related work since e3 just does the job quite well), so

Re: [platform-dev] Generic Text Editor for pure E4

2019-07-04 Thread Stefan Dirix
Hi Alexander, I browsed the code of the "ExtensionBasedTextEditor" and for me it seemed that at the core is the ProjectionViewer which is inside a bundle which should be usable without a problem in E4. But as I'm not too familiar with this code I might have (and probably did) miss some other core

Re: [platform-dev] Generic Text Editor for pure E4

2019-07-04 Thread Alexander Fedorov
Hi Stefan, I'm not saying that this is impossible. It is not easy - but we can gain a lot from this. Currently the E4 story is broken on the IDE boundary - any attempt to introduce the IDE functionality returns you back to E3. The Generic Text Editor may be a good starting point: it has a lot

Re: [platform-dev] Generic Text Editor for pure E4

2019-07-03 Thread Alexander Fedorov
Hi, What do you mean by "core"? It is full of E3. We need to start from detaching (altering) AbstractTextEditor from EditorPart I think it is much cheaper to start new "org.eclipse.e4.ui.editors" bundle than trying to remove E3 dependencies from the Generic Text Editor. Regards, AF

[platform-dev] Generic Text Editor for pure E4

2019-07-03 Thread Stefan Dirix
Hi, I'm looking for a way to integrate the Generic Text Editor into a pure E4 (SWT) RCP. I looked at the code and it seems to me that the core of the Generic Text Editor is not dependent on E3. Does anyone know of a previous effort to remove E3 dependencies / integrate the editor into a pure E4