Re: [platform-dev] API changes in SDK

2019-06-13 Thread Lars Vogel
Many, many, thanks, Mickael. Looking forward to have that check automatically done in the Gerrit verification build. On Wed, Jun 12, 2019 at 2:48 PM Mickael Istria wrote: > > Hi all, > > See https://bugs.eclipse.org/bugs/show_bug.cgi?id=474156#c26 for a solution > that would make API errors

Re: [platform-dev] API changes in SDK

2019-05-12 Thread Andrey Loskutov
Ed, see my answers below. On 09.05.2019 10:28, Ed Merks wrote: > Andrey, > > Comments below. > > On 09.05.2019 10:10, Andrey Loskutov wrote: >> Ed, >> >> While we use Oomph in the lab (thanks for the tool!), I can't use Oomph for SDK development, > Why not?I've certainly used to to make

Re: [platform-dev] API changes in SDK

2019-05-12 Thread Andrey Loskutov
I've updated the Wiki, see https://wiki.eclipse.org/Platform/How_to_Contribute#.5B4.5D_Prepare_API_tooling Feel free to improve that. On 09.05.2019 09:49, Rolf Theunissen wrote: Hi, For us new committers, are these rules documented anywhere? I cannot find any references to these kind of rules

Re: [platform-dev] API changes in SDK

2019-05-11 Thread Ed Merks
Nikita, Of course you haven't bothered to report a problem.  And even if you did, in the end, I have to question why should I bother to fix setup problems for the platform in the first place when practically no one uses the results anyway.  I will just make sure the things I personally use,

Re: [platform-dev] API changes in SDK

2019-05-11 Thread Nikita Nemkin
On Fri, May 10, 2019 at 2:26 PM Ed Merks wrote: > With the Oomph setup, the baseline is always set up automatically. > There are Oomph setups for the entire darned Eclipse SDK along with > detailed documentation: > > https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning > I've had

Re: [platform-dev] API changes in SDK

2019-05-10 Thread Rolf Theunissen
9 11:20 PM Subject: Re: [platform-dev] API changes in SDK Sent by: platform-dev-boun...@eclipse.org If only the correct baseline were automatically set...  And all the preferences too.  I wonder how we could possibly do that? It

Re: [platform-dev] API changes in SDK

2019-05-10 Thread Ed Merks
correct baseline were automatically set...  And all the preferences too.  I wonder how From: Ed Merks To: platform-dev@eclipse.org Date: 05/09/2019 11:20 PM Subject: Re: [platform-dev] API changes in SDK Sent by: platform-d

Re: [platform-dev] API changes in SDK

2019-05-10 Thread Vikas Chandra
ock - Bangalore, India Office Phone No : +91 - 80 - 41776506 From: Ed Merks To: platform-dev@eclipse.org Date: 05/09/2019 11:20 PM Subject: Re: [platform-dev] API changes in SDK Sent by:platform-d

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Ed Merks
If only the correct baseline were automatically set...  And all the preferences too.  I wonder how we could possibly do that? It seems pointless to me to record all these important details in an email thread.  Record them in a wiki, if you feel these are important details that are best

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Vikas Chandra
I agree with Andrey in principle ! In short, before submitting any gerrit patch, just keep the default workspace settings and run API tools analysis ( clean->build all) after setting the correct baseline. Ensure that none of the settings has been made more lenient (error changed to warning or

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Lars Vogel
already > > > seem to know the affected projects. > > > > No I don't. One has to look at each project. > > > > Maybe anyone who notices it in one of its projects just fixes it. > > > > Dani > > > > > > > >

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Daniel Megert
To: "Eclipse platform general developers list." Date: 09.05.2019 11:33 Subject: Re: [platform-dev] API changes in SDK Sent by:platform-dev-boun...@eclipse.org Dani, if you open a bug for platform UI and list at least one project with the incorrect setting, I volunteer

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Daniel Megert
general developers list." Date: 09.05.2019 11:09 Subject:Re: [platform-dev] API changes in SDK Sent by:platform-dev-boun...@eclipse.org Would be nice to see you contributing to this effort Dani and you already seem to know the affected projects. Best regards, Lars On Thu, May

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Lars Vogel
"Eclipse platform general developers list." > > Date: 09.05.2019 10:49 > Subject:Re: [platform-dev] API changes in SDK > Sent by:platform-dev-boun...@eclipse.org > > > > > > One important addition here:

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Daniel Megert
Everyone can do this ;-). Dani From: Lars Vogel To: "Eclipse platform general developers list." Date: 09.05.2019 10:49 Subject: Re: [platform-dev] API changes in SDK Sent by:platform-dev-boun...@eclipse.org > One important addition here: some plug

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Lars Vogel
> One important addition here: some plug-ins and even the default workspace Dani, please open a bug for that and list the project which uses this project setting. We should adjust that. On Thu, May 9, 2019 at 10:42 AM Daniel Megert wrote: > > Thanks Andrey for this reminder! > > > If after that

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Daniel Megert
Thanks Andrey for this reminder! > If after that you see API errors in the workspace, One important addition here: some plug-ins and even the default workspace have some problems being reported as warning. So, you also need to check whether there are new API related warnings. Even better,

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Lars Vogel
Hi Mickael, I'm also bad with API Tools. Unfortunately I also have the impression that least for deleting API the API tooling is buggy and as I'm mainly the person who deletes API it usually hits me. Unfortunately I'm not able to reproduce this bugs recently. Examples for possible API tools

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Ed Merks
t;Ed Merks" An: platform-dev@eclipse.org Betreff: Re: [platform-dev] API changes in SDK Andrey, Perhaps folks should rather consider consistently using the same automated setup so that everyone consistently see the same thing as everyone else.  That's the purpose of the Oomph setup: to

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Mickael Istria
Hi, While I understand Andrey and others and fully agree with them on the necessity and value of project respecting API rules and process for that -while I am one of the "worst citizen" on that matter in practice-, I think any proposal that involves enforcing developers to use or setup anything

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Andrey Loskutov
et: Donnerstag, 09. Mai 2019 um 09:49 Uhr > Von: "Rolf Theunissen" > An: platform-dev@eclipse.org > Betreff: Re: [platform-dev] API changes in SDK > > Hi, > > For us new committers, are these rules documented anywhere? I cannot > find any references to thes

Re: [platform-dev] API changes in SDK

2019-05-09 Thread Ed Merks
Andrey, Perhaps folks should rather consider consistently using the same automated setup so that everyone consistently see the same thing as everyone else.  That's the purpose of the Oomph setup: to avoid all the manual steps you describe here. Regards, Ed On 08.05.2019 21:20, Andrey