[platform-dev] Where is the e4 model for the workbench located?

Hi, I want to work on this bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=546115 and as a first shot I wanted to add Wim’s custom CTabFolder implementation to the workbench’s e4 model. Unfortunately I didn't find the e4 model of the workbench. In which plugin is it located? Thanks and

Re: [platform-dev] Where is the e4 model for the workbench located?

you leave the spy open and restart. Best regards, Lars On Thu, Jan 13, 2022 at 2:35 PM Hoepfner, Marcus via platform-dev wrote: > > Hi, > > > > I want to work on this bug > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.eclipse.org%2Fbugs%2Fshow_bug.

[platform-dev] Using MasterDetailBlock on e.g. Dialog without FormHeading (whitespace)

Hi, o.e.ui.forms.MasterDetailsBlock requires a ManagedForm in createContent(IManagedForm managedForm). ManagedForm wants (or creates) a ScrolledForm. A ScrolledForm creates a Form (with FormHeading and a Composite for the body). Means, when using a MasterDetailsBlock in a view or dialog all

Re: [platform-dev] Migration of eclipse.platform.common and eclipse.platform.team

Is it planned to create a README.md? This is somehow common in github repos and it looks IMHO strange if there is not “welcome” or descriptive text of the repo. From: eclipse-dev on behalf of Sravan K Lakkimsetti Date: Monday, 14. March 2022 at 18:54 To: platform-dev , equinox-...@eclipse.org

Re: [platform-dev] Cannot push to github g...@github.com:eclipse-platform/eclipse.platform.ui.git

Hoepfner, Marcus via platform-dev wrote: Hi, did not follow all the discussion how to contribute after moved to github. Do I need to fork or can I push to new branch in g...@github.com:eclipse-platform/eclipse.platform.ui.git<mailto:g...@github.com:eclipse-platform/eclipse.platform.ui.gi

Re: [platform-dev] Cannot push to github g...@github.com:eclipse-platform/eclipse.platform.ui.git

.O04Xdvi7.9jOb7JMG@gmail.com] I suppose you could add a comment with @vogella to send a more directed notification... On 18.05.2022 14:40, Hoepfner, Marcus via platform-dev wrote: Thanks. I have created a fork and a PR now on https://github.com/eclipse-platform/eclipse.platform.ui<https://eu

[platform-dev] Cannot push to github g...@github.com:eclipse-platform/eclipse.platform.ui.git

Hi, did not follow all the discussion how to contribute after moved to github. Do I need to fork or can I push to new branch in g...@github.com:eclipse-platform/eclipse.platform.ui.git? How do I become contributer in that repo? I

[platform-dev] Retriever a build on eclipse.platform

How can I retrigger a build in repo https://github.com/eclipse-platform/eclipse.platform? Do we have this information somewhere (e.g. contributing.md)? I did not find it. Could we add it there? ___ platform-dev mailing list platform-dev@eclipse.org To

Re: [platform-dev] Review practice

Why are you asking? Did you see a concrete issue in particular? I general I’d not commit without code review. I usually get helpful comments. And even it is just about a typo in Javadoc, it is worth it. A colleague once said, code review is kind of deferred pair programming. I like that, though