Re: [platform-dev] org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error settings in platform code
forget about my last message, I think in this case it is actually the org.eclipse.jdt.core.compiler.problem.missingJavadocTagDescription=return_tag (Missing Tags Description) and org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=disabled (Validate Tag arguments) that are missing in the prefs and thus taken from the global defaults. so what should be done here? Should I complete the project local prefs? Or could this be done with adjusting the oompf setup (so I don't need to change 60+ files)? Are these settings "correct" as they obviously hide a lot of mailformed javadoc? Am 19.08.21 um 09:54 schrieb Ed Merks: Christoph, Comments below. On 19.08.2021 09:03, Christoph Läubrich wrote: Hi Ed, I used the oompf setup and regularly do "Search For Updates" and "Perform Setup Tasks" is this the right way to keep up to date? The latter is more correct. E.g., it would take into account any changes to the setup that might introduce new requirements that would not be picked up simply by updating existing requirements. As an example the bundle 'org.eclipse.equinox.p2.artifact.repository' without the change in settings I get an error in ChecksumUtilities: Description Resource Path Location Type Javadoc: Description expected after this reference ChecksumUtilities.java /org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/checksum line 39 Java Problem The quickfix suggest me to configure problem severity where the "Malformed Javadoc comments" are set to "Error", if i turn this into "warning" the marker change to warning, so I assume this is the relevant setting here. That's strange though because I don't see errors for that file at that line: And the project specific preferences say this: While the global ones say this: If I recall correctly if for any specific preference it's not present in the *.prefs, that one will default to the global one. Nothing here appears to validate the @param nor to care that there is a missing comment even if it did... Regards, Ed Maybe there needs something to be configured on the preferences as well? Am 19.08.21 um 07:32 schrieb Ed Merks: Christoph, I have the entire SDK in a workspace without errors: This is of course using the Oomph setups for these projects. https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning Perhaps you're doing something differently from others? What's an example of an error that you see? If I break some Javadoc in a project with this set to error, it does result in an error: Regards, Ed On 18.08.2021 19:28, Christoph Läubrich wrote: One thing I always wonder, most projects in platform use a project specific setting org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error but with this settings enabled there are hundreds of errors and the workspace is nearly unusable. So my first task is always to change the error to warning to at least get a valid build. I can understand that one want to have valid javadoc, but enabling this and not fixing the errors seems strange to me. So how is this to be handeled? I really don't like to change/reset settings each time I pull the changes from the repo... ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Re: [platform-dev] org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error settings in platform code
Hi Ed, thanks for your verification. Do I understand it correctly that in this case the "project specific settings" are incomplete so it pulls some settings from my (global oompf managed) preferences? Is this expected or is it a bug? Am 19.08.21 um 09:54 schrieb Ed Merks: Christoph, Comments below. On 19.08.2021 09:03, Christoph Läubrich wrote: Hi Ed, I used the oompf setup and regularly do "Search For Updates" and "Perform Setup Tasks" is this the right way to keep up to date? The latter is more correct. E.g., it would take into account any changes to the setup that might introduce new requirements that would not be picked up simply by updating existing requirements. As an example the bundle 'org.eclipse.equinox.p2.artifact.repository' without the change in settings I get an error in ChecksumUtilities: Description Resource Path Location Type Javadoc: Description expected after this reference ChecksumUtilities.java /org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/checksum line 39 Java Problem The quickfix suggest me to configure problem severity where the "Malformed Javadoc comments" are set to "Error", if i turn this into "warning" the marker change to warning, so I assume this is the relevant setting here. That's strange though because I don't see errors for that file at that line: And the project specific preferences say this: While the global ones say this: If I recall correctly if for any specific preference it's not present in the *.prefs, that one will default to the global one. Nothing here appears to validate the @param nor to care that there is a missing comment even if it did... Regards, Ed Maybe there needs something to be configured on the preferences as well? Am 19.08.21 um 07:32 schrieb Ed Merks: Christoph, I have the entire SDK in a workspace without errors: This is of course using the Oomph setups for these projects. https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning Perhaps you're doing something differently from others? What's an example of an error that you see? If I break some Javadoc in a project with this set to error, it does result in an error: Regards, Ed On 18.08.2021 19:28, Christoph Läubrich wrote: One thing I always wonder, most projects in platform use a project specific setting org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error but with this settings enabled there are hundreds of errors and the workspace is nearly unusable. So my first task is always to change the error to warning to at least get a valid build. I can understand that one want to have valid javadoc, but enabling this and not fixing the errors seems strange to me. So how is this to be handeled? I really don't like to change/reset settings each time I pull the changes from the repo... ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Re: [platform-dev] org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error settings in platform code
Christoph, Comments below. On 19.08.2021 09:03, Christoph Läubrich wrote: Hi Ed, I used the oompf setup and regularly do "Search For Updates" and "Perform Setup Tasks" is this the right way to keep up to date? The latter is more correct. E.g., it would take into account any changes to the setup that might introduce new requirements that would not be picked up simply by updating existing requirements. As an example the bundle 'org.eclipse.equinox.p2.artifact.repository' without the change in settings I get an error in ChecksumUtilities: Description Resource Path Location Type Javadoc: Description expected after this reference ChecksumUtilities.java /org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/checksum line 39 Java Problem The quickfix suggest me to configure problem severity where the "Malformed Javadoc comments" are set to "Error", if i turn this into "warning" the marker change to warning, so I assume this is the relevant setting here. That's strange though because I don't see errors for that file at that line: And the project specific preferences say this: While the global ones say this: If I recall correctly if for any specific preference it's not present in the *.prefs, that one will default to the global one. Nothing here appears to validate the @param nor to care that there is a missing comment even if it did... Regards, Ed Maybe there needs something to be configured on the preferences as well? Am 19.08.21 um 07:32 schrieb Ed Merks: Christoph, I have the entire SDK in a workspace without errors: This is of course using the Oomph setups for these projects. https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning Perhaps you're doing something differently from others? What's an example of an error that you see? If I break some Javadoc in a project with this set to error, it does result in an error: Regards, Ed On 18.08.2021 19:28, Christoph Läubrich wrote: One thing I always wonder, most projects in platform use a project specific setting org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error but with this settings enabled there are hundreds of errors and the workspace is nearly unusable. So my first task is always to change the error to warning to at least get a valid build. I can understand that one want to have valid javadoc, but enabling this and not fixing the errors seems strange to me. So how is this to be handeled? I really don't like to change/reset settings each time I pull the changes from the repo... ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Re: [platform-dev] org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error settings in platform code
Hi Chistoph, When you use Oomph, these settings could have been stored in your user setup setting and will be automatically applied to each of your installations. To check out the user configuration: Navigate > Open Setup > User > User Preferences > org.eclipse.jdt.core > compiler.problem.invalidJavadoc = error Or change the preference in the Java > Compiler > Javadoc preferences (with preference recorder enabled). Rolf Op do 19 aug. 2021 om 09:03 schreef Christoph Läubrich < lae...@laeubi-soft.de>: > Hi Ed, > > I used the oompf setup and regularly do "Search For Updates" and > "Perform Setup Tasks" is this the right way to keep up to date? > > As an example the bundle 'org.eclipse.equinox.p2.artifact.repository' > without the change in settings I get an error in ChecksumUtilities: > > Description ResourcePathLocationType > Javadoc: Description expected after this reference > ChecksumUtilities.java > /org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/checksum > > line 39 Java Problem > > The quickfix suggest me to configure problem severity where the > "Malformed Javadoc comments" are set to "Error", if i turn this into > "warning" the marker change to warning, so I assume this is the relevant > setting here. > > Maybe there needs something to be configured on the preferences as well? > > > Am 19.08.21 um 07:32 schrieb Ed Merks: > > Christoph, > > > > I have the entire SDK in a workspace without errors: > > > > This is of course using the Oomph setups for these projects. > > > > https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning > > > > Perhaps you're doing something differently from others? What's an > > example of an error that you see? > > > > If I break some Javadoc in a project with this set to error, it does > > result in an error: > > > > > > Regards, > > Ed > > > > > > On 18.08.2021 19:28, Christoph Läubrich wrote: > >> One thing I always wonder, most projects in platform use a project > >> specific setting > >> > >> org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error > >> > >> but with this settings enabled there are hundreds of errors and the > >> workspace is nearly unusable. > >> > >> So my first task is always to change the error to warning to at least > >> get a valid build. > >> > >> I can understand that one want to have valid javadoc, but enabling > >> this and not fixing the errors seems strange to me. So how is this to > >> be handeled? I really don't like to change/reset settings each time I > >> pull the changes from the repo... > >> ___ > >> platform-dev mailing list > >> platform-dev@eclipse.org > >> To unsubscribe from this list, visit > >> https://www.eclipse.org/mailman/listinfo/platform-dev > > > > ___ > > platform-dev mailing list > > platform-dev@eclipse.org > > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev > > > ___ > platform-dev mailing list > platform-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev > ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Re: [platform-dev] org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error settings in platform code
Hi Ed, I used the oompf setup and regularly do "Search For Updates" and "Perform Setup Tasks" is this the right way to keep up to date? As an example the bundle 'org.eclipse.equinox.p2.artifact.repository' without the change in settings I get an error in ChecksumUtilities: Description ResourcePathLocationType Javadoc: Description expected after this reference ChecksumUtilities.java /org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/checksum line 39 Java Problem The quickfix suggest me to configure problem severity where the "Malformed Javadoc comments" are set to "Error", if i turn this into "warning" the marker change to warning, so I assume this is the relevant setting here. Maybe there needs something to be configured on the preferences as well? Am 19.08.21 um 07:32 schrieb Ed Merks: Christoph, I have the entire SDK in a workspace without errors: This is of course using the Oomph setups for these projects. https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning Perhaps you're doing something differently from others? What's an example of an error that you see? If I break some Javadoc in a project with this set to error, it does result in an error: Regards, Ed On 18.08.2021 19:28, Christoph Läubrich wrote: One thing I always wonder, most projects in platform use a project specific setting org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error but with this settings enabled there are hundreds of errors and the workspace is nearly unusable. So my first task is always to change the error to warning to at least get a valid build. I can understand that one want to have valid javadoc, but enabling this and not fixing the errors seems strange to me. So how is this to be handeled? I really don't like to change/reset settings each time I pull the changes from the repo... ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
Re: [platform-dev] org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error settings in platform code
Not that it answers your question directly, but you can use “git update-index —assume-unchanged” to make it appear that you haven’t changed the file and so not to be considered as a diff when pulling. I have a wrapper script called “git forget” because it’s easier to type. https://github.com/alblue/scripts/blob/main/git-forget Sent from my iPhone > On 18 Aug 2021, at 18:28, Christoph Läubrich wrote: > > One thing I always wonder, most projects in platform use a project specific > setting > > org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error > > but with this settings enabled there are hundreds of errors and the workspace > is nearly unusable. > > So my first task is always to change the error to warning to at least get a > valid build. > > I can understand that one want to have valid javadoc, but enabling this and > not fixing the errors seems strange to me. So how is this to be handeled? I > really don't like to change/reset settings each time I pull the changes from > the repo... > ___ > platform-dev mailing list > platform-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
[platform-dev] org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error settings in platform code
One thing I always wonder, most projects in platform use a project specific setting org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error but with this settings enabled there are hundreds of errors and the workspace is nearly unusable. So my first task is always to change the error to warning to at least get a valid build. I can understand that one want to have valid javadoc, but enabling this and not fixing the errors seems strange to me. So how is this to be handeled? I really don't like to change/reset settings each time I pull the changes from the repo... ___ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
