Re: Non-standard variables in %cmake macro

2014-01-27 Thread Jakub Bogusz
On Sat, Jan 11, 2014 at 02:56:21PM +0100, Jan Rękorajski wrote: On Sat, 04 Jan 2014, Jakub Bogusz wrote: The following variables set in %cmake macro: -DINCLUDE_INSTALL_DIR:PATH=%{_includedir} \\\ -DLIB_INSTALL_DIR:PATH=%{_libdir} \\\ -DSHARE_INSTALL_PREFIX:PATH=%{_datadir

Re: Non-standard variables in %cmake macro

2014-01-11 Thread Jan Rękorajski
On Sat, 04 Jan 2014, Jakub Bogusz wrote: The following variables set in %cmake macro: -DINCLUDE_INSTALL_DIR:PATH=%{_includedir} \\\ -DLIB_INSTALL_DIR:PATH=%{_libdir} \\\ -DSHARE_INSTALL_PREFIX:PATH=%{_datadir} \\\ -DSYSCONF_INSTALL_DIR:PATH=%{_sysconfdir} \\\ aren't

Non-standard variables in %cmake macro

2014-01-04 Thread Jakub Bogusz
The following variables set in %cmake macro: -DINCLUDE_INSTALL_DIR:PATH=%{_includedir} \\\ -DLIB_INSTALL_DIR:PATH=%{_libdir} \\\ -DSHARE_INSTALL_PREFIX:PATH=%{_datadir} \\\ -DSYSCONF_INSTALL_DIR:PATH=%{_sysconfdir} \\\ aren't standard for cmake; they appear in some examples

Re: %cmake macro

2011-02-04 Thread Jakub Bogusz
On Thu, Feb 03, 2011 at 06:55:48PM +0100, Kacper Kornet wrote: On Thu, Feb 03, 2011 at 06:10:29PM +0100, Jakub Bogusz wrote: On Tue, Feb 01, 2011 at 07:51:42PM +0100, Kacper Kornet wrote: [... 3. Use or own build type like: cmake -DCMAKE_C_FLAGS_PLD=${CFLAGS:-%{rpmcflags}} + -DNDEBUG

Re: %cmake macro

2011-02-04 Thread Kacper Kornet
On Fri, Feb 04, 2011 at 07:22:58PM +0100, Jakub Bogusz wrote: On Thu, Feb 03, 2011 at 06:55:48PM +0100, Kacper Kornet wrote: On Thu, Feb 03, 2011 at 06:10:29PM +0100, Jakub Bogusz wrote: On Tue, Feb 01, 2011 at 07:51:42PM +0100, Kacper Kornet wrote: [... 3. Use or own build type like:

Re: %cmake macro

2011-02-04 Thread Przemyslaw Iskra
On Fri, Feb 04, 2011 at 07:45:38PM +0100, Kacper Kornet wrote: So the question is whether assert should have no effect only in cmake based packages or in all programs. Problem is that not everyone knows how to use assert() makro, so if a package has not been prepared by the developers to work

Re: %cmake macro

2011-02-04 Thread Kacper Kornet
On Fri, Feb 04, 2011 at 07:59:26PM +0100, Przemyslaw Iskra wrote: On Fri, Feb 04, 2011 at 07:45:38PM +0100, Kacper Kornet wrote: So the question is whether assert should have no effect only in cmake based packages or in all programs. Problem is that not everyone knows how to use assert()

Re: %cmake macro

2011-02-03 Thread Jakub Bogusz
On Tue, Feb 01, 2011 at 07:51:42PM +0100, Kacper Kornet wrote: I think that current %cmake macro is broken. For example soprano.spec is build with options: -O2 ... -O3, which is effectively -O3. As far as I understand the preferred option would be -O2, In cmake the options are build form

Re: %cmake macro

2011-02-03 Thread Kacper Kornet
On Thu, Feb 03, 2011 at 06:10:29PM +0100, Jakub Bogusz wrote: On Tue, Feb 01, 2011 at 07:51:42PM +0100, Kacper Kornet wrote: 2. Change the build type we use to None. Then only CMAKE_C_FLAGS will be used Flaws: Same as above. But I don't know if any package redefines that variable

%cmake macro

2011-02-01 Thread Kacper Kornet
I think that current %cmake macro is broken. For example soprano.spec is build with options: -O2 ... -O3, which is effectively -O3. As far as I understand the preferred option would be -O2, In cmake the options are build form two variables as following as: CMAKE_C_FLAGS CMAKE_C_FLAGS_Buildtype