Re: [packages/kernel] - drop unneeded excludes (rpm 4.16 handles these differently from rpm 5)

2020-12-16 Thread Arkadiusz Miśkiewicz via pld-devel-en
W dniu 16.12.2020 o 10:36, Arkadiusz Miśkiewicz pisze:
> W dniu 16.12.2020 o 10:14, Elan Ruusamäe pisze:
>> On 15.12.2020 18:05, arekm wrote:
>>
>>>   %exclude %{_kernelsrcdir}/scripts/mod
>>> -%exclude %{_kernelsrcdir}/scripts/module-common.lds
>>
>> what do you mean?
>>
>> rpm 4.16 does prefix match and rpm5 does glob match?
>>
>> ie that
>>
>> %{_kernelsrcdir}/scripts/mod
>>
>>   matches also
>>
>> %{_kernelsrcdir}/scripts/module-common.lds
>>
>>   on 4.16?
>>
>>
>> does your change make .spec inclusive to 4.16-only now?
> 
> %exclude non-existsing-file seems to pass on 4.16 while fail on 5.
> 
> 
> Similar thing - %doc with not existing file succeeds on 4.16.
> 

Another one. Non existing %ghost also doesn't cause build failure and
results in unpackaged files (if soname gets new version while spec has
old one as ghost).


-- 
Arkadiusz Miśkiewicz, arekm / ( maven.pl | pld-linux.org )
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: [packages/kernel] - drop unneeded excludes (rpm 4.16 handles these differently from rpm 5)

2020-12-16 Thread Arkadiusz Miśkiewicz
W dniu 16.12.2020 o 10:14, Elan Ruusamäe pisze:
> On 15.12.2020 18:05, arekm wrote:
> 
>>   %exclude %{_kernelsrcdir}/scripts/mod
>> -%exclude %{_kernelsrcdir}/scripts/module-common.lds
> 
> what do you mean?
> 
> rpm 4.16 does prefix match and rpm5 does glob match?
> 
> ie that
> 
> %{_kernelsrcdir}/scripts/mod
> 
>   matches also
> 
> %{_kernelsrcdir}/scripts/module-common.lds
> 
>   on 4.16?
> 
> 
> does your change make .spec inclusive to 4.16-only now?

%exclude non-existsing-file seems to pass on 4.16 while fail on 5.


Similar thing - %doc with not existing file succeeds on 4.16.

-- 
Arkadiusz Miśkiewicz, arekm / ( maven.pl | pld-linux.org )
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: [packages/kernel] - drop unneeded excludes (rpm 4.16 handles these differently from rpm 5)

2020-12-16 Thread Elan Ruusamäe

On 15.12.2020 18:05, arekm wrote:


  %exclude %{_kernelsrcdir}/scripts/mod
-%exclude %{_kernelsrcdir}/scripts/module-common.lds


what do you mean?

rpm 4.16 does prefix match and rpm5 does glob match?

ie that

%{_kernelsrcdir}/scripts/mod

  matches also

%{_kernelsrcdir}/scripts/module-common.lds

  on 4.16?


does your change make .spec inclusive to 4.16-only now?


___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en