Re: new spec (lyricue)

2010-03-29 Thread Elan Ruusamäe
are you all aware who gave +1, that you should be mentoring his commits? :) On Saturday 10 November 2007 01:53:33 Aria Stewart wrote: +1 for me for commit access. On Saturday 10 November 2007 02:06:07 Krystian Tomczyk wrote: +1 On Tuesday 13 November 2007 01:56:42 Arkadiusz Patyk wrote: +1

Re: new spec (lyricue)

2010-03-29 Thread Elan Ruusamäe
On Monday 29 March 2010 14:48:05 Caleb Maclennan wrote: Question about log messages. I noticed after I committed a bump to the version of hugin last night that most log messages for spec file commits start with a leading dash. Does this have a special meaning or is it just convention that I

Re: new spec (lyricue)

2010-03-29 Thread Caleb Maclennan
Thanks for the links to relevant current developer documentation. I'll keep an eye on those guidelines. I have to say that even having been an avid PLD user for 10+ years the lack of clear easy to find documentation (and the amount of outdated, irrelevant and contradictory documentation floating

Re: new spec (lyricue)

2010-03-29 Thread Artur Wroblewski
On Mon, Mar 29, 2010 at 3:05 PM, Caleb Maclennan ca...@pld-linux.org wrote: Thanks for the links to relevant current developer documentation. I'll keep an eye on those guidelines. I have to say that even having been an avid PLD user for 10+ years the lack of clear easy to find documentation

Re: new spec (lyricue)

2007-11-12 Thread Arkadiusz Patyk
On Sat, 10 Nov 2007 01:06:07 +0100, you wrote: Dnia 09-11-2007, Pt o godzinie 16:53 -0700, Aria Stewart pisze: On Nov 9, 2007, at 4:39 PM, Caleb Maclennan wrote: Up until now my contributions have been made by proxy through aredridel, but I have been lurking here on the devel list for

Re: new spec (lyricue)

2007-11-09 Thread Aria Stewart
On Nov 9, 2007, at 4:39 PM, Caleb Maclennan wrote: Up until now my contributions have been made by proxy through aredridel, but I have been lurking here on the devel list for some time and decided there was no reason I couldn't offer to be involved more directly. I am experienced as a

Re: new spec (lyricue)

2007-11-09 Thread Krystian Tomczyk
Dnia 09-11-2007, Pt o godzinie 16:53 -0700, Aria Stewart pisze: On Nov 9, 2007, at 4:39 PM, Caleb Maclennan wrote: Up until now my contributions have been made by proxy through aredridel, but I have been lurking here on the devel list for some time and decided there was no reason I

Re: new spec (lyricue)

2007-11-09 Thread Andrzej Krzysztofowicz
Caleb Maclennan wrote: Hello all, Hi Caleb, Just few hot comments on your spec: BuildRoot:%{tmpdir}/%{name}-%{version}-root-%(id -u -n) Patch0: %{name}-makefile.patch Patch1: %{name}-desktop.patch We try to keep the BuildRoot entry as the last in this

Re: new spec (lyricue)

2007-11-09 Thread Aria Stewart
On Nov 9, 2007, at 5:49 PM, Andrzej Krzysztofowicz wrote: Caleb Maclennan wrote: Hello all, Hi Caleb, Just few hot comments on your spec: BuildRoot: %{tmpdir}/%{name}-%{version}-root-%(id -u -n) Patch0: %{name}-makefile.patch Patch1: %{name}-desktop.patch

Re: new spec (lyricue)

2007-11-09 Thread Caleb Maclennan
On Fri, Nov 09, 2007 at 06:11:19PM -0700, Aria Stewart wrote: On Nov 9, 2007, at 5:49 PM, Andrzej Krzysztofowicz wrote: We try to keep the BuildRoot entry as the last in this section. Patch# just after Sources. Indeed. The ./adapter script in the SPECS repo does a lot of this. The

Re: new spec (lyricue)

2007-11-09 Thread Caleb Maclennan
Thanks for the pointers Andrzej. I am attaching an updated spec file with your changes. Caleb # $Revision:$, $Date:$ Summary:The GNU Lyric Display System Name: lyricue Version:1.9.6 Release:0.6 License:GPL Group: X11/Applications/Graphics URL:

Re: new spec (lyricue)

2007-11-09 Thread Elan Ruusamäe
On Saturday 10 November 2007 03:21:36 Caleb Maclennan wrote: Thanks for the pointers Andrzej. I am attaching an updated spec file with your changes. Caleb %dir %{_docdir}/lyricue %doc %{_docdir}/lyricue/* first dir should be also %doc but rather using rpmbuildroot paths use relative %doc

Re: new spec (lyricue)

2007-11-09 Thread Caleb Maclennan
On Sat, Nov 10, 2007 at 04:16:36AM +0200, Elan Ruusamäe wrote: but rather using rpmbuildroot paths use relative %doc from builddir, then documents get compressed too: %doc docs/* Ok, this didn't quite make sense to me but I think I figured out what you were after. See if this fits the bill.