Re: builder bug: fetching patch from URL when it's already in CVS
On Tuesday 04 April 2006 16:27, Jakub Bogusz wrote: $ ./builder -bp -r LINUX_2_6 kernel.spec [...] --15:21:35-- http://bluetooth-alsa.sourceforge.net/sco-mtu.patch = `sco-mtu.patch' [...] cvs server: move away sco-mtu.patch; it is in the way C sco-mtu.patch the offending change is: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SPECS/builder.diff?r1=1.376;r2=1.377;f=h builder shouldn't fetch anything from URLs given in SourceX/PatchX if it's present in CVS/distfiles and fetching from CVS/df is not disabled by command line option. And it didn't... till some day. It seems to be some bug introduced quite recently. -- glen ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: builder bug: fetching patch from URL when it's already in CVS
On Tuesday 04 April 2006 17:20, Elan Ruusamäe wrote: i noticed the bug too, and i wasn't sure is it worth to fix, as if the source patch and patch in cvs are identical, there's no such warning issued. so in most cases just update the patch in SOURCES? i was wrong here. the bug is not reproducible if you had the file in SOURCES before the fetch. ie to overcome the problem - cd ../SOURCES - rm offending_file - cvs up offending_file - cd - - !builder -- glen ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
builder bug: fetching patch from URL when it's already in CVS
$ ./builder -bp -r LINUX_2_6 kernel.spec [...] --15:21:35-- http://bluetooth-alsa.sourceforge.net/sco-mtu.patch = `sco-mtu.patch' [...] cvs server: move away sco-mtu.patch; it is in the way C sco-mtu.patch builder shouldn't fetch anything from URLs given in SourceX/PatchX if it's present in CVS/distfiles and fetching from CVS/df is not disabled by command line option. And it didn't... till some day. It seems to be some bug introduced quite recently. -- Jakub Boguszhttp://qboosh.cs.net.pl/ ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: builder bug: fetching patch from URL when it's already in CVS
On Tuesday 04 April 2006 16:27, Jakub Bogusz wrote: $ ./builder -bp -r LINUX_2_6 kernel.spec [...] --15:21:35-- http://bluetooth-alsa.sourceforge.net/sco-mtu.patch = `sco-mtu.patch' [...] cvs server: move away sco-mtu.patch; it is in the way C sco-mtu.patch builder shouldn't fetch anything from URLs given in SourceX/PatchX if it's present in CVS/distfiles and fetching from CVS/df is not disabled by command line option. And it didn't... till some day. It seems to be some bug introduced quite recently. the builder behavior was updated, to fetch first remote urls, and then group cvs up to one single execution. the speedup was 3 minutes vs 3 seconds for kernel.spec! and with this technology how can builder know if file exists in cvs/df without fetching it via cvs up/wget? i noticed the bug too, and i wasn't sure is it worth to fix, as if the source patch and patch in cvs are identical, there's no such warning issued. so in most cases just update the patch in SOURCES? and if url and sources are not identical then there should not put full url in specfile. -- glen ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: builder bug: fetching patch from URL when it's already in CVS
Elan =?iso-8859-1?q?Ruusam=E4e?= wrote: On Tuesday 04 April 2006 16:27, Jakub Bogusz wrote: $ ./builder -bp -r LINUX_2_6 kernel.spec [...] --15:21:35-- http://bluetooth-alsa.sourceforge.net/sco-mtu.patch = `sco-mtu.patch' [...] cvs server: move away sco-mtu.patch; it is in the way C sco-mtu.patch builder shouldn't fetch anything from URLs given in SourceX/PatchX if it's present in CVS/distfiles and fetching from CVS/df is not disabled by command line option. And it didn't... till some day. It seems to be some bug introduced quite recently. the builder behavior was updated, to fetch first remote urls, and then group cvs up to one single execution. the speedup was 3 minutes vs 3 seconds for kernel.spec! and with this technology how can builder know if file exists in cvs/df without fetching it via cvs up/wget? i noticed the bug too, and i wasn't sure is it worth to fix, as if the source patch and patch in cvs are identical, there's no such warning issued. so in most cases just update the patch in SOURCES? The main intention for disabling fetching sources by builders from URLs were security reasons. Maybe the new behaviour should be optional, for disabling it on builders? and if url and sources are not identical then there should not put full url in specfile. AFAIR, some sources change periodically; having an URL for them and not using distfiles you can easily know when they change and the md5 needs to be updated. Why to disable this feature? -- === Andrzej M. Krzysztofowicz [EMAIL PROTECTED] phone (48)(58) 347 14 61 Faculty of Applied Phys. Math., Gdansk University of Technology ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: builder bug: fetching patch from URL when it's already in CVS
On Tuesday 04 April 2006 18:09, Andrzej Krzysztofowicz wrote: Elan =?iso-8859-1?q?Ruusam=E4e?= wrote: On Tuesday 04 April 2006 16:27, Jakub Bogusz wrote: $ ./builder -bp -r LINUX_2_6 kernel.spec [...] --15:21:35-- http://bluetooth-alsa.sourceforge.net/sco-mtu.patch = `sco-mtu.patch' [...] cvs server: move away sco-mtu.patch; it is in the way C sco-mtu.patch builder shouldn't fetch anything from URLs given in SourceX/PatchX if it's present in CVS/distfiles and fetching from CVS/df is not disabled by command line option. And it didn't... till some day. It seems to be some bug introduced quite recently. the builder behavior was updated, to fetch first remote urls, and then group cvs up to one single execution. the speedup was 3 minutes vs 3 seconds for kernel.spec! and with this technology how can builder know if file exists in cvs/df without fetching it via cvs up/wget? i noticed the bug too, and i wasn't sure is it worth to fix, as if the source patch and patch in cvs are identical, there's no such warning issued. so in most cases just update the patch in SOURCES? The main intention for disabling fetching sources by builders from URLs were security reasons. Maybe the new behaviour should be optional, for disabling it on builders? it doesn't change for src-builders, as builders always use *only* SOURCES/distfiles, no url fetching. and if url and sources are not identical then there should not put full url in specfile. AFAIR, some sources change periodically; having an URL for them and not using distfiles you can easily know when they change and the md5 needs to be updated. Why to disable this feature? it's rather side effect ;) and there was speaken PATCHx (which have no md5), not SOURCEx, and afaik SOURCEx is not affected. -- glen ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
