Re: i3lock - spec file

2023-07-12 Thread Jan Palus
On 12.07.2023 17:10, Mateusz Kocielski wrote: > Dnia Wed, Jul 12, 2023 at 01:22:08PM +0200, Jan Palus napisał(a): > > > > Override pam configuration shipped with i3lock with custom one that has: > > > > auth include system-auth > > > > just like (all?) other screensavers/lockers and

Re: i3lock - spec file

2023-07-12 Thread Mateusz Kocielski
Dnia Wed, Jul 12, 2023 at 01:22:08PM +0200, Jan Palus napisał(a): > > Override pam configuration shipped with i3lock with custom one that has: > > auth include system-auth > > just like (all?) other screensavers/lockers and it should be fine. > > Other than this > > 1. Fix case in

Re: i3lock - spec file

2023-07-12 Thread Jan Palus
On 11.07.2023 20:30, Mateusz Kocielski wrote: > Dnia Tue, Jul 11, 2023 at 03:59:41PM +, Mateusz Kocielski napisał(a): > > > That's peculiar -- what screen locker needs suid bit for? Why wheel > > > group? > > > > Wheel group is taken from my BSD heritage I guess, fixed it. :) It requires > >

Re: i3lock - spec file

2023-07-11 Thread Mateusz Kocielski
Dnia Tue, Jul 11, 2023 at 03:59:41PM +, Mateusz Kocielski napisał(a): > > That's peculiar -- what screen locker needs suid bit for? Why wheel > > group? > > Wheel group is taken from my BSD heritage I guess, fixed it. :) It requires > PAM for an authentication. > > > >

Re: i3lock - spec file

2023-07-11 Thread Mateusz Kocielski
Dnia Tue, Jul 11, 2023 at 01:36:19PM +0200, Jan Palus napisał(a): > Hi, > > thanks for contributing! Overall looks good. Some comments below. > Hello, thanks for your helpful comments, below my comments and fixed version of the spec. > > Summary:improved screen locker > > Start summary

Re: i3lock - spec file

2023-07-11 Thread Jan Palus
Hi, thanks for contributing! Overall looks good. Some comments below. On 11.07.2023 10:29, Mateusz Kocielski wrote: > Hi there, > > I've prepared spec file to build i3lock [1]. This is my first spec file, so > please review it carefully. The software requires suid to be able to verify >