Re: pull request for dhcp – fixed the init script
On Sun, Apr 4, 2021 at 4:49 PM Elan Ruusamäe wrote: > On 04.04.2021 16:13, Paweł Zuzelski wrote: > > > > I sent another PR on Github, with that change it builds at th-2020 > > (and has been working well for me for like two days now). > > you could at least share the link of the pull request. so could fetch > the changes from there. Here you go: https://github.com/pld-linux/dhcp/pull/2 ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: pull request for dhcp – fixed the init script
On 04.04.2021 16:13, Paweł Zuzelski wrote: I sent another PR on Github, with that change it builds at th-2020 (and has been working well for me for like two days now). you could at least share the link of the pull request. so could fetch the changes from there. ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: pull request for dhcp – fixed the init script
On Sun, Apr 4, 2021 at 2:26 PM Elan Ruusamäe wrote: > On 02.04.2021 13:52, Paweł Zuzelski wrote: > > http://buildlogs.pld-linux.org//index.php?dist=th=x86_64=0=dhcp=e1ea81ba-b170-4cbc-b96e-79ce976fff46=tail > > > > I am at th-2018 and it builds just fine. > > > > There is also > > http://ftp.pld-linux.org/dists/th/2020/PLD/x86_64/RPMS/dhcp-4.3.5-2.x86_64.rpm , > > which suggests it also builds at th-2020. Has something broken very > > recently? > > it was built 1220 days ago: > > [/tmp] ➔ rpm -qpi dhcp-4.3.5-2.x86_64.rpm|grep Build > warning: dhcp-4.3.5-2.x86_64.rpm: Header V4 DSA/SHA1 Signature, key ID > e4f1bc2d: NOKEY > Build Date : Fri 01 Dec 2017 01:53:26 AM EET > Build Host : ymir-builder > [/tmp] ➔ I see, thanks for checking. I sent another PR on Github, with that change it builds at th-2020 (and has been working well for me for like two days now). If you'd prefer me to push directly, can someone please guide me through recovering the PLD git account? I think the last time I contributed was the CVS era, and so I've never used the PLD git. ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: pull request for dhcp – fixed the init script
On 02.04.2021 13:52, Paweł Zuzelski wrote: http://buildlogs.pld-linux.org//index.php?dist=th=x86_64=0=dhcp=e1ea81ba-b170-4cbc-b96e-79ce976fff46=tail I am at th-2018 and it builds just fine. There is also http://ftp.pld-linux.org/dists/th/2020/PLD/x86_64/RPMS/dhcp-4.3.5-2.x86_64.rpm, which suggests it also builds at th-2020. Has something broken very recently? it was built 1220 days ago: [/tmp] ➔ rpm -qpi dhcp-4.3.5-2.x86_64.rpm|grep Build warning: dhcp-4.3.5-2.x86_64.rpm: Header V4 DSA/SHA1 Signature, key ID e4f1bc2d: NOKEY Build Date : Fri 01 Dec 2017 01:53:26 AM EET Build Host : ymir-builder [/tmp] ➔ ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: pull request for dhcp – fixed the init script
On Thu, Apr 1, 2021 at 10:19 PM Jan Rękorajski wrote: > > On Thu, 01 Apr 2021, Jan Rękorajski wrote: > > > On Thu, 01 Apr 2021, Paweł Zuzelski wrote: > > > > > On Wed, Mar 31, 2021 at 6:11 PM Elan Ruusamäe wrote: > > > > On 31.03.2021 18:01, Paweł Zuzelski wrote: > > > > > Hi all, > > > > > > > > > > Could someone please review and push https://github.com/pawelz/pld-dhcp > > > > > specifically that commit: > > > > > > > > https://github.com/pawelz/pld-dhcp/commit/071ac6b61dedf115572076ad17bbbef53226b22c > > > > > ? > > > > > > > > > > This change fixes broken init for dhcp6. > > > > > > > > > > It's been 10 years since I touched PLD, so I don't really feel > > > comfortable > > > > > pushing without supervision even if I still have access to the repo. > > > > > > > > you can push to a branch > > > > > > > > you can also open a pull request in github > > > > > > Ah, thank you. I haven't realized that those repos are actually hosted on > > > github. I created a PR there. > > > > Well, github is just a mirror. I fetched and pushed your changes to PLD repo. > > > > BTW, don't worry about pushing directly, it's not irreversible. > > OTOH, how did you manage to build this antique? Some old ggc? > > http://buildlogs.pld-linux.org//index.php?dist=th=x86_64=0=dhcp=e1ea81ba-b170-4cbc-b96e-79ce976fff46=tail I am at th-2018 and it builds just fine. There is also http://ftp.pld-linux.org/dists/th/2020/PLD/x86_64/RPMS/dhcp-4.3.5-2.x86_64.rpm, which suggests it also builds at th-2020. Has something broken very recently? -- Paweł ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: pull request for dhcp – fixed the init script
On Thu, 01 Apr 2021, Jan Rękorajski wrote: > On Thu, 01 Apr 2021, Paweł Zuzelski wrote: > > > On Wed, Mar 31, 2021 at 6:11 PM Elan Ruusamäe wrote: > > > On 31.03.2021 18:01, Paweł Zuzelski wrote: > > > > Hi all, > > > > > > > > Could someone please review and push https://github.com/pawelz/pld-dhcp > > > > specifically that commit: > > > > > > https://github.com/pawelz/pld-dhcp/commit/071ac6b61dedf115572076ad17bbbef53226b22c > > > > ? > > > > > > > > This change fixes broken init for dhcp6. > > > > > > > > It's been 10 years since I touched PLD, so I don't really feel > > comfortable > > > > pushing without supervision even if I still have access to the repo. > > > > > > you can push to a branch > > > > > > you can also open a pull request in github > > > > Ah, thank you. I haven't realized that those repos are actually hosted on > > github. I created a PR there. > > Well, github is just a mirror. I fetched and pushed your changes to PLD repo. > > BTW, don't worry about pushing directly, it's not irreversible. OTOH, how did you manage to build this antique? Some old ggc? http://buildlogs.pld-linux.org//index.php?dist=th=x86_64=0=dhcp=e1ea81ba-b170-4cbc-b96e-79ce976fff46=tail -- Jan Rękorajski| PLD/Linux SysAdm | bagginspld-linux.org | http://www.pld-linux.org/ ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: pull request for dhcp – fixed the init script
On Thu, 01 Apr 2021, Paweł Zuzelski wrote: > On Wed, Mar 31, 2021 at 6:11 PM Elan Ruusamäe wrote: > > On 31.03.2021 18:01, Paweł Zuzelski wrote: > > > Hi all, > > > > > > Could someone please review and push https://github.com/pawelz/pld-dhcp > > > specifically that commit: > > > > https://github.com/pawelz/pld-dhcp/commit/071ac6b61dedf115572076ad17bbbef53226b22c > > > ? > > > > > > This change fixes broken init for dhcp6. > > > > > > It's been 10 years since I touched PLD, so I don't really feel > comfortable > > > pushing without supervision even if I still have access to the repo. > > > > you can push to a branch > > > > you can also open a pull request in github > > Ah, thank you. I haven't realized that those repos are actually hosted on > github. I created a PR there. Well, github is just a mirror. I fetched and pushed your changes to PLD repo. BTW, don't worry about pushing directly, it's not irreversible. -- Jan Rękorajski| PLD/Linux SysAdm | bagginspld-linux.org | http://www.pld-linux.org/ ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: pull request for dhcp – fixed the init script
On Wed, Mar 31, 2021 at 6:11 PM Elan Ruusamäe wrote: > On 31.03.2021 18:01, Paweł Zuzelski wrote: > > Hi all, > > > > Could someone please review and push https://github.com/pawelz/pld-dhcp > > specifically that commit: > > https://github.com/pawelz/pld-dhcp/commit/071ac6b61dedf115572076ad17bbbef53226b22c > > ? > > > > This change fixes broken init for dhcp6. > > > > It's been 10 years since I touched PLD, so I don't really feel comfortable > > pushing without supervision even if I still have access to the repo. > > you can push to a branch > > you can also open a pull request in github Ah, thank you. I haven't realized that those repos are actually hosted on github. I created a PR there. ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: pull request for dhcp – fixed the init script
On 31.03.2021 18:01, Paweł Zuzelski wrote: Hi all, Could someone please review and push https://github.com/pawelz/pld-dhcp specifically that commit: https://github.com/pawelz/pld-dhcp/commit/071ac6b61dedf115572076ad17bbbef53226b22c ? This change fixes broken init for dhcp6. It's been 10 years since I touched PLD, so I don't really feel comfortable pushing without supervision even if I still have access to the repo. you can push to a branch you can also open a pull request in github ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
