Re: [Framework-Team] Collections portlets

2012-04-09 Thread David Glick

On 4/1/12 4:04 PM, Eric Steele wrote:
So now that we've got plone.app.collection in 4.2, how do we want to handle 
collections portlets?

We currently ship with plone.portlet.collection. plone.app.collection adds its 
own, largely the same (though missing some of the more recent features/fixes 
added to the other).

Should the p.a.collection version be made the default (and updated for parity 
with p.portlet.collection) or should p.portlet.collection be updated to handle 
the newer collections (and remove the portlet functionality from 
p.a.collection)?

Seems like the latter would be the simpler option.

I made some progress toward supporting new-style collections in 
plone.portlet.collection (by adding a backward-compatible queryCatalog method 
to the collection class in plone.app.collection...really not too hard except 
for figuring out how to get non-IContentListing-wrapped results out of the 
query builder). Remaining tasks:
- The code path for when the 'random order' option is selected is currently 
broken. To fix it the BBB queryCatalog needs to accept a sort_on parameter and 
pass it through to where the query is constructed.
- The plone.portlet.collection functional test needs to be updated to create a 
new-style collection instead of a Topic.
- We need to figure out what to do with the unnecessary portlet in 
plone.app.collection. (There have been releases of plone.app.collection so it 
doesn't seem like we should just remove it. A migration will be a pain since 
it'll have to find all the portlet assignments to update them. If the 2 portlet 
assignment classes have the same attributes maybe we can use a module alias, 
but I haven't evaluated that.)



David Glick
Web Developer
davidgl...@groundwire.org
206.286.1235x32


[http://gw-logo.s3.amazonaws.com/gw-email-signature.png]


GiveBIG is coming! Mark your calendar for May 2 and get ready to give big to 
Groundwirehttp://www.seattlefoundation.org/npos/Pages/Groundwire.aspx as part 
of this community-wide day of giving.


___
Framework-Team mailing list
framework-t...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-framework-team


[Framework-Team] Collections portlets

2012-04-01 Thread Eric Steele
So now that we've got plone.app.collection in 4.2, how do we want to handle 
collections portlets? 

We currently ship with plone.portlet.collection. plone.app.collection adds its 
own, largely the same (though missing some of the more recent features/fixes 
added to the other). 

Should the p.a.collection version be made the default (and updated for parity 
with p.portlet.collection) or should p.portlet.collection be updated to handle 
the newer collections (and remove the portlet functionality from 
p.a.collection)?

Seems like the latter would be the simpler option.

Eric 

___
Framework-Team mailing list
framework-t...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-framework-team