[Plplot-devel] Bug in notcrossed() function of plfill.c

2015-06-15 Thread Phil Rosenberg
Hi All I have just been dealing with a bug where I was drawing a contour plot and my entire plot was being filled with one contour level. I have fought my way through the code and it turned out to be a perfect storm of a bug which begins with the notcrossed function returning a PL_NEAR_PARALLEL

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

2015-06-15 Thread Arjen Markus
Hi Phil, I do not remember who wrote it, I may have made some changes to it in a now distant past, but I could have a look at your fix. Regards, Arjen -Original Message- From: Phil Rosenberg [mailto:p.d.rosenb...@gmail.com] Sent: Monday, June 15, 2015 11:35 AM To:

Re: [Plplot-devel] Driver behavior questions and wingdi preview

2015-06-15 Thread Phil Rosenberg
Yeah, that seems like a good argument to me On 15 June 2015 at 03:30, Jim Dishaw j...@dishaw.org wrote: On Jun 14, 2015, at 5:28 AM, Phil Rosenberg p.d.rosenb...@gmail.com wrote: On 11 June 2015 at 17:57, Jim Dishaw j...@dishaw.org wrote: On Jun 11, 2015, at 4:06 AM, Phil Rosenberg

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

2015-06-15 Thread Phil Rosenberg
Hi Arjen I've just copied the code below as I don't just have time at the moment to sort a git patch (The plot I was making is for a presentation this afternoon!). The old code has been commented out with /* */ and my new code is directly above that from the #ifdef onwards. Basically I get that

Re: [Plplot-devel] Tcl build error

2015-06-15 Thread Phil Rosenberg
Hi Alan The I've had a look and it seems that there are two problems. I'm not sure if these are CMake version issues as much as anything else. Basically in the foreach on line 4 of concatenate_pkgIndex.tcl.cmake the filenames need quoting. However, even when this is done, my version of CMake

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

2015-06-15 Thread Maurice LeBrun
On Monday, June 15, 2015 at 11:18:33 (-0700) Alan W. Irwin writes: Hi Phil: git blame is your friend for figuring out who authored what, and it turns out I am virtually (except for a change by Hez) the sole author of notcrossed, but IIRC, that built on top of what Arjen had done before

Re: [Plplot-devel] Tcl build error

2015-06-15 Thread Alan W. Irwin
On 2015-06-15 15:34+0100 Phil Rosenberg wrote: So I can see where the lines appear to be written from the CMakeLists.txt, but I don't know how to split that block to output the individual ${index} list items. I might have to rely on you to have a look. Hi Phil: I have taken a look at this,

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

2015-06-15 Thread Alan W. Irwin
Hi Phil: git blame is your friend for figuring out who authored what, and it turns out I am virtually (except for a change by Hez) the sole author of notcrossed, but IIRC, that built on top of what Arjen had done before with (embedded logic rather than a function) which built on top of what

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

2015-06-15 Thread Phil Rosenberg
I will have to try out git blame then. I imagined that something so well embedded would predate our git usage, but I guess our svn history was brought in too. I guess you have as little idea as me then about how it is intended to work? -Original Message- From: Alan W. Irwin

Re: [Plplot-devel] Bug fix to plbuf.c

2015-06-15 Thread Jim Dishaw
And here is the wingcc patch series. I tested with cygwin and msvc and did not have the problem with multiple keypresses. The wingcc driver does seem to have a problem when the window is made small. It cuts off part of the plot. 0002-Updated-the-wingcc-driver-to-reflect-the-changes-for.patch

Re: [Plplot-devel] Bug in notcrossed() function of plfill.c

2015-06-15 Thread Alan W. Irwin
On 2015-06-15 21:07+0100 Phil Rosenberg wrote: I will have to try out git blame then. I imagined that something so well embedded would predate our git usage, but I guess our svn history was brought in too. Yes, Hazen and I were careful to preserve our history back to the start in ~1992 which in