Re: [Plplot-devel] -eofill issues with -dev wxwidgets and possible rewrite of streams and src/plargs.c

2017-10-02 Thread Phil Rosenberg
> > The eofill setting is saved by the plbuf at a bop (see line 176 and 359 in > plbuf.c). > Hi Jim - These are changes I made over the weekend. I guess you're not subscribed to get code change notifications or maybe you missed them :-) > > I have noticed some inconsistencies in the mash-up of

Re: [Plplot-devel] -eofill issues with -dev wxwidgets and possible rewrite of streams and src/plargs.c

2017-10-01 Thread Jim Dishaw
> On Sep 30, 2017, at 2:35 PM, Alan W. Irwin wrote: > > On 2017-09-30 15:06+0100 Phil Rosenberg wrote: > >> Hi Alan >> >> >> On 30 September 2017 at 07:31, Alan W. Irwin >> wrote: >>> On 2017-09-30 02:27+0100 p.d.rosenb...@gmail.com

Re: [Plplot-devel] -eofill issues with -dev wxwidgets and possible rewrite of streams and src/plargs.c

2017-10-01 Thread Phil Rosenberg
On 1 October 2017 at 21:01, Alan W. Irwin wrote: > On 2017-10-01 09:49+0100 Phil Rosenberg wrote: > > [Alan said] >>> >>> With regard to your remark concerning writing a plsfillrule() function >>> and systematically using it throughout src/plargs.c, I wouldn't want >>>

Re: [Plplot-devel] -eofill issues with -dev wxwidgets and possible rewrite of streams and src/plargs.c

2017-10-01 Thread Phil Rosenberg
Fixed My test for initialisation was incorrect. On 1 October 2017 at 20:50, Alan W. Irwin wrote: > On 2017-09-30 19:22-0700 Alan W. Irwin wrote: > >> Anyhow, thanks very much for this fix, and I have changed the status >> of https://sourceforge.net/p/plplot/bugs/174/

Re: [Plplot-devel] -eofill issues with -dev wxwidgets and possible rewrite of streams and src/plargs.c

2017-10-01 Thread Alan W. Irwin
On 2017-10-01 09:49+0100 Phil Rosenberg wrote: [Alan said] With regard to your remark concerning writing a plsfillrule() function and systematically using it throughout src/plargs.c, I wouldn't want to do that myself, but if you or Jim want to make such a change and it passes comprehensive

Re: [Plplot-devel] -eofill issues with -dev wxwidgets and possible rewrite of streams and src/plargs.c

2017-10-01 Thread Alan W. Irwin
On 2017-09-30 19:22-0700 Alan W. Irwin wrote: Anyhow, thanks very much for this fix, and I have changed the status of https://sourceforge.net/p/plplot/bugs/174/ to closed-fixed. I have just discovered a really strange problem with your recent -eofill fix (commit b603fd22). The issue is that

Re: [Plplot-devel] -eofill issues with -dev wxwidgets and possible rewrite of streams and src/plargs.c

2017-10-01 Thread Phil Rosenberg
>> Note that I have tested this up to the point of checking in the >> debugger that the correct fill rule is recognised by the viewer and >> the correct parameter is passed in to the wxWidgets fill function. >> This definitely works correctly both with and without -eofill >> specified for example

Re: [Plplot-devel] -eofill issues with -dev wxwidgets and possible rewrite of streams and src/plargs.c

2017-09-30 Thread Alan W. Irwin
On 2017-10-01 01:11+0100 Phil Rosenberg wrote: On 30 September 2017 at 19:35, Alan W. Irwin wrote: [...] By the way, other command-line options such as examples/c/x27c -dev wxwidgets -geometry 300x200 do work fine for -dev wxwidgets so the issue with the -eofill

[Plplot-devel] -eofill issues with -dev wxwidgets and possible rewrite of streams and src/plargs.c

2017-09-30 Thread Alan W. Irwin
On 2017-09-30 15:06+0100 Phil Rosenberg wrote: Hi Alan On 30 September 2017 at 07:31, Alan W. Irwin wrote: On 2017-09-30 02:27+0100 p.d.rosenb...@gmail.com wrote: I suspect this will be a bug in the render buffer, where the fill method is not correctly stored