Re: [Plplot-devel] [PATCH] Compiler warning fixes

2009-08-27 Thread Alan W. Irwin
On 2009-08-27 16:05+0200 Mark de Wever wrote: > Alan W. Irwin wrote: >> On 2009-08-26 11:12+0200 Mark de Wever wrote: >>> I also noticed with gcc -Wall there are a lot of unused variables in >>> plplot, if wanted I could provide a patch which removes those variables. >> >> Yes, please. > > Attac

Re: [Plplot-devel] [PATCH] Compiler warning fixes

2009-08-27 Thread Mark de Wever
Alan W. Irwin wrote: On 2009-08-26 11:12+0200 Mark de Wever wrote: I also noticed with gcc -Wall there are a lot of unused variables in plplot, if wanted I could provide a patch which removes those variables. Yes, please. Sorry hit the send button too soon, this time with the patch attached.

Re: [Plplot-devel] [PATCH] Compiler warning fixes

2009-08-27 Thread Mark de Wever
Alan W. Irwin wrote: > On 2009-08-26 11:12+0200 Mark de Wever wrote: >> The attached patches fix some compiler warnings: >> plargs-patch Make sure the functions return a value. >> cairo-patch Properly place parentheses, avoiding code having no effect. > > Thanks, Mark. I committed your plargs-pat

Re: [Plplot-devel] [PATCH] Compiler warning fixes

2009-08-26 Thread Alan W. Irwin
On 2009-08-26 11:12+0200 Mark de Wever wrote: > Hi, > > The attached patches fix some compiler warnings: > plargs-patch Make sure the functions return a value. > cairo-patch Properly place parentheses, avoiding code having no effect. Thanks, Mark. I committed your plargs-patch and Hazen committe