Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-07 Thread Michael Herger
I guess the following if statement only updating lastPlayed/play counts if isFile returns true is likely to cause issues ? https://github.com/erland/lms-trackstat/blob/fe583776eafce682086a0cc2731a8676b67652f6/src/Plugin.pm#L4259 Yep, isFile() would fail on remote tracks. And the following

Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-07 Thread erland
mherger wrote: > > Isn't the problem more that things like "Last Played" and "Playcount" > > are not stored in the database for online tracks? > > I think you're right! The RemoteTrack class overrides the persistent > data handling with empty stubs. I'll have to figure out how I can better >

Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-07 Thread Michael Herger
Isn't the problem more that things like "Last Played" and "Playcount" are not stored in the database for online tracks? I think you're right! The RemoteTrack class overrides the persistent data handling with empty stubs. I'll have to figure out how I can better handle this.

Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-07 Thread rlem
Hi Erland & Michael, I've been thinking about this case & am not sure if the fault really lies in Trackstat mishandling online tracks, because they are picked up perfectly in the Trackstat XML -including - ratings (as you can see in my screenshot above). Isn't the problem more that things like

Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-06 Thread Michael Herger
I noticed that the plugin code have if statements like: ref($selectedItem) eq 'Slim::Schema::Track' Yep, that's likely it. Any check assuming the file is a local track might fail. ___ plugins mailing list plugins@lists.slimdevices.com

Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-06 Thread erland
rlem wrote: > Thanks for even thinking out loud for possible solutions. > Unfortunately this is all way above my head - but if you want me to test > some stuff, please do tell! > > Best, > R Take a look at the new Ratings Light plugin. If I remember correctly it includes some integration with

Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-06 Thread rlem
Thanks for even thinking out loud for possible solutions. Unfortunately this is all way above my head - but if you want me to test some stuff, please do tell! Best, R 1x Classic / 2x Radio / 2x Receiver / LMS 8.0.0 - 1603862260 on HP Proliant N54L with Ubuntu 16.04 LTS

Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-06 Thread erland
erland wrote: > > Someone would have to check the plugin code but it wouldn’t surprise me > if it was something similar to the issue you corrected in 8.2 for > Dynamic Playlist plugin: >

Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-06 Thread erland
mherger wrote: > > There’s only 1 downside: it appears that the current > Trackstat-Dynamic > > Playlist combo can only make use of the “date added” and the > rating > > itself: > > I believe this topic has come up before: the TrackStat plugin seems to > filter URLs by the file:// prefix

Re: [SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-05 Thread Michael Herger
There’s only 1 downside: it appears that the current Trackstat-Dynamic Playlist combo can only make use of the “date added” and the rating itself: I believe this topic has come up before: the TrackStat plugin seems to filter URLs by the file:// prefix somewhere in its code. This would exclude

[SlimDevices: Plugins] Trackstat statistics and Spotty content

2021-04-05 Thread rlem
Hi, First of all I want to profess how extremely happy our family is with the Squeezebox ecosystem (after all these years). And the satisfaction has even grown now that Spotty is so well integrated into the LMS library; it’s wonderful to have local and Spotify albums available and searchable in