[jira] [Commented] (PLUTO-781) PortletRequestDispatcherImpl forwards to incorrect path

2019-09-11 Thread Neil Griffin (Jira)


[ 
https://issues.apache.org/jira/browse/PLUTO-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927883#comment-16927883
 ] 

Neil Griffin commented on PLUTO-781:


[~riverbed2]: Thanks for pointing out the parts of the Portlet 3.0 
Specification that pertain to this issue. I'll be happy to review that more 
closely after knowing the results of testing the 
com.liferay.portletmvc4spring.demo.applicant.jsp.portlet-5.1.0.war artifact in 
your Pluto environment. We tested the PortletMVC4Spring release in both Liferay 
7.x and Pluto 3.1.0.

> PortletRequestDispatcherImpl forwards to incorrect path
> ---
>
> Key: PLUTO-781
> URL: https://issues.apache.org/jira/browse/PLUTO-781
> Project: Pluto
>  Issue Type: Bug
>  Components: portlet container
>Affects Versions: 3.0.1
> Environment: Pluto Container 3.0.1, Spring 4.0.9.RELEASE, Wildfly 
> 14.0.1
>Reporter: Steve Potter
>Assignee: Neil Griffin
>Priority: Major
> Attachments: pluto-debug.txt, test-portlet.zip
>
>
> When a serveResource method forwards to a servlet which then forwards to a 
> jsp, theĀ  HttpServletPortletRequestWrapper provides the path from the first 
> forward rather than the second forward and the jsp is not rendered.
> This is the process used by Spring Portlet MVC to locate JSP 'views' 
> resulting in the failure of all our portlets when trying to serve JSP's in 
> response to resource requests.
> The attached file contains a DEBUG log of the processing flow attempting to 
> serve '/WEB-INF/jsp/resource2.jsp' in response to a resource request.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (PLUTO-781) PortletRequestDispatcherImpl forwards to incorrect path

2019-09-11 Thread Steve Potter (Jira)


[ 
https://issues.apache.org/jira/browse/PLUTO-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927879#comment-16927879
 ] 

Steve Potter commented on PLUTO-781:


We have not tried to run our Spring Portlet MVC based portlets in Pluto before. 
They have however worked in Liferay in the past. In Pluto the portlets deploy 
fine, they just don't render the expected JSP's in response to resource 
requests.

As we are using Spring Portlet MVC, I don't think we have any real control over 
the method used to dispatch to the request handler and subsequently to the 
view. The reason we are interested in forward is that we want the ability to 
control response header fields.

I am struggling to interpret clearly Chapter 25 of the Portlet 3 spec. However, 
bits that I think are relevant are:

- 25.5 para 5 - 'When using a RequestDispatcher in a servlet that was target of 
a forward from a portlet,..'. This seems to imply that the approach is 
generally supported.

- The table in 25.9.2 has N/A has for the invocation of 
HttpServletRequest.getRequestDispatcher and according to footnote 28 'N/A 
indicates that such a method is not available in the portlet interface and the 
functionality defined by the Servlet Specification must be provided for this 
method.'

My opinion is that the current behaviour in Pluto is not consistent with this. 
On a practical level it seems wrong to me that a RequestDispatcher should 
silently refuse to forward to a requested path and instead forward to a 
different path. If forward is really not valid in this flow it would be better 
to throw an exception.

> PortletRequestDispatcherImpl forwards to incorrect path
> ---
>
> Key: PLUTO-781
> URL: https://issues.apache.org/jira/browse/PLUTO-781
> Project: Pluto
>  Issue Type: Bug
>  Components: portlet container
>Affects Versions: 3.0.1
> Environment: Pluto Container 3.0.1, Spring 4.0.9.RELEASE, Wildfly 
> 14.0.1
>Reporter: Steve Potter
>Assignee: Neil Griffin
>Priority: Major
> Attachments: pluto-debug.txt, test-portlet.zip
>
>
> When a serveResource method forwards to a servlet which then forwards to a 
> jsp, theĀ  HttpServletPortletRequestWrapper provides the path from the first 
> forward rather than the second forward and the jsp is not rendered.
> This is the process used by Spring Portlet MVC to locate JSP 'views' 
> resulting in the failure of all our portlets when trying to serve JSP's in 
> response to resource requests.
> The attached file contains a DEBUG log of the processing flow attempting to 
> serve '/WEB-INF/jsp/resource2.jsp' in response to a resource request.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)