[jira] [Closed] (PLUTO-774) Freeze the portlet-api dependency version at 3.0.1

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-774.
--
Resolution: Fixed

> Freeze the portlet-api dependency version at 3.0.1
> --
>
> Key: PLUTO-774
> URL: https://issues.apache.org/jira/browse/PLUTO-774
> Project: Pluto
>  Issue Type: Task
>  Components: portal driver, portlet container
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> Currently the {{}} section of the parent-most pom.xml 
> descriptor looks like the following:
> {code:xml|title=pom.xml}
> 
>javax.portlet
>portlet-api
>${project.version}
>provided
> 
> {code}
> The {{$\{project.version\}}} expression implies that the latest snapshot 
> version of the portlet-api artifact will be used as a compile-time dependency 
> throughout the entire project, and also that it will be released every time 
> there is a release of the Pluto reference implementation. Unless a defect is 
> found, the portlet-api dependency does not need to be released until the next 
> version of the Portlet Specification is released, presumably version 3.1.0.
> Therefore the dependency version should be set to the following, which 
> reflects the latest released version of the portlet-api artifact at the time 
> of this writing:
> {code:xml|title=pom.xml}
> 
>javax.portlet
>portlet-api
>3.0.1
>provided
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (PLUTO-774) Freeze the portlet-api dependency version at 3.0.1

2019-04-10 Thread Neil Griffin (JIRA)


[ 
https://issues.apache.org/jira/browse/PLUTO-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813949#comment-16813949
 ] 

Neil Griffin edited comment on PLUTO-774 at 4/10/19 10:26 PM:
--

Fixed in commits 
[5df8df4f2481caadc734d05bbae33efb446fdbad|https://github.com/apache/portals-pluto/commit/5df8df4f2481caadc734d05bbae33efb446fdbad]
 and 
[0ea013026e9189ddf26d6c4db28743b016418194|https://github.com/apache/portals-pluto/commit/0ea013026e9189ddf26d6c4db28743b016418194].


was (Author: ngriffin7a):
Fixed in commit 
[5df8df4f2481caadc734d05bbae33efb446fdbad|https://github.com/apache/portals-pluto/commit/5df8df4f2481caadc734d05bbae33efb446fdbad]

> Freeze the portlet-api dependency version at 3.0.1
> --
>
> Key: PLUTO-774
> URL: https://issues.apache.org/jira/browse/PLUTO-774
> Project: Pluto
>  Issue Type: Task
>  Components: portal driver, portlet container
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> Currently the {{}} section of the parent-most pom.xml 
> descriptor looks like the following:
> {code:xml|title=pom.xml}
> 
>javax.portlet
>portlet-api
>${project.version}
>provided
> 
> {code}
> The {{$\{project.version\}}} expression implies that the latest snapshot 
> version of the portlet-api artifact will be used as a compile-time dependency 
> throughout the entire project, and also that it will be released every time 
> there is a release of the Pluto reference implementation. Unless a defect is 
> found, the portlet-api dependency does not need to be released until the next 
> version of the Portlet Specification is released, presumably version 3.1.0.
> Therefore the dependency version should be set to the following, which 
> reflects the latest released version of the portlet-api artifact at the time 
> of this writing:
> {code:xml|title=pom.xml}
> 
>javax.portlet
>portlet-api
>3.0.1
>provided
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-774) Freeze the portlet-api dependency version at 3.0.1

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-774:


> Freeze the portlet-api dependency version at 3.0.1
> --
>
> Key: PLUTO-774
> URL: https://issues.apache.org/jira/browse/PLUTO-774
> Project: Pluto
>  Issue Type: Task
>  Components: portal driver, portlet container
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> Currently the {{}} section of the parent-most pom.xml 
> descriptor looks like the following:
> {code:xml|title=pom.xml}
> 
>javax.portlet
>portlet-api
>${project.version}
>provided
> 
> {code}
> The {{$\{project.version\}}} expression implies that the latest snapshot 
> version of the portlet-api artifact will be used as a compile-time dependency 
> throughout the entire project, and also that it will be released every time 
> there is a release of the Pluto reference implementation. Unless a defect is 
> found, the portlet-api dependency does not need to be released until the next 
> version of the Portlet Specification is released, presumably version 3.1.0.
> Therefore the dependency version should be set to the following, which 
> reflects the latest released version of the portlet-api artifact at the time 
> of this writing:
> {code:xml|title=pom.xml}
> 
>javax.portlet
>portlet-api
>3.0.1
>provided
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-714) AnnotationPortletArtifactValidityTests redundantly specify the @PortletApplication annotation 4 times

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-714.
--
Resolution: Fixed

> AnnotationPortletArtifactValidityTests redundantly specify the 
> @PortletApplication annotation 4 times
> -
>
> Key: PLUTO-714
> URL: https://issues.apache.org/jira/browse/PLUTO-714
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> The following classes in AnnotationPortletArtifactValidityTests redundantly 
> specify the {{@PortletApplication}} annotation. According to the Portlet 3.0 
> Specification, it may only appear once:
> - AnnotationPortletArtifactValidityTests_SPEC3_20_ParameterArtifacts
> - AnnotationPortletArtifactValidityTests_SPEC3_20_PortletArtifacts
> - AnnotationPortletArtifactValidityTests_SPEC3_20_RequestArtifacts
> - AnnotationPortletArtifactValidityTests_SPEC3_20_ResponseArtifacts



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-724) V3AnnotationPortletAppConfigOverrideTests portlet.xml descriptor does not validate against the portlet-app_3_0.xsd schema

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-724:


> V3AnnotationPortletAppConfigOverrideTests portlet.xml descriptor does not 
> validate against the portlet-app_3_0.xsd schema
> -
>
> Key: PLUTO-724
> URL: https://issues.apache.org/jira/browse/PLUTO-724
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> The V3AnnotationPortletAppConfigOverrideTests portlet.xml descriptor does not 
> validate against the 
> [portlet-app_3_0.xsd|http://xmlns.jcp.org/xml/ns/portlet/portlet-app_3_0.xsd] 
> descriptor because some elements are out-of-order according to the XML schema.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-720) Upgrade liferay-portlet.xml descriptors in the TCK from the 7.0.0 DTD to 7.1.0

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-720:


> Upgrade liferay-portlet.xml descriptors in the TCK from the 7.0.0 DTD to 7.1.0
> --
>
> Key: PLUTO-720
> URL: https://issues.apache.org/jira/browse/PLUTO-720
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> This task involves making the following change in the liferay-portlet.xml 
> descriptors in the TCK:
> Change:
> {code:xml|title=liferay-portlet.xml}
>  7.0.0//EN" "http://www.liferay.com/dtd/liferay-portlet-app_7_0_0.dtd;>
> {code}
> to:
> {code:xml|title=liferay-portlet.xml}
>  7.1.0//EN" "http://www.liferay.com/dtd/liferay-portlet-app_7_1_0.dtd;>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-726) The pluto profile in the V3AnnotationPortletAppConfigOverrideTests pom.xml descriptor does not ignore Liferay-specific files

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-726.
--
Resolution: Fixed

> The pluto profile in the V3AnnotationPortletAppConfigOverrideTests pom.xml 
> descriptor does not ignore Liferay-specific files
> 
>
> Key: PLUTO-726
> URL: https://issues.apache.org/jira/browse/PLUTO-726
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> The pluto profile in the V3AnnotationPortletAppConfigOverrideTests pom.xml 
> descriptor does not ignore Liferay-specific files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-724) V3AnnotationPortletAppConfigOverrideTests portlet.xml descriptor does not validate against the portlet-app_3_0.xsd schema

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-724.
--
Resolution: Fixed

> V3AnnotationPortletAppConfigOverrideTests portlet.xml descriptor does not 
> validate against the portlet-app_3_0.xsd schema
> -
>
> Key: PLUTO-724
> URL: https://issues.apache.org/jira/browse/PLUTO-724
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> The V3AnnotationPortletAppConfigOverrideTests portlet.xml descriptor does not 
> validate against the 
> [portlet-app_3_0.xsd|http://xmlns.jcp.org/xml/ns/portlet/portlet-app_3_0.xsd] 
> descriptor because some elements are out-of-order according to the XML schema.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-726) The pluto profile in the V3AnnotationPortletAppConfigOverrideTests pom.xml descriptor does not ignore Liferay-specific files

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-726:


> The pluto profile in the V3AnnotationPortletAppConfigOverrideTests pom.xml 
> descriptor does not ignore Liferay-specific files
> 
>
> Key: PLUTO-726
> URL: https://issues.apache.org/jira/browse/PLUTO-726
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> The pluto profile in the V3AnnotationPortletAppConfigOverrideTests pom.xml 
> descriptor does not ignore Liferay-specific files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-724) V3AnnotationPortletAppConfigOverrideTests portlet.xml descriptor does not validate against the portlet-app_3_0.xsd schema

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-724:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> V3AnnotationPortletAppConfigOverrideTests portlet.xml descriptor does not 
> validate against the portlet-app_3_0.xsd schema
> -
>
> Key: PLUTO-724
> URL: https://issues.apache.org/jira/browse/PLUTO-724
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> The V3AnnotationPortletAppConfigOverrideTests portlet.xml descriptor does not 
> validate against the 
> [portlet-app_3_0.xsd|http://xmlns.jcp.org/xml/ns/portlet/portlet-app_3_0.xsd] 
> descriptor because some elements are out-of-order according to the XML schema.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-722) TCK HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1 fails in Liferay Portal due to missing header-request-attribute-prefix in liferay-portlet.xml

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-722:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> TCK HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1 fails in Liferay 
> Portal due to missing header-request-attribute-prefix in liferay-portlet.xml
> -
>
> Key: PLUTO-722
> URL: https://issues.apache.org/jira/browse/PLUTO-722
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Liferay Portal contains a performance optimization such that request 
> attributes from the HEADER_PHASE are not automatically copied to the 
> RENDER_PHASE. The following option is required in liferay-portlet.xml in 
> order to disable the optimization:
> {code:xml|title=liferay-portlet.xml}
> 
>   
> HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1
>   
> trAttr1
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-722) TCK HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1 fails in Liferay Portal due to missing header-request-attribute-prefix in liferay-portlet.xml

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-722.
--
Resolution: Fixed

> TCK HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1 fails in Liferay 
> Portal due to missing header-request-attribute-prefix in liferay-portlet.xml
> -
>
> Key: PLUTO-722
> URL: https://issues.apache.org/jira/browse/PLUTO-722
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Liferay Portal contains a performance optimization such that request 
> attributes from the HEADER_PHASE are not automatically copied to the 
> RENDER_PHASE. The following option is required in liferay-portlet.xml in 
> order to disable the optimization:
> {code:xml|title=liferay-portlet.xml}
> 
>   
> HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1
>   
> trAttr1
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-726) The pluto profile in the V3AnnotationPortletAppConfigOverrideTests pom.xml descriptor does not ignore Liferay-specific files

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-726:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> The pluto profile in the V3AnnotationPortletAppConfigOverrideTests pom.xml 
> descriptor does not ignore Liferay-specific files
> 
>
> Key: PLUTO-726
> URL: https://issues.apache.org/jira/browse/PLUTO-726
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> The pluto profile in the V3AnnotationPortletAppConfigOverrideTests pom.xml 
> descriptor does not ignore Liferay-specific files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-722) TCK HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1 fails in Liferay Portal due to missing header-request-attribute-prefix in liferay-portlet.xml

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-722:


> TCK HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1 fails in Liferay 
> Portal due to missing header-request-attribute-prefix in liferay-portlet.xml
> -
>
> Key: PLUTO-722
> URL: https://issues.apache.org/jira/browse/PLUTO-722
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> Liferay Portal contains a performance optimization such that request 
> attributes from the HEADER_PHASE are not automatically copied to the 
> RENDER_PHASE. The following option is required in liferay-portlet.xml in 
> order to disable the optimization:
> {code:xml|title=liferay-portlet.xml}
> 
>   
> HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1
>   
> trAttr1
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-729) TCK: Contesting usage of upper-case portlet modes and window states in Portlet Hub tests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-729:


> TCK: Contesting usage of upper-case portlet modes and window states in 
> Portlet Hub tests
> 
>
> Key: PLUTO-729
> URL: https://issues.apache.org/jira/browse/PLUTO-729
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> This issue challenges the usage of *upper case* portlet modes and window 
> states in Portlet Hub tests.
> The [JSDoc for the Portlet Hub 
> setPortletMode|https://github.com/apache/portals-pluto/blob/master/portlet-api/src/main/javascript/portlet.js#L66-L67]
>  function states:
> {quote}The strings defined by the {@link PortletConstants} object should be 
> used to specify the portlet mode.{quote}
> In addition, the [JSDoc for the Portlet Hub setWindowState 
> function|https://github.com/apache/portals-pluto/blob/master/portlet-api/src/main/javascript/portlet.js#L71]
>  states:
> {quote} The strings defined by the {@link PortletConstants} object should be 
> used to specify the window state.{quote}
> The [portlet constants are defined in the 
> JSDoc|https://github.com/apache/portals-pluto/blob/master/portlet-api/src/main/javascript/portlet.js#L88-L93]
>  with *lower case* values:
> {code:javascript|title=portlet.js}
>  * @property   {string}   VIEWSpecifies portlet mode 'view'
>  * @property   {string}   EDITSpecifies portlet mode 'edit'
>  * @property   {string}   HELPSpecifies portlet mode 'help'
>  * @property   {string}   NORMAL  Specifies window state 'normal'
>  * @property   {string}   MINIMIZED   Specifies window state 'minimized'
>  * @property   {string}   MAXIMIZED   Specifies window state 'maximized'
> {code}
> However, certain Portlet Hub related TCK tests are using an *upper case* 
> value. For example, 
> [V3PortletHubTests_SPEC_23_JSState_clone3|https://github.com/apache/portals-pluto/blob/master/portlet-tck_3.0/V3PortletHubTests/src/main/webapp/javascript/PortletHubTests_SPEC_23_JSState.js#L262-L263]
>  has:
> {code:javascript}
> state.setPortletMode('VIEW');
> state.setWindowState('NORMAL');
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-728) TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-728.
--
Resolution: Fixed

> TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests
> --
>
> Key: PLUTO-728
> URL: https://issues.apache.org/jira/browse/PLUTO-728
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This issue contests the usage of {{PortletSession}} attributes in 
> V3HeaderPortletTests.
> The results of V3HeaderPortletTests executed in the {{HEADER_PHASE}} are 
> stored in the {{PortletSession}} so that they can be written to the response 
> in the subsequent {{RENDER_PHASE}}.
> However, after PLUTO-727 was fixed, most of the V3HeaderPortletTests failed. 
> This is because test case 
> [V3HeaderPortletTests_SPEC14_PortletRequest_ApiHeader_isRequestedSessionIdValid2
>  calls 
> PortletSession.invalidate()|https://github.com/apache/portals-pluto/blob/pluto-3.0.1/portlet-tck_3.0/V3HeaderPortletTests/src/main/java/javax/portlet/tck/portlets/HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1.java#L559]
>  which in turn causes all of the {{PortletSession}} attributes to be cleared.
> The proposed fix is to store the results of V3HeaderPortletTests executed in 
> the {{HEADER_PHASE}} as {{HeaderRequest}} attributes, rather than 
> {{PortletSession}} attributes. This will provide a more natural way for such 
> information to survive from the {{HEADER_PHASE}} into the {{RENDER_PHASE}} 
> since {{HeaderRequest}} attributes are preserved as {{RenderRequest}} 
> attributes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-728) TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-728:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests
> --
>
> Key: PLUTO-728
> URL: https://issues.apache.org/jira/browse/PLUTO-728
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This issue contests the usage of {{PortletSession}} attributes in 
> V3HeaderPortletTests.
> The results of V3HeaderPortletTests executed in the {{HEADER_PHASE}} are 
> stored in the {{PortletSession}} so that they can be written to the response 
> in the subsequent {{RENDER_PHASE}}.
> However, after PLUTO-727 was fixed, most of the V3HeaderPortletTests failed. 
> This is because test case 
> [V3HeaderPortletTests_SPEC14_PortletRequest_ApiHeader_isRequestedSessionIdValid2
>  calls 
> PortletSession.invalidate()|https://github.com/apache/portals-pluto/blob/pluto-3.0.1/portlet-tck_3.0/V3HeaderPortletTests/src/main/java/javax/portlet/tck/portlets/HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1.java#L559]
>  which in turn causes all of the {{PortletSession}} attributes to be cleared.
> The proposed fix is to store the results of V3HeaderPortletTests executed in 
> the {{HEADER_PHASE}} as {{HeaderRequest}} attributes, rather than 
> {{PortletSession}} attributes. This will provide a more natural way for such 
> information to survive from the {{HEADER_PHASE}} into the {{RENDER_PHASE}} 
> since {{HeaderRequest}} attributes are preserved as {{RenderRequest}} 
> attributes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-728) TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-728:


> TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests
> --
>
> Key: PLUTO-728
> URL: https://issues.apache.org/jira/browse/PLUTO-728
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> This issue contests the usage of {{PortletSession}} attributes in 
> V3HeaderPortletTests.
> The results of V3HeaderPortletTests executed in the {{HEADER_PHASE}} are 
> stored in the {{PortletSession}} so that they can be written to the response 
> in the subsequent {{RENDER_PHASE}}.
> However, after PLUTO-727 was fixed, most of the V3HeaderPortletTests failed. 
> This is because test case 
> [V3HeaderPortletTests_SPEC14_PortletRequest_ApiHeader_isRequestedSessionIdValid2
>  calls 
> PortletSession.invalidate()|https://github.com/apache/portals-pluto/blob/pluto-3.0.1/portlet-tck_3.0/V3HeaderPortletTests/src/main/java/javax/portlet/tck/portlets/HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1.java#L559]
>  which in turn causes all of the {{PortletSession}} attributes to be cleared.
> The proposed fix is to store the results of V3HeaderPortletTests executed in 
> the {{HEADER_PHASE}} as {{HeaderRequest}} attributes, rather than 
> {{PortletSession}} attributes. This will provide a more natural way for such 
> information to survive from the {{HEADER_PHASE}} into the {{RENDER_PHASE}} 
> since {{HeaderRequest}} attributes are preserved as {{RenderRequest}} 
> attributes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-729) TCK: Contesting usage of upper-case portlet modes and window states in Portlet Hub tests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-729.
--
Resolution: Fixed

> TCK: Contesting usage of upper-case portlet modes and window states in 
> Portlet Hub tests
> 
>
> Key: PLUTO-729
> URL: https://issues.apache.org/jira/browse/PLUTO-729
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This issue challenges the usage of *upper case* portlet modes and window 
> states in Portlet Hub tests.
> The [JSDoc for the Portlet Hub 
> setPortletMode|https://github.com/apache/portals-pluto/blob/master/portlet-api/src/main/javascript/portlet.js#L66-L67]
>  function states:
> {quote}The strings defined by the {@link PortletConstants} object should be 
> used to specify the portlet mode.{quote}
> In addition, the [JSDoc for the Portlet Hub setWindowState 
> function|https://github.com/apache/portals-pluto/blob/master/portlet-api/src/main/javascript/portlet.js#L71]
>  states:
> {quote} The strings defined by the {@link PortletConstants} object should be 
> used to specify the window state.{quote}
> The [portlet constants are defined in the 
> JSDoc|https://github.com/apache/portals-pluto/blob/master/portlet-api/src/main/javascript/portlet.js#L88-L93]
>  with *lower case* values:
> {code:javascript|title=portlet.js}
>  * @property   {string}   VIEWSpecifies portlet mode 'view'
>  * @property   {string}   EDITSpecifies portlet mode 'edit'
>  * @property   {string}   HELPSpecifies portlet mode 'help'
>  * @property   {string}   NORMAL  Specifies window state 'normal'
>  * @property   {string}   MINIMIZED   Specifies window state 'minimized'
>  * @property   {string}   MAXIMIZED   Specifies window state 'maximized'
> {code}
> However, certain Portlet Hub related TCK tests are using an *upper case* 
> value. For example, 
> [V3PortletHubTests_SPEC_23_JSState_clone3|https://github.com/apache/portals-pluto/blob/master/portlet-tck_3.0/V3PortletHubTests/src/main/webapp/javascript/PortletHubTests_SPEC_23_JSState.js#L262-L263]
>  has:
> {code:javascript}
> state.setPortletMode('VIEW');
> state.setWindowState('NORMAL');
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-731) TCK: Contesting usage of PortletRequest.getProperty("Referer") in V3RenderStateTests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-731:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> TCK: Contesting usage of PortletRequest.getProperty("Referer") in 
> V3RenderStateTests
> 
>
> Key: PLUTO-731
> URL: https://issues.apache.org/jira/browse/PLUTO-731
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> The TCK test case for 
> V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode5 looks like the 
> following:
> {code:java|title=RenderStateTests_SPEC2_12_MutableRenderState.java}
> /*
>  * TestCase:
>  * V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode5
>  */
> /*
>  * Details:
>  * "Throws IllegalStateException if the method is invoked after sendRedirect 
> has been called."
>  */
> TestResult result = tcd.getTestResultFailed(
>   V3RENDERSTATETESTS_SPEC2_12_MUTABLERENDERSTATE_SETPORTLETMODE5);
> try {
>String referer = portletReq.getProperty("Referer");
>portletResp.sendRedirect(referer);
>portletResp.setPortletMode(PortletMode.UNDEFINED);
> } catch (IllegalStateException e) {
>result.setTcSuccess(true);
>result.appendTcDetail(e.toString());
> }
> result.writeTo(writer);
> {code}
> This issue is contesting usage of {{PortletRequest.getProperty("Referer")}} 
> since the test anticipates a {{RenderURL}} for redirection. When the TCK runs 
> in an automated fashion, 
> V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode4 precedes 
> V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode5. Since Apache 
> Pluto implements the post-redirect-get design pattern, the "Referer" is a 
> RenderURL. Liferay Portal does not implement post-redirect-get by default, 
> and the "Referer" is an ActionURL.
> A more appropriate URL to use for redirection is the new Portlet 3.0 
> {{ActionResponse.createRedirectURL(MimeResponse.Copy)}} method.
> V3RenderStateTests_SPEC2_12_MutableRenderState_setWindowState5 has the same 
> issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-730) Selenium WebDriverException thrown by TCKSimpleTestDriver

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-730:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> Selenium WebDriverException thrown by TCKSimpleTestDriver
> -
>
> Key: PLUTO-730
> URL: https://issues.apache.org/jira/browse/PLUTO-730
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Under certain circumstances such as a very fast CPU or a large display size, 
> Selenium throws a WebDriverException similar to the following:
> {noformat}
> Exception: org.openqa.selenium.WebDriverException: unknown error: Element
>type="submit"
>   value="V3HeaderPortletTests_SPEC15_Header_parameters6" name="inputval"
>   id="V3HeaderPortletTests_SPEC15_Header_parameters6-clickme">
> is not clickable at point (866, 930). Other element would receive
> the click: ...
> {noformat}
> The workaround is to put the following Java code just before web driver 
> button clicks:
> {code:java}
> JavascriptExecutor javascriptExecutor = (JavascriptExecutor) webDriver;
> javascriptExecutor.executeScript("window.scrollTo(0, 
> (arguments[0].getBoundingClientRect().top + window.pageYOffset) - 
> (window.innerHeight / 2));", webElement);
> {code}
> To enable the workaround, specify {{-Dtest.scroll=true}} on the command line. 
> For example:
> {code}
> mvn test -Prun-tck -Dtest.scroll=true
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-731) TCK: Contesting usage of PortletRequest.getProperty("Referer") in V3RenderStateTests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-731.
--
Resolution: Fixed

> TCK: Contesting usage of PortletRequest.getProperty("Referer") in 
> V3RenderStateTests
> 
>
> Key: PLUTO-731
> URL: https://issues.apache.org/jira/browse/PLUTO-731
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> The TCK test case for 
> V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode5 looks like the 
> following:
> {code:java|title=RenderStateTests_SPEC2_12_MutableRenderState.java}
> /*
>  * TestCase:
>  * V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode5
>  */
> /*
>  * Details:
>  * "Throws IllegalStateException if the method is invoked after sendRedirect 
> has been called."
>  */
> TestResult result = tcd.getTestResultFailed(
>   V3RENDERSTATETESTS_SPEC2_12_MUTABLERENDERSTATE_SETPORTLETMODE5);
> try {
>String referer = portletReq.getProperty("Referer");
>portletResp.sendRedirect(referer);
>portletResp.setPortletMode(PortletMode.UNDEFINED);
> } catch (IllegalStateException e) {
>result.setTcSuccess(true);
>result.appendTcDetail(e.toString());
> }
> result.writeTo(writer);
> {code}
> This issue is contesting usage of {{PortletRequest.getProperty("Referer")}} 
> since the test anticipates a {{RenderURL}} for redirection. When the TCK runs 
> in an automated fashion, 
> V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode4 precedes 
> V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode5. Since Apache 
> Pluto implements the post-redirect-get design pattern, the "Referer" is a 
> RenderURL. Liferay Portal does not implement post-redirect-get by default, 
> and the "Referer" is an ActionURL.
> A more appropriate URL to use for redirection is the new Portlet 3.0 
> {{ActionResponse.createRedirectURL(MimeResponse.Copy)}} method.
> V3RenderStateTests_SPEC2_12_MutableRenderState_setWindowState5 has the same 
> issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-730) Selenium WebDriverException thrown by TCKSimpleTestDriver

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-730:


> Selenium WebDriverException thrown by TCKSimpleTestDriver
> -
>
> Key: PLUTO-730
> URL: https://issues.apache.org/jira/browse/PLUTO-730
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> Under certain circumstances such as a very fast CPU or a large display size, 
> Selenium throws a WebDriverException similar to the following:
> {noformat}
> Exception: org.openqa.selenium.WebDriverException: unknown error: Element
>type="submit"
>   value="V3HeaderPortletTests_SPEC15_Header_parameters6" name="inputval"
>   id="V3HeaderPortletTests_SPEC15_Header_parameters6-clickme">
> is not clickable at point (866, 930). Other element would receive
> the click: ...
> {noformat}
> The workaround is to put the following Java code just before web driver 
> button clicks:
> {code:java}
> JavascriptExecutor javascriptExecutor = (JavascriptExecutor) webDriver;
> javascriptExecutor.executeScript("window.scrollTo(0, 
> (arguments[0].getBoundingClientRect().top + window.pageYOffset) - 
> (window.innerHeight / 2));", webElement);
> {code}
> To enable the workaround, specify {{-Dtest.scroll=true}} on the command line. 
> For example:
> {code}
> mvn test -Prun-tck -Dtest.scroll=true
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-736) Missing configuration in liferay-portlet.xml for AnnotationPortletAppConfigOverrideTests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-736.
--
Resolution: Fixed

> Missing configuration in liferay-portlet.xml for 
> AnnotationPortletAppConfigOverrideTests
> 
>
> Key: PLUTO-736
> URL: https://issues.apache.org/jira/browse/PLUTO-736
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> The liferay-portlet.xml descriptor for 
> AnnotationPortletAppConfigOverrideTests in the TCK is missing configuration 
> for some of the portlets defined via the `@PortletConfiguration` annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-734) TCK: Contesting AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-734:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> TCK: Contesting 
> AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions
> ---
>
> Key: PLUTO-734
> URL: https://issues.apache.org/jira/browse/PLUTO-734
> Project: Pluto
>  Issue Type: Test
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Similar to PLUTO-715, 
> AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions
>  assumes that all implementations of Portlet 3.0 will support the following 
> runtime options:
> {code:java|title= 
> AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions.java}
>  if(runtimeOptions.containsKey("javax.portlet.escapeXml") 
>&& 
> runtimeOptions.containsKey("javax.portlet.actionScopedRequestAttributes")
>&& 
> runtimeOptions.get("javax.portlet.escapeXml")[0].equals("true")
>&& 
> runtimeOptions.get("javax.portlet.actionScopedRequestAttributes")[0].equals("true")){
> result.setTcSuccess(true);
>  }
> {code}
> The problem is that the {{javax.portlet.actionScopedRequestAttributes}} 
> container-runtime-option is optional.
> Similar to the solution for fixing PLUTO-715, this issue serves as a task for 
> introducing "pluto" and "liferay" maven profiles that account for the 
> differences.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-735) Update the liferay maven profile for the V3 demos and TCK tests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-735:


> Update the liferay maven profile for the V3 demos and TCK tests
> ---
>
> Key: PLUTO-735
> URL: https://issues.apache.org/jira/browse/PLUTO-735
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> This issue encompasses various small tasks related {{liferay}} Maven 
> profiles in the V3 demos and TCK tests.
> For example:
> - The Liferay implementation of the CDI portable extension is no longer 
> required to be included in WEB-INF/lib.
> - Similar to PLUTO-662, a Liferay-specific Maven profile needs to be added to 
> the V3ResourceAsyncTests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-734) TCK: Contesting AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-734.
--
Resolution: Fixed

> TCK: Contesting 
> AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions
> ---
>
> Key: PLUTO-734
> URL: https://issues.apache.org/jira/browse/PLUTO-734
> Project: Pluto
>  Issue Type: Test
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Similar to PLUTO-715, 
> AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions
>  assumes that all implementations of Portlet 3.0 will support the following 
> runtime options:
> {code:java|title= 
> AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions.java}
>  if(runtimeOptions.containsKey("javax.portlet.escapeXml") 
>&& 
> runtimeOptions.containsKey("javax.portlet.actionScopedRequestAttributes")
>&& 
> runtimeOptions.get("javax.portlet.escapeXml")[0].equals("true")
>&& 
> runtimeOptions.get("javax.portlet.actionScopedRequestAttributes")[0].equals("true")){
> result.setTcSuccess(true);
>  }
> {code}
> The problem is that the {{javax.portlet.actionScopedRequestAttributes}} 
> container-runtime-option is optional.
> Similar to the solution for fixing PLUTO-715, this issue serves as a task for 
> introducing "pluto" and "liferay" maven profiles that account for the 
> differences.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-731) TCK: Contesting usage of PortletRequest.getProperty("Referer") in V3RenderStateTests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-731:


> TCK: Contesting usage of PortletRequest.getProperty("Referer") in 
> V3RenderStateTests
> 
>
> Key: PLUTO-731
> URL: https://issues.apache.org/jira/browse/PLUTO-731
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> The TCK test case for 
> V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode5 looks like the 
> following:
> {code:java|title=RenderStateTests_SPEC2_12_MutableRenderState.java}
> /*
>  * TestCase:
>  * V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode5
>  */
> /*
>  * Details:
>  * "Throws IllegalStateException if the method is invoked after sendRedirect 
> has been called."
>  */
> TestResult result = tcd.getTestResultFailed(
>   V3RENDERSTATETESTS_SPEC2_12_MUTABLERENDERSTATE_SETPORTLETMODE5);
> try {
>String referer = portletReq.getProperty("Referer");
>portletResp.sendRedirect(referer);
>portletResp.setPortletMode(PortletMode.UNDEFINED);
> } catch (IllegalStateException e) {
>result.setTcSuccess(true);
>result.appendTcDetail(e.toString());
> }
> result.writeTo(writer);
> {code}
> This issue is contesting usage of {{PortletRequest.getProperty("Referer")}} 
> since the test anticipates a {{RenderURL}} for redirection. When the TCK runs 
> in an automated fashion, 
> V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode4 precedes 
> V3RenderStateTests_SPEC2_12_MutableRenderState_setPortletMode5. Since Apache 
> Pluto implements the post-redirect-get design pattern, the "Referer" is a 
> RenderURL. Liferay Portal does not implement post-redirect-get by default, 
> and the "Referer" is an ActionURL.
> A more appropriate URL to use for redirection is the new Portlet 3.0 
> {{ActionResponse.createRedirectURL(MimeResponse.Copy)}} method.
> V3RenderStateTests_SPEC2_12_MutableRenderState_setWindowState5 has the same 
> issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-734) TCK: Contesting AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-734:


> TCK: Contesting 
> AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions
> ---
>
> Key: PLUTO-734
> URL: https://issues.apache.org/jira/browse/PLUTO-734
> Project: Pluto
>  Issue Type: Test
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> Similar to PLUTO-715, 
> AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions
>  assumes that all implementations of Portlet 3.0 will support the following 
> runtime options:
> {code:java|title= 
> AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions.java}
>  if(runtimeOptions.containsKey("javax.portlet.escapeXml") 
>&& 
> runtimeOptions.containsKey("javax.portlet.actionScopedRequestAttributes")
>&& 
> runtimeOptions.get("javax.portlet.escapeXml")[0].equals("true")
>&& 
> runtimeOptions.get("javax.portlet.actionScopedRequestAttributes")[0].equals("true")){
> result.setTcSuccess(true);
>  }
> {code}
> The problem is that the {{javax.portlet.actionScopedRequestAttributes}} 
> container-runtime-option is optional.
> Similar to the solution for fixing PLUTO-715, this issue serves as a task for 
> introducing "pluto" and "liferay" maven profiles that account for the 
> differences.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-735) Update the liferay maven profile for the V3 demos and TCK tests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-735.
--
Resolution: Fixed

> Update the liferay maven profile for the V3 demos and TCK tests
> ---
>
> Key: PLUTO-735
> URL: https://issues.apache.org/jira/browse/PLUTO-735
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This issue encompasses various small tasks related {{liferay}} Maven 
> profiles in the V3 demos and TCK tests.
> For example:
> - The Liferay implementation of the CDI portable extension is no longer 
> required to be included in WEB-INF/lib.
> - Similar to PLUTO-662, a Liferay-specific Maven profile needs to be added to 
> the V3ResourceAsyncTests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-736) Missing configuration in liferay-portlet.xml for AnnotationPortletAppConfigOverrideTests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-736:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> Missing configuration in liferay-portlet.xml for 
> AnnotationPortletAppConfigOverrideTests
> 
>
> Key: PLUTO-736
> URL: https://issues.apache.org/jira/browse/PLUTO-736
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> The liferay-portlet.xml descriptor for 
> AnnotationPortletAppConfigOverrideTests in the TCK is missing configuration 
> for some of the portlets defined via the `@PortletConfiguration` annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-736) Missing configuration in liferay-portlet.xml for AnnotationPortletAppConfigOverrideTests

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-736:


> Missing configuration in liferay-portlet.xml for 
> AnnotationPortletAppConfigOverrideTests
> 
>
> Key: PLUTO-736
> URL: https://issues.apache.org/jira/browse/PLUTO-736
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> The liferay-portlet.xml descriptor for 
> AnnotationPortletAppConfigOverrideTests in the TCK is missing configuration 
> for some of the portlets defined via the `@PortletConfiguration` annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-737) StaleElementReferenceException with selenium: stale element reference

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-737:


> StaleElementReferenceException with selenium: stale element reference
> -
>
> Key: PLUTO-737
> URL: https://issues.apache.org/jira/browse/PLUTO-737
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Vernon Singleton
>Assignee: Neil Griffin
>Priority: Minor
> Fix For: 3.1.0
>
>
> Intermittently, selenium fails a test with the error:
>  stale element reference: element is not attached to the page document
> example tests which occasionally fail this way:
>  V3HeaderPortletTests_SPEC14_PortletRequest_ApiHeader_setAttribute1
>  V2URLTests_BaseURL_ApiRenderRenurl_setSecure2
> V2WrapperTests_EventResponseWrapper_ApiEvent_getWindowState



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-738) improve TCKSimpleDriver to allow driver.get when accessing a portal page

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-738.
--
Resolution: Fixed

> improve TCKSimpleDriver to allow driver.get when accessing a portal page
> 
>
> Key: PLUTO-738
> URL: https://issues.apache.org/jira/browse/PLUTO-738
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Vernon Singleton
>Assignee: Neil Griffin
>Priority: Minor
> Fix For: 3.0.2-TCK
>
>
> Depending on the implementation, when accessing a portal page, it may be 
> necessary to do a driver.get instead of having the browser click on a link to 
> the page.  TCKSimpleDriver will continue click on a link to access the page 
> in the pluto tck.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-737) StaleElementReferenceException with selenium: stale element reference

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-737.
--
Resolution: Fixed

> StaleElementReferenceException with selenium: stale element reference
> -
>
> Key: PLUTO-737
> URL: https://issues.apache.org/jira/browse/PLUTO-737
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Vernon Singleton
>Assignee: Neil Griffin
>Priority: Minor
> Fix For: 3.0.2-TCK
>
>
> Intermittently, selenium fails a test with the error:
>  stale element reference: element is not attached to the page document
> example tests which occasionally fail this way:
>  V3HeaderPortletTests_SPEC14_PortletRequest_ApiHeader_setAttribute1
>  V2URLTests_BaseURL_ApiRenderRenurl_setSecure2
> V2WrapperTests_EventResponseWrapper_ApiEvent_getWindowState



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-737) StaleElementReferenceException with selenium: stale element reference

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-737:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> StaleElementReferenceException with selenium: stale element reference
> -
>
> Key: PLUTO-737
> URL: https://issues.apache.org/jira/browse/PLUTO-737
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Vernon Singleton
>Assignee: Neil Griffin
>Priority: Minor
> Fix For: 3.0.2-TCK
>
>
> Intermittently, selenium fails a test with the error:
>  stale element reference: element is not attached to the page document
> example tests which occasionally fail this way:
>  V3HeaderPortletTests_SPEC14_PortletRequest_ApiHeader_setAttribute1
>  V2URLTests_BaseURL_ApiRenderRenurl_setSecure2
> V2WrapperTests_EventResponseWrapper_ApiEvent_getWindowState



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-739) Improve build speed by not installing TCK portlets into local maven repository

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-739.
--
Resolution: Won't Fix

> Improve build speed by not installing TCK portlets into local maven repository
> --
>
> Key: PLUTO-739
> URL: https://issues.apache.org/jira/browse/PLUTO-739
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
>
> This task involves adding the following marking to each individual pom.xml 
> descriptor of the TCK portlets:
> {code:xml|title=pom.xml}
>  
> maven-install-plugin
> 
>true
> 
>  
> {code}
> The markup cannot be added to the parent pom 
> (portals-pluto/portlet-tck_3.0/pom.xml) because the parent pom needs to be 
> installed, as well as some child modules such as common.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-738) improve TCKSimpleDriver to allow driver.get when accessing a portal page

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-738:


> improve TCKSimpleDriver to allow driver.get when accessing a portal page
> 
>
> Key: PLUTO-738
> URL: https://issues.apache.org/jira/browse/PLUTO-738
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Vernon Singleton
>Assignee: Neil Griffin
>Priority: Minor
> Fix For: 3.1.0
>
>
> Depending on the implementation, when accessing a portal page, it may be 
> necessary to do a driver.get instead of having the browser click on a link to 
> the page.  TCKSimpleDriver will continue click on a link to access the page 
> in the pluto tck.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-738) improve TCKSimpleDriver to allow driver.get when accessing a portal page

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-738:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> improve TCKSimpleDriver to allow driver.get when accessing a portal page
> 
>
> Key: PLUTO-738
> URL: https://issues.apache.org/jira/browse/PLUTO-738
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Vernon Singleton
>Assignee: Neil Griffin
>Priority: Minor
> Fix For: 3.0.2-TCK
>
>
> Depending on the implementation, when accessing a portal page, it may be 
> necessary to do a driver.get instead of having the browser click on a link to 
> the page.  TCKSimpleDriver will continue click on a link to access the page 
> in the pluto tck.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-740) Support selective TCK test execution for HTMLUnit

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-740:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> Support selective TCK test execution for HTMLUnit
> -
>
> Key: PLUTO-740
> URL: https://issues.apache.org/jira/browse/PLUTO-740
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> In order to improve testing speed, this task involves adding the ability for 
> the TCK to run HTMLUnit as much as possible by marking tests that are not 
> possible to execute via HTMLUnit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-741) Assume that the TCK runs headless for all browsers

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-741.
--
Resolution: Fixed

> Assume that the TCK runs headless for all browsers
> --
>
> Key: PLUTO-741
> URL: https://issues.apache.org/jira/browse/PLUTO-741
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> As a follow-up to PLUTO-661, now that Firefox has a headless mode, the TCK 
> default setting can be set to headless. Headless mode can be assumed for 
> Firefox, Chrome, HTMLUnit, and PhantomJS.
> This means that {{-Dtest.browser.headless=true}} is the default but it can be 
> disabled by specifying  {{-Dtest.browser.headless=false}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-741) Assume that the TCK runs headless for all browsers

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-741:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> Assume that the TCK runs headless for all browsers
> --
>
> Key: PLUTO-741
> URL: https://issues.apache.org/jira/browse/PLUTO-741
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> As a follow-up to PLUTO-661, now that Firefox has a headless mode, the TCK 
> default setting can be set to headless. Headless mode can be assumed for 
> Firefox, Chrome, HTMLUnit, and PhantomJS.
> This means that {{-Dtest.browser.headless=true}} is the default but it can be 
> disabled by specifying  {{-Dtest.browser.headless=false}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-740) Support selective TCK test execution for HTMLUnit

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-740:


> Support selective TCK test execution for HTMLUnit
> -
>
> Key: PLUTO-740
> URL: https://issues.apache.org/jira/browse/PLUTO-740
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> In order to improve testing speed, this task involves adding the ability for 
> the TCK to run HTMLUnit as much as possible by marking tests that are not 
> possible to execute via HTMLUnit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-744) Improve exception handling with an AssertionError

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-744:


> Improve exception handling with an AssertionError
> -
>
> Key: PLUTO-744
> URL: https://issues.apache.org/jira/browse/PLUTO-744
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0
>Reporter: Vernon Singleton
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> Throw an AssertionError instead of swallowing exceptions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-740) Support selective TCK test execution for HTMLUnit

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-740.
--
Resolution: Fixed

> Support selective TCK test execution for HTMLUnit
> -
>
> Key: PLUTO-740
> URL: https://issues.apache.org/jira/browse/PLUTO-740
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> In order to improve testing speed, this task involves adding the ability for 
> the TCK to run HTMLUnit as much as possible by marking tests that are not 
> possible to execute via HTMLUnit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-751) V3AnnotationPortletArtifactValidityTests inject dependent-scoped strings into @ApplicationScoped beans

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-751.
--
Resolution: Fixed

> V3AnnotationPortletArtifactValidityTests inject dependent-scoped strings into 
> @ApplicationScoped beans
> --
>
> Key: PLUTO-751
> URL: https://issues.apache.org/jira/browse/PLUTO-751
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Three classes in V3AnnotationPortletArtifactValidityTests inject a 
> dependent-scoped {{String}}  (the value for which is the portlet name, which 
> is associated with the portlet request):
> {code:java}
> @Inject
> @PortletName
> private String portletName;
> {code}
> The fix would be to follow the pattern already found elsewhere in the tests 
> by injecting the {{@PortletRequestScoped PortletRequestScopedArtifacts}} 
> instance and calling the {{getPortletName()}} method:
> {code:java}
> @Inject
> private PortletRequestScopedArtifacts portletRequestScopedArtifacts;
> ...
> String portletName = portletRequestScopedArtifacts.getPortletName();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-744) Improve exception handling with an AssertionError

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-744.
--
Resolution: Fixed

> Improve exception handling with an AssertionError
> -
>
> Key: PLUTO-744
> URL: https://issues.apache.org/jira/browse/PLUTO-744
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0
>Reporter: Vernon Singleton
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Throw an AssertionError instead of swallowing exceptions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-741) Assume that the TCK runs headless for all browsers

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-741:


> Assume that the TCK runs headless for all browsers
> --
>
> Key: PLUTO-741
> URL: https://issues.apache.org/jira/browse/PLUTO-741
> Project: Pluto
>  Issue Type: Task
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> As a follow-up to PLUTO-661, now that Firefox has a headless mode, the TCK 
> default setting can be set to headless. Headless mode can be assumed for 
> Firefox, Chrome, HTMLUnit, and PhantomJS.
> This means that {{-Dtest.browser.headless=true}} is the default but it can be 
> disabled by specifying  {{-Dtest.browser.headless=false}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-751) V3AnnotationPortletArtifactValidityTests inject dependent-scoped strings into @ApplicationScoped beans

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-751:


> V3AnnotationPortletArtifactValidityTests inject dependent-scoped strings into 
> @ApplicationScoped beans
> --
>
> Key: PLUTO-751
> URL: https://issues.apache.org/jira/browse/PLUTO-751
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> Three classes in V3AnnotationPortletArtifactValidityTests inject a 
> dependent-scoped {{String}}  (the value for which is the portlet name, which 
> is associated with the portlet request):
> {code:java}
> @Inject
> @PortletName
> private String portletName;
> {code}
> The fix would be to follow the pattern already found elsewhere in the tests 
> by injecting the {{@PortletRequestScoped PortletRequestScopedArtifacts}} 
> instance and calling the {{getPortletName()}} method:
> {code:java}
> @Inject
> private PortletRequestScopedArtifacts portletRequestScopedArtifacts;
> ...
> String portletName = portletRequestScopedArtifacts.getPortletName();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-759) Introduce properties into the TCK pom.xml descriptor so that test lists and list names can be overridden from the command line

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-759.
--
Resolution: Fixed

> Introduce properties into the TCK pom.xml descriptor so that test lists and 
> list names can be overridden from the command line
> --
>
> Key: PLUTO-759
> URL: https://issues.apache.org/jira/browse/PLUTO-759
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This task involves introducing properties into the TCK pom.xml descriptor so 
> that test lists and list names can be overridden from the command line. It 
> will also make it possible to remove certain TCK config files from the source 
> tree that are Liferay-specific.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-755) Introduce a liferay-spring Maven profile in order to test the demos and TCK with the Spring implementation of bean portlets in Liferay

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-755:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> Introduce a liferay-spring Maven profile in order to test the demos and TCK 
> with the Spring implementation of bean portlets in Liferay
> --
>
> Key: PLUTO-755
> URL: https://issues.apache.org/jira/browse/PLUTO-755
> Project: Pluto
>  Issue Type: Task
>  Components: demo portlets, tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This issue serves as a task for introducing a {{liferay-spring}} Maven 
> profile in order to test the demos and TCK with the Spring implementation of 
> bean portlets in Liferay.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-759) Introduce properties into the TCK pom.xml descriptor so that test lists and list names can be overridden from the command line

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-759:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> Introduce properties into the TCK pom.xml descriptor so that test lists and 
> list names can be overridden from the command line
> --
>
> Key: PLUTO-759
> URL: https://issues.apache.org/jira/browse/PLUTO-759
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This task involves introducing properties into the TCK pom.xml descriptor so 
> that test lists and list names can be overridden from the command line. It 
> will also make it possible to remove certain TCK config files from the source 
> tree that are Liferay-specific.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-754) Improve performance of the V3PortletHubTests by registering the PortletHub dependency

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-754.
--
Resolution: Fixed

> Improve performance of the V3PortletHubTests by registering the PortletHub 
> dependency
> -
>
> Key: PLUTO-754
> URL: https://issues.apache.org/jira/browse/PLUTO-754
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Similar to PLUTO-753, the V3PortletHubTests adds the PortletHub as a 
> dependency in a header method that gets executed on every request.
> Performance can be improved by registering the dependency with 
> {{@PortletConfiguration}} instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-751) V3AnnotationPortletArtifactValidityTests inject dependent-scoped strings into @ApplicationScoped beans

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-751:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> V3AnnotationPortletArtifactValidityTests inject dependent-scoped strings into 
> @ApplicationScoped beans
> --
>
> Key: PLUTO-751
> URL: https://issues.apache.org/jira/browse/PLUTO-751
> Project: Pluto
>  Issue Type: Bug
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Three classes in V3AnnotationPortletArtifactValidityTests inject a 
> dependent-scoped {{String}}  (the value for which is the portlet name, which 
> is associated with the portlet request):
> {code:java}
> @Inject
> @PortletName
> private String portletName;
> {code}
> The fix would be to follow the pattern already found elsewhere in the tests 
> by injecting the {{@PortletRequestScoped PortletRequestScopedArtifacts}} 
> instance and calling the {{getPortletName()}} method:
> {code:java}
> @Inject
> private PortletRequestScopedArtifacts portletRequestScopedArtifacts;
> ...
> String portletName = portletRequestScopedArtifacts.getPortletName();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-754) Improve performance of the V3PortletHubTests by registering the PortletHub dependency

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-754:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> Improve performance of the V3PortletHubTests by registering the PortletHub 
> dependency
> -
>
> Key: PLUTO-754
> URL: https://issues.apache.org/jira/browse/PLUTO-754
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> Similar to PLUTO-753, the V3PortletHubTests adds the PortletHub as a 
> dependency in a header method that gets executed on every request.
> Performance can be improved by registering the dependency with 
> {{@PortletConfiguration}} instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-754) Improve performance of the V3PortletHubTests by registering the PortletHub dependency

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-754:


> Improve performance of the V3PortletHubTests by registering the PortletHub 
> dependency
> -
>
> Key: PLUTO-754
> URL: https://issues.apache.org/jira/browse/PLUTO-754
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> Similar to PLUTO-753, the V3PortletHubTests adds the PortletHub as a 
> dependency in a header method that gets executed on every request.
> Performance can be improved by registering the dependency with 
> {{@PortletConfiguration}} instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-755) Introduce a liferay-spring Maven profile in order to test the demos and TCK with the Spring implementation of bean portlets in Liferay

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-755:


> Introduce a liferay-spring Maven profile in order to test the demos and TCK 
> with the Spring implementation of bean portlets in Liferay
> --
>
> Key: PLUTO-755
> URL: https://issues.apache.org/jira/browse/PLUTO-755
> Project: Pluto
>  Issue Type: Task
>  Components: demo portlets, tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> This issue serves as a task for introducing a {{liferay-spring}} Maven 
> profile in order to test the demos and TCK with the Spring implementation of 
> bean portlets in Liferay.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-755) Introduce a liferay-spring Maven profile in order to test the demos and TCK with the Spring implementation of bean portlets in Liferay

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-755.
--
Resolution: Fixed

> Introduce a liferay-spring Maven profile in order to test the demos and TCK 
> with the Spring implementation of bean portlets in Liferay
> --
>
> Key: PLUTO-755
> URL: https://issues.apache.org/jira/browse/PLUTO-755
> Project: Pluto
>  Issue Type: Task
>  Components: demo portlets, tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This issue serves as a task for introducing a {{liferay-spring}} Maven 
> profile in order to test the demos and TCK with the Spring implementation of 
> bean portlets in Liferay.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-761) Skip ignored TCK tests so that JUnit provides a list of skipped tests after running

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-761.
--
Resolution: Fixed

> Skip ignored TCK tests so that JUnit provides a list of skipped tests after 
> running
> ---
>
> Key: PLUTO-761
> URL: https://issues.apache.org/jira/browse/PLUTO-761
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This task involves making the TCK test framework skip ignored tests so that 
> JUnit provides a list of skipped tests after test runs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-759) Introduce properties into the TCK pom.xml descriptor so that test lists and list names can be overridden from the command line

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-759:


> Introduce properties into the TCK pom.xml descriptor so that test lists and 
> list names can be overridden from the command line
> --
>
> Key: PLUTO-759
> URL: https://issues.apache.org/jira/browse/PLUTO-759
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> This task involves introducing properties into the TCK pom.xml descriptor so 
> that test lists and list names can be overridden from the command line. It 
> will also make it possible to remove certain TCK config files from the source 
> tree that are Liferay-specific.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-761) Skip ignored TCK tests so that JUnit provides a list of skipped tests after running

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-761:


> Skip ignored TCK tests so that JUnit provides a list of skipped tests after 
> running
> ---
>
> Key: PLUTO-761
> URL: https://issues.apache.org/jira/browse/PLUTO-761
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> This task involves making the TCK test framework skip ignored tests so that 
> JUnit provides a list of skipped tests after test runs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (PLUTO-760) Disable unnecessary HtmlUnit logging and exceptions

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin reopened PLUTO-760:


> Disable unnecessary HtmlUnit logging and exceptions
> ---
>
> Key: PLUTO-760
> URL: https://issues.apache.org/jira/browse/PLUTO-760
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.1.0
>
>
> This task involves disabling unnecessary HtmlUnit logging and exceptions in 
> order to make the test output less verbose and easier to read.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-760) Disable unnecessary HtmlUnit logging and exceptions

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-760:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> Disable unnecessary HtmlUnit logging and exceptions
> ---
>
> Key: PLUTO-760
> URL: https://issues.apache.org/jira/browse/PLUTO-760
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This task involves disabling unnecessary HtmlUnit logging and exceptions in 
> order to make the test output less verbose and easier to read.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-762) Use regular expression replacement instead of hard-coded string indexes in the TCKLiferayTestDriver

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-762.
--
Resolution: Fixed

> Use regular expression replacement instead of hard-coded string indexes in 
> the TCKLiferayTestDriver
> ---
>
> Key: PLUTO-762
> URL: https://issues.apache.org/jira/browse/PLUTO-762
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This task involves refactoring hard-coded string indexes in the 
> TCKLiferayTestDriver to use regular expression replacement instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (PLUTO-760) Disable unnecessary HtmlUnit logging and exceptions

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin closed PLUTO-760.
--
Resolution: Fixed

> Disable unnecessary HtmlUnit logging and exceptions
> ---
>
> Key: PLUTO-760
> URL: https://issues.apache.org/jira/browse/PLUTO-760
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This task involves disabling unnecessary HtmlUnit logging and exceptions in 
> order to make the test output less verbose and easier to read.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PLUTO-762) Use regular expression replacement instead of hard-coded string indexes in the TCKLiferayTestDriver

2019-04-10 Thread Neil Griffin (JIRA)


 [ 
https://issues.apache.org/jira/browse/PLUTO-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-762:
---
Fix Version/s: (was: 3.1.0)
   3.0.2-TCK

> Use regular expression replacement instead of hard-coded string indexes in 
> the TCKLiferayTestDriver
> ---
>
> Key: PLUTO-762
> URL: https://issues.apache.org/jira/browse/PLUTO-762
> Project: Pluto
>  Issue Type: Improvement
>  Components: tck
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This task involves refactoring hard-coded string indexes in the 
> TCKLiferayTestDriver to use regular expression replacement instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)