[ https://issues.apache.org/jira/browse/PLUTO-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116123#comment-16116123 ]
Scott Nicklous commented on PLUTO-658: -------------------------------------- I agree with your findings and also with the proposed fix. I believe that the pull request should be merged. > TCK: Contesting V2ADDLENVIRONMENTTESTS_SPEC2_10_CONTEXT_GETREALPATH > ------------------------------------------------------------------- > > Key: PLUTO-658 > URL: https://issues.apache.org/jira/browse/PLUTO-658 > Project: Pluto > Issue Type: Bug > Components: tck > Affects Versions: 3.0.0 > Reporter: Vernon Singleton > Assignee: Scott Nicklous > Priority: Minor > > 1) The Javadoc [shows that the PortletContext.getRealPath() > method|http://msnicklous.github.io/portletspec3/apidocs/javax/portlet/PortletContext.html#getRealPath%28java.lang.String%29] > is allowed to return null. > PortletContext.getRealPath() states, "Returns: a String > specifying the real path, or null if the transformation > cannot be performed." > 2) test V2ADDLENVIRONMENTTESTS_SPEC2_10_CONTEXT_GETREALPATH in the tck > does not allow for the values to be null, and [the test > assumes|https://github.com/apache/portals-pluto/blob/master/portlet-tck_3.0/V2AddlEnvironmentTests/src/main/java/javax/portlet/tck/portlets/AddlEnvironmentTests_SPEC2_10_Context.java#L333] > that > the getRealPath method will always return a non-null String. > 3) test V2ADDLENVIRONMENTTESTS_SPEC2_10_CONTEXT_GETREALPATH in the tck > needs to account for all possible options in the Javadoc, which includes > the possiblility of returning null when calling PortletContext.getRealPath(). > Will send a PR in the comments with suggested fix for the tck test. -- This message was sent by Atlassian JIRA (v6.4.14#64029)