Re: [pmacct-discussion] minor patch for geoip and json output

2014-02-22 Thread Paolo Lucente
Thanks Stig, Patch applied and committed to CVS. Thanks also for the note about docs. I didn't know about geoip2, just had a quick read through it. Should anybody have a strong view we should add support for geoip2 please give a shout here - along with a bit of elaboration on a use-case, benefits

Re: [pmacct-discussion] minor patch for geoip and json output

2014-02-21 Thread Stig Thormodsrud
Also related to geoip lookups, it might be worth adding to the documentation that this is for geoip 1 not geoip2. I just googled "mindmax free geoip database" and download the free geoip2 database (not know there was a geoip1). When I fire up pmacct pointing to the geoip2 database it seg faults i

[pmacct-discussion] minor patch for geoip and json output

2014-02-21 Thread Stig Thormodsrud
I noticed when using geoip and json output that the country_ip_src was displayed but not the country_ip_dst. This patch seems to fix it: diff --git a/src/pmacct.c b/src/pmacct.c index d62ba44..b29c7a3 100644 --- a/src/pmacct.c +++ b/src/pmacct.c @@ -2996,7 +2996,7 @@ char *pmc_compose_json(u_int6